diff options
author | Simo Sorce <simo@redhat.com> | 2013-04-03 14:38:58 -0400 |
---|---|---|
committer | Simo Sorce <simo@redhat.com> | 2013-04-03 16:39:11 -0400 |
commit | b5fd9388baba101a3ae7b8a2f88164af2083a0a7 (patch) | |
tree | 029c20ad0de3f25859f649af50f96da282f3da90 /proxy | |
parent | c4cddebdc4d1062c46145a2623f276631840e221 (diff) | |
download | gss-proxy-b5fd9388baba101a3ae7b8a2f88164af2083a0a7.tar.gz gss-proxy-b5fd9388baba101a3ae7b8a2f88164af2083a0a7.tar.xz gss-proxy-b5fd9388baba101a3ae7b8a2f88164af2083a0a7.zip |
Fix reporting of wrong error codes
Found by Coverity as 'Argument cannot be negative' type of error.
Signed-off-by: Simo Sorce <simo@redhat.com>
Diffstat (limited to 'proxy')
-rw-r--r-- | proxy/src/client/gpm_common.c | 3 | ||||
-rw-r--r-- | proxy/src/gp_init.c | 3 |
2 files changed, 6 insertions, 0 deletions
diff --git a/proxy/src/client/gpm_common.c b/proxy/src/client/gpm_common.c index d3dbaff..80f487c 100644 --- a/proxy/src/client/gpm_common.c +++ b/proxy/src/client/gpm_common.c @@ -98,6 +98,9 @@ static int gpm_open_socket(struct gpm_ctx *gpmctx) } ret = connect(fd, (struct sockaddr *)&addr, sizeof(addr)); + if (ret == -1) { + ret = errno; + } done: if (ret) { diff --git a/proxy/src/gp_init.c b/proxy/src/gp_init.c index 2b02904..f25adc4 100644 --- a/proxy/src/gp_init.c +++ b/proxy/src/gp_init.c @@ -164,6 +164,7 @@ void init_proc_nfsd(struct gp_config *cfg) ret = write(fd, buf, 1); if (ret != 1) { + ret = errno; GPDEBUG("Failed to write to %s: %d (%s)\n", LINUX_PROC_USE_GSS_PROXY_FILE, ret, strerror(ret)); @@ -172,6 +173,7 @@ void init_proc_nfsd(struct gp_config *cfg) ret = close(fd); if (ret == -1) { + ret = errno; GPDEBUG("Failed to close %s: %d (%s)\n", LINUX_PROC_USE_GSS_PROXY_FILE, ret, strerror(ret)); @@ -204,6 +206,7 @@ void write_pid(void) ret = fclose(f); if (ret != 0) { + ret = errno; GPDEBUG("Failed to close %s: %d (%s)\n", GP_PID_FILE, ret, strerror(ret)); return; |