summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimo Sorce <simo@redhat.com>2013-04-03 09:21:09 -0400
committerSimo Sorce <simo@redhat.com>2013-04-03 16:39:11 -0400
commit94a4d4947c41379fb74e229b1b0b00d554f170be (patch)
tree20c2770aa878c0e46f74c57c67f06cea72cad081
parent2f517022d110a2e586735735953dda78051a5b95 (diff)
downloadgss-proxy-94a4d4947c41379fb74e229b1b0b00d554f170be.tar.gz
gss-proxy-94a4d4947c41379fb74e229b1b0b00d554f170be.tar.xz
gss-proxy-94a4d4947c41379fb74e229b1b0b00d554f170be.zip
Fix locally dead code error found by coverity
By setting closewait to 0 after waitpid we would loop forever not the max 10 times we intended to. Signed-off-by: Simo Sorce <simo@redhat.com>
-rw-r--r--proxy/tests/interposetest.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/proxy/tests/interposetest.c b/proxy/tests/interposetest.c
index 5912ec5..83e550d 100644
--- a/proxy/tests/interposetest.c
+++ b/proxy/tests/interposetest.c
@@ -857,7 +857,6 @@ static int run_cli_srv_test(int server_proxy_type,
options = WNOHANG;
}
w = waitpid(-1, &status, options);
- closewait = 0;
if (w == cli) {
cli = -1;
} else if (w == srv) {
@@ -872,10 +871,10 @@ static int run_cli_srv_test(int server_proxy_type,
if (closewait > 10) {
ret = -1;
goto done;
- } else {
- usleep(100000);
- closewait++;
}
+
+ usleep(100000);
+ closewait++;
}
ret = 0;