<feed xmlns='http://www.w3.org/2005/Atom'>
<title>gss-proxy.git/proxy/src, branch master-ndr</title>
<subtitle>gssproxy wip repository</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/'/>
<entry>
<title>Use gssproxy.idl generated code for debugging.</title>
<updated>2013-05-24T09:56:58+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gdeschner@redhat.com</email>
</author>
<published>2013-03-08T11:42:06+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=14d34ba274df825dc486051171e31507de219234'/>
<id>14d34ba274df825dc486051171e31507de219234</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix realloc size in gp_get_cred_environment().</title>
<updated>2013-05-22T15:37:52+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gdeschner@redhat.com</email>
</author>
<published>2013-05-22T15:26:00+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=4ceed9a85484bdde3d355d21ceb666dc8d910910'/>
<id>4ceed9a85484bdde3d355d21ceb666dc8d910910</id>
<content type='text'>
This fixes a segfault when no client_keytab is passed in via cred_store api.
See https://fedorahosted.org/gss-proxy/ticket/85 for details.

Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes a segfault when no client_keytab is passed in via cred_store api.
See https://fedorahosted.org/gss-proxy/ticket/85 for details.

Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Overwrite existing GSS_USE_PROXY variable in the server.</title>
<updated>2013-05-16T10:11:43+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gdeschner@redhat.com</email>
</author>
<published>2013-05-16T07:30:17+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=2bd59288ca3625c4d03f68b967a8c4c1f50022cd'/>
<id>2bd59288ca3625c4d03f68b967a8c4c1f50022cd</id>
<content type='text'>
This is required to make sure we never recurse into ourselves.

Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is required to make sure we never recurse into ourselves.

Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix socket error handling.</title>
<updated>2013-05-16T10:11:43+00:00</updated>
<author>
<name>Simo Sorce</name>
<email>simo@redhat.com</email>
</author>
<published>2013-05-15T17:22:05+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=4d95d30532e2509a07285614b2f17a26dcb44725'/>
<id>4d95d30532e2509a07285614b2f17a26dcb44725</id>
<content type='text'>
1. Grab the socket lock for the whole conversation.

We need to keep the lock until the whole conversation is over.
Otherwise we may have concurrency issues where communication gets intermixed
and errors in one thread can cause a thread to hang.

Here is what we observed:

thread 1: grabs lock and send a request.
thread 2: grabs lock and sends a request
server: thread 2 request causes a fatal error and the server close the
connection
thread 2: grabs the lock and waits for a reply.
thread 2: gets the error and returns to caller with it (connection is closed).
thread 1: grabs the lock (which reopens the closed channel) and reads ...
... forever as the server has already killed all the previous state.

2. Fail immediately on short reads for the initial 4 byte length header.

If the first 4 bytes do not come at once don't bother retrying. In 99.9% of the
cases what we are witnessing here is a fatal error from the proxy that closed
the socket. Reopening the scket cannot accomplish anything as the request sent
down the channel is tied to the specific socket, so once the socket is closed
there is no hope to ever get back a reply.

Signed-off-by: Simo Sorce &lt;simo@redhat.com&gt;
Reviewed-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
1. Grab the socket lock for the whole conversation.

We need to keep the lock until the whole conversation is over.
Otherwise we may have concurrency issues where communication gets intermixed
and errors in one thread can cause a thread to hang.

Here is what we observed:

thread 1: grabs lock and send a request.
thread 2: grabs lock and sends a request
server: thread 2 request causes a fatal error and the server close the
connection
thread 2: grabs the lock and waits for a reply.
thread 2: gets the error and returns to caller with it (connection is closed).
thread 1: grabs the lock (which reopens the closed channel) and reads ...
... forever as the server has already killed all the previous state.

2. Fail immediately on short reads for the initial 4 byte length header.

If the first 4 bytes do not come at once don't bother retrying. In 99.9% of the
cases what we are witnessing here is a fatal error from the proxy that closed
the socket. Reopening the scket cannot accomplish anything as the request sent
down the channel is tied to the specific socket, so once the socket is closed
there is no hope to ever get back a reply.

Signed-off-by: Simo Sorce &lt;simo@redhat.com&gt;
Reviewed-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix secondary socket detection at runtime.</title>
<updated>2013-05-16T10:11:42+00:00</updated>
<author>
<name>Simo Sorce</name>
<email>simo@redhat.com</email>
</author>
<published>2013-05-15T16:11:30+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=b693f4680a3dfadc2289ca1b1d83725f395bec49'/>
<id>b693f4680a3dfadc2289ca1b1d83725f395bec49</id>
<content type='text'>
We were failing to find the right service as the test was reversed.
It works with the default socket as it is not stored per service.

Signed-off-by: Simo Sorce &lt;simo@redhat.com&gt;
Reviewed-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We were failing to find the right service as the test was reversed.
It works with the default socket as it is not stored per service.

Signed-off-by: Simo Sorce &lt;simo@redhat.com&gt;
Reviewed-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Disable gss_export_name_composite() for now.</title>
<updated>2013-05-16T10:11:42+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gdeschner@redhat.com</email>
</author>
<published>2013-05-16T10:06:19+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=94d395f36e996f19d7e10a54c734f8bc0dc21da1'/>
<id>94d395f36e996f19d7e10a54c734f8bc0dc21da1</id>
<content type='text'>
We first need to fix our tests and implementation.

Temporary workaround for:
https://fedorahosted.org/gss-proxy/ticket/81

Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We first need to fix our tests and implementation.

Temporary workaround for:
https://fedorahosted.org/gss-proxy/ticket/81

Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Neutralize gssi_export_name.</title>
<updated>2013-05-16T10:04:23+00:00</updated>
<author>
<name>Simo Sorce</name>
<email>simo@redhat.com</email>
</author>
<published>2013-05-15T15:10:01+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=5222196a6018fa5a6b47c2f5492ff2762a9a7c27'/>
<id>5222196a6018fa5a6b47c2f5492ff2762a9a7c27</id>
<content type='text'>
We do not want to generate an exported name buffer.
Let's the mechglue code in MIT generate it for use from the display name.

Signed-off-by: Simo Sorce &lt;simo@redhat.com&gt;
Reviewed-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We do not want to generate an exported name buffer.
Let's the mechglue code in MIT generate it for use from the display name.

Signed-off-by: Simo Sorce &lt;simo@redhat.com&gt;
Reviewed-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix two memleaks in the configuration code.</title>
<updated>2013-05-15T11:34:46+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gdeschner@redhat.com</email>
</author>
<published>2013-05-15T08:47:15+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=0b506dd9387f468e1f049dc7e07e6e31a1d1c1ac'/>
<id>0b506dd9387f468e1f049dc7e07e6e31a1d1c1ac</id>
<content type='text'>
Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Don't forget to free gp_ini_context struct in load_config().</title>
<updated>2013-05-15T11:34:46+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gdeschner@redhat.com</email>
</author>
<published>2013-05-15T08:38:03+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=1b1bd19911322d84f30e1935f7b4a568bd358741'/>
<id>1b1bd19911322d84f30e1935f7b4a568bd358741</id>
<content type='text'>
Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Use counter when freeing cred_store configuration.</title>
<updated>2013-05-15T11:34:46+00:00</updated>
<author>
<name>Günther Deschner</name>
<email>gdeschner@redhat.com</email>
</author>
<published>2013-05-15T08:37:10+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/gd/public_git/gss-proxy.git/commit/?id=d6f07e3af3893ab2a8ad72a141b0b3e667df493e'/>
<id>d6f07e3af3893ab2a8ad72a141b0b3e667df493e</id>
<content type='text'>
Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Günther Deschner &lt;gdeschner@redhat.com&gt;
Reviewed-by: Simo Sorce &lt;simo@redhat.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
