gss-proxy.git/proxy/src/client/gpm_common.c, branch master-impersonation

Fix socket error handling.

2013-05-16T10:11:43+00:00

1. Grab the socket lock for the whole conversation.

We need to keep the lock until the whole conversation is over.
Otherwise we may have concurrency issues where communication gets intermixed
and errors in one thread can cause a thread to hang.

Here is what we observed:

thread 1: grabs lock and send a request.
thread 2: grabs lock and sends a request
server: thread 2 request causes a fatal error and the server close the
connection
thread 2: grabs the lock and waits for a reply.
thread 2: gets the error and returns to caller with it (connection is closed).
thread 1: grabs the lock (which reopens the closed channel) and reads ...
... forever as the server has already killed all the previous state.

2. Fail immediately on short reads for the initial 4 byte length header.

If the first 4 bytes do not come at once don't bother retrying. In 99.9% of the
cases what we are witnessing here is a fatal error from the proxy that closed
the socket. Reopening the scket cannot accomplish anything as the request sent
down the channel is tied to the specific socket, so once the socket is closed
there is no hope to ever get back a reply.

Signed-off-by: Simo Sorce 
Reviewed-by: Günther Deschner

Add support for per-service sockets

2013-04-23T19:02:50+00:00

This way different processes running as the same user can be configured as
different servervices

Signed-off-by: Simo Sorce 
Reviewed-by: Günther Deschner

Use send() in client library to avoid SIGPIPE

2013-04-03T20:39:11+00:00

The client library lives in applications that may not be blocking or ignoring
SIGPIPE. Using write() can cause SIGPIPE to be raised in the application if the
proxy is restarted. If the application does not catch the signal then it is
terminated.

Make sure this does not happen by using send() with the MSG_NOSIGNAL flag.

Signed-off-by: Simo Sorce

Fix reporting of wrong error codes

2013-04-03T20:39:11+00:00

Found by Coverity as 'Argument cannot be negative' type of error.

Signed-off-by: Simo Sorce

Make socket path a configure option

2013-03-22T15:34:37+00:00

The kernel uses the fixed path named /var/run/gssproxy.sock
Make this default a configure time option and default to it.
Also remove the option to change the socket at configure time,
neither the kernel nor proxymech.so can cope with a change anyway.

Fix includes

2013-03-14T17:42:45+00:00

These includes are necessary when switching to gssrpc because they
are not automatically dragged in via dependencies in system rpc.h

Add function to return a special mech

2012-10-25T19:52:37+00:00

When the interposer wants to call the mechglue and have it call a real
mechanism it does so by providing a speecial mechanism oid.
This is an oid composed of the procy plugin oid and the real mechanism oid
that the mechglue transforms back into a real OID before selecting the
appropriate mechanism.

Move client lib files in their own directory

2012-08-31T20:26:38+00:00

Make space for the actual mechglue plugin interface. The mechglue interface
will use the client library to communicate with the gss-proxy but will
reimplement all GSSAPI SPI as wrappers in order to properly handle fallbacks to
local mechanism and other input/output transformations.