From 5bf3512df0529960ed4980251825b49a12eff894 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Tue, 25 Aug 2009 12:57:46 +0200 Subject: pass map_crash_report_t by const reference, not by value Signed-off-by: Denys Vlasenko --- src/Daemon/CommLayerServer.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/Daemon/CommLayerServer.h') diff --git a/src/Daemon/CommLayerServer.h b/src/Daemon/CommLayerServer.h index af79511..38dbac9 100644 --- a/src/Daemon/CommLayerServer.h +++ b/src/Daemon/CommLayerServer.h @@ -31,15 +31,15 @@ class CCommLayerServer { void Detach(CObserver *pObs); void Notify(const std::string& pMessage); - virtual vector_crash_infos_t GetCrashInfos(const std::string &pSender) = 0; - virtual map_crash_report_t CreateReport(const std::string &pUUID,const std::string &pSender) = 0; - virtual report_status_t Report(map_crash_report_t pReport,const std::string &pSender) = 0; + virtual vector_crash_infos_t GetCrashInfos(const std::string& pSender) = 0; + virtual map_crash_report_t CreateReport(const std::string &pUUID, const std::string& pSender) = 0; + virtual report_status_t Report(const map_crash_report_t& pReport, const std::string& pSender) = 0; virtual bool DeleteDebugDump(const std::string& pUUID, const std::string& pSender) = 0; public: /* just stubs to be called when not implemented in specific comm layer */ virtual void Crash(const std::string& arg1) {} - virtual void AnalyzeComplete(map_crash_report_t arg1) {} + virtual void AnalyzeComplete(const map_crash_report_t& arg1) {} virtual void Error(const std::string& arg1) {} virtual void Update(const std::string& pDest, const std::string& pMessage) {}; virtual void Warning(const std::string& pDest, const std::string& pMessage) {}; -- cgit From 3008b32dd0f78b0b2c09e05a7b47080c7cb75d38 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Tue, 25 Aug 2009 14:00:22 +0200 Subject: remove CreateReport() method from server machinery; add comments about DBus Signed-off-by: Denys Vlasenko --- src/Daemon/CommLayerServer.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/Daemon/CommLayerServer.h') diff --git a/src/Daemon/CommLayerServer.h b/src/Daemon/CommLayerServer.h index 38dbac9..afc9ecf 100644 --- a/src/Daemon/CommLayerServer.h +++ b/src/Daemon/CommLayerServer.h @@ -26,18 +26,17 @@ class CCommLayerServer { public: CCommLayerServer(); virtual ~CCommLayerServer(); + /* observer */ void Attach(CObserver *pObs); void Detach(CObserver *pObs); void Notify(const std::string& pMessage); virtual vector_crash_infos_t GetCrashInfos(const std::string& pSender) = 0; - virtual map_crash_report_t CreateReport(const std::string &pUUID, const std::string& pSender) = 0; virtual report_status_t Report(const map_crash_report_t& pReport, const std::string& pSender) = 0; virtual bool DeleteDebugDump(const std::string& pUUID, const std::string& pSender) = 0; - public: - /* just stubs to be called when not implemented in specific comm layer */ + /* just stubs to be called when not implemented in specific comm layer */ virtual void Crash(const std::string& arg1) {} virtual void AnalyzeComplete(const map_crash_report_t& arg1) {} virtual void Error(const std::string& arg1) {} -- cgit From 8f9a5b76761885e908df60af1d0a9d3146b7689c Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Tue, 25 Aug 2009 15:25:56 +0200 Subject: move to_string() helper to abrtlib.h Signed-off-by: Denys Vlasenko --- src/Daemon/CommLayerServer.h | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'src/Daemon/CommLayerServer.h') diff --git a/src/Daemon/CommLayerServer.h b/src/Daemon/CommLayerServer.h index afc9ecf..b8ed7e1 100644 --- a/src/Daemon/CommLayerServer.h +++ b/src/Daemon/CommLayerServer.h @@ -9,17 +9,6 @@ #include "Observer.h" #include "CrashTypes.h" -/* just a helper function */ -template< class T > -std::string -to_string( T x ) -{ - std::ostringstream o; - o << x; - return o.str(); -} - - class CCommLayerServer { protected: CObserver *m_pObserver; -- cgit From facd7083bc1c5f097b7d6795780670644ccfbb1f Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Tue, 25 Aug 2009 15:31:42 +0200 Subject: eliminate one-use class CDBusServer_adaptor Signed-off-by: Denys Vlasenko --- src/Daemon/CommLayerServer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/Daemon/CommLayerServer.h') diff --git a/src/Daemon/CommLayerServer.h b/src/Daemon/CommLayerServer.h index b8ed7e1..76af62b 100644 --- a/src/Daemon/CommLayerServer.h +++ b/src/Daemon/CommLayerServer.h @@ -30,7 +30,7 @@ class CCommLayerServer { virtual void AnalyzeComplete(const map_crash_report_t& arg1) {} virtual void Error(const std::string& arg1) {} virtual void Update(const std::string& pDest, const std::string& pMessage) {}; - virtual void Warning(const std::string& pDest, const std::string& pMessage) {}; + virtual void Warning(const std::string& pMessage) {}; virtual void JobDone(const std::string &pDest, uint64_t pJobID) {}; }; -- cgit