From afb30fe1502e9c45b722da3b5c09e292d589aa7f Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Thu, 4 Mar 2010 16:19:31 +0100 Subject: *: UID:UUID -> crash_id conversion This fixes at least three instances where we did not check whether user is even allowed to report or delete a crash. Also fixes a few cases when root might inadvertently act on (e.g. delete) mote than one crash. Renamed FILENAME_UID to CD_UID - makes more sense this way. Added COL_INFORMALL and CD_INFORMALL. Nuked UID == -1 hacks. Renamed getReport() to start_job on Python side. Dropped a few unused parameters from server -> client dbus signals. Fixed CLI's way of reverencing crashes (see updated help text). Run-tested (GUI and CLI). Signed-off-by: Denys Vlasenko Acked-by: Nikola Pajkovsky --- src/CLI/dbus.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/CLI/dbus.cpp') diff --git a/src/CLI/dbus.cpp b/src/CLI/dbus.cpp index db45cd8..b251c6f 100644 --- a/src/CLI/dbus.cpp +++ b/src/CLI/dbus.cpp @@ -121,11 +121,11 @@ vector_map_crash_data_t call_GetCrashInfos() return argout; } -map_crash_data_t call_CreateReport(const char* uuid) +map_crash_data_t call_CreateReport(const char* crash_id) { DBusMessage* msg = new_call_msg(__func__ + 5); dbus_message_append_args(msg, - DBUS_TYPE_STRING, &uuid, + DBUS_TYPE_STRING, &crash_id, DBUS_TYPE_INVALID); DBusMessage *reply = send_get_reply_and_unref(msg); @@ -166,11 +166,11 @@ report_status_t call_Report(const map_crash_data_t& report, return result; } -int32_t call_DeleteDebugDump(const char* uuid) +int32_t call_DeleteDebugDump(const char* crash_id) { DBusMessage* msg = new_call_msg(__func__ + 5); dbus_message_append_args(msg, - DBUS_TYPE_STRING, &uuid, + DBUS_TYPE_STRING, &crash_id, DBUS_TYPE_INVALID); DBusMessage *reply = send_get_reply_and_unref(msg); -- cgit