From 7a2a2fa7e8d613c69d0fda6c220d97936f56c4fd Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Wed, 28 Oct 2009 23:44:28 +0100 Subject: KerneloopsScanner: do not use global variables needlessly text data bss dec hex filename 27341 1688 48 29077 7195 old/libKerneloopsScanner.so 26466 1672 24 28162 6e02 new/libKerneloopsScanner.so Signed-off-by: Denys Vlasenko --- lib/Plugins/KerneloopsSysLog.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'lib/Plugins/KerneloopsSysLog.h') diff --git a/lib/Plugins/KerneloopsSysLog.h b/lib/Plugins/KerneloopsSysLog.h index c2e8c2d..8d0626b 100644 --- a/lib/Plugins/KerneloopsSysLog.h +++ b/lib/Plugins/KerneloopsSysLog.h @@ -41,8 +41,6 @@ class CSysLog { private: void QueueOops(char *data, char *version); - int ExtractVersion(char *linepointer, char *version); - int FillLinePointers(char *buffer, size_t buflen); std::list m_OopsQueue; int m_nFoundOopses; -- cgit From f369ec1fa4e2886ce01aeea51044d15f0407fed3 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Thu, 29 Oct 2009 00:37:10 +0100 Subject: Kerneloops: remove two classes, vector_string_t works as good Signed-off-by: Denys Vlasenko --- lib/Plugins/KerneloopsSysLog.h | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) (limited to 'lib/Plugins/KerneloopsSysLog.h') diff --git a/lib/Plugins/KerneloopsSysLog.h b/lib/Plugins/KerneloopsSysLog.h index 8d0626b..a67b33d 100644 --- a/lib/Plugins/KerneloopsSysLog.h +++ b/lib/Plugins/KerneloopsSysLog.h @@ -27,28 +27,8 @@ #ifndef __INCLUDE_GUARD_KERNELOOPSSYSLOG_H_ #define __INCLUDE_GUARD_KERNELOOPSSYSLOG_H_ -#include -#include +#include "abrt_types.h" -class COops -{ - public: - std::string m_sData; - std::string m_sVersion; -}; - -class CSysLog -{ - private: - void QueueOops(char *data, char *version); - std::list m_OopsQueue; - int m_nFoundOopses; - - public: - CSysLog(); - const std::list& GetOopsList(); - void ClearOopsList(); - int ExtractOops(char *buffer, size_t buflen); -}; +int extract_oopses(vector_string_t &oopses, char *buffer, size_t buflen); #endif -- cgit