From 7a2a2fa7e8d613c69d0fda6c220d97936f56c4fd Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Wed, 28 Oct 2009 23:44:28 +0100 Subject: KerneloopsScanner: do not use global variables needlessly text data bss dec hex filename 27341 1688 48 29077 7195 old/libKerneloopsScanner.so 26466 1672 24 28162 6e02 new/libKerneloopsScanner.so Signed-off-by: Denys Vlasenko --- lib/Plugins/KerneloopsScanner.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/Plugins/KerneloopsScanner.h') diff --git a/lib/Plugins/KerneloopsScanner.h b/lib/Plugins/KerneloopsScanner.h index 981f187..512fb9c 100644 --- a/lib/Plugins/KerneloopsScanner.h +++ b/lib/Plugins/KerneloopsScanner.h @@ -38,7 +38,7 @@ class CKerneloopsScanner : public CAction CSysLog m_pSysLog; public: - /* For standalone oops processor */ + /* For "dumpoops" tool */ void SaveOopsToDebugDump(); int ScanDmesg(); int ScanSysLogFile(const char *filename); -- cgit From f369ec1fa4e2886ce01aeea51044d15f0407fed3 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Thu, 29 Oct 2009 00:37:10 +0100 Subject: Kerneloops: remove two classes, vector_string_t works as good Signed-off-by: Denys Vlasenko --- lib/Plugins/KerneloopsScanner.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/Plugins/KerneloopsScanner.h') diff --git a/lib/Plugins/KerneloopsScanner.h b/lib/Plugins/KerneloopsScanner.h index 512fb9c..caa5f72 100644 --- a/lib/Plugins/KerneloopsScanner.h +++ b/lib/Plugins/KerneloopsScanner.h @@ -35,7 +35,7 @@ class CKerneloopsScanner : public CAction { private: std::string m_sSysLogFile; - CSysLog m_pSysLog; + vector_string_t m_pOopsList; public: /* For "dumpoops" tool */ -- cgit From f5f29b1aa55aba06498171ad64421424372f1682 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Thu, 29 Oct 2009 01:57:07 +0100 Subject: dumpoops: add -s option to dump results to stdout Signed-off-by: Denys Vlasenko --- lib/Plugins/KerneloopsScanner.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'lib/Plugins/KerneloopsScanner.h') diff --git a/lib/Plugins/KerneloopsScanner.h b/lib/Plugins/KerneloopsScanner.h index caa5f72..6ac0461 100644 --- a/lib/Plugins/KerneloopsScanner.h +++ b/lib/Plugins/KerneloopsScanner.h @@ -27,7 +27,7 @@ #ifndef KERNELOOPSSCANNER_H_ #define KERNELOOPSSCANNER_H_ -#include "KerneloopsSysLog.h" +#include "abrt_types.h" #include "Plugin.h" #include "Action.h" @@ -35,15 +35,19 @@ class CKerneloopsScanner : public CAction { private: std::string m_sSysLogFile; - vector_string_t m_pOopsList; + /* For "dumpoops" tool */ public: + vector_string_t m_pOopsList; + /* For "dumpoops" tool */ + public: void SaveOopsToDebugDump(); int ScanDmesg(); int ScanSysLogFile(const char *filename); /* Plugin interface */ + public: CKerneloopsScanner(); virtual void Run(const std::string& pActionDir, const std::string& pArgs); @@ -51,4 +55,4 @@ class CKerneloopsScanner : public CAction virtual map_plugin_settings_t GetSettings(); }; -#endif /* KERNELOOPSSCANNER_H_ */ +#endif -- cgit From 64c5d35aebc38f93ce5c086c15c15de5acb21b2f Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Thu, 5 Nov 2009 17:21:11 +0100 Subject: InformAllUsers support. enabled by default for Kerneloops. Tested wuth CCpp. Signed-off-by: Denys Vlasenko --- lib/Plugins/KerneloopsScanner.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/Plugins/KerneloopsScanner.h') diff --git a/lib/Plugins/KerneloopsScanner.h b/lib/Plugins/KerneloopsScanner.h index 6ac0461..7352393 100644 --- a/lib/Plugins/KerneloopsScanner.h +++ b/lib/Plugins/KerneloopsScanner.h @@ -34,7 +34,7 @@ class CKerneloopsScanner : public CAction { private: - std::string m_sSysLogFile; + map_plugin_settings_t m_pSettings; /* For "dumpoops" tool */ public: -- cgit From c8e9e69f96c2bd0b9248d6dfab91e2d27ab8e608 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 6 Nov 2009 12:41:24 +0100 Subject: mass replace of const string& params by const char* Signed-off-by: Denys Vlasenko --- lib/Plugins/KerneloopsScanner.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'lib/Plugins/KerneloopsScanner.h') diff --git a/lib/Plugins/KerneloopsScanner.h b/lib/Plugins/KerneloopsScanner.h index 7352393..a2a4e4b 100644 --- a/lib/Plugins/KerneloopsScanner.h +++ b/lib/Plugins/KerneloopsScanner.h @@ -49,8 +49,7 @@ class CKerneloopsScanner : public CAction /* Plugin interface */ public: CKerneloopsScanner(); - virtual void Run(const std::string& pActionDir, - const std::string& pArgs); + virtual void Run(const char *pActionDir, const char *pArgs); virtual void SetSettings(const map_plugin_settings_t& pSettings); virtual map_plugin_settings_t GetSettings(); }; -- cgit From 57039b590e4411606795893c90f9871e0412ca31 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 6 Nov 2009 18:26:42 +0100 Subject: give Plugin class a map_plugin_settings_t member This simplifies and unifies get/set settings ops Signed-off-by: Denys Vlasenko --- lib/Plugins/KerneloopsScanner.h | 5 ----- 1 file changed, 5 deletions(-) (limited to 'lib/Plugins/KerneloopsScanner.h') diff --git a/lib/Plugins/KerneloopsScanner.h b/lib/Plugins/KerneloopsScanner.h index a2a4e4b..9f00df2 100644 --- a/lib/Plugins/KerneloopsScanner.h +++ b/lib/Plugins/KerneloopsScanner.h @@ -33,9 +33,6 @@ class CKerneloopsScanner : public CAction { - private: - map_plugin_settings_t m_pSettings; - /* For "dumpoops" tool */ public: vector_string_t m_pOopsList; @@ -50,8 +47,6 @@ class CKerneloopsScanner : public CAction public: CKerneloopsScanner(); virtual void Run(const char *pActionDir, const char *pArgs); - virtual void SetSettings(const map_plugin_settings_t& pSettings); - virtual map_plugin_settings_t GetSettings(); }; #endif -- cgit