From 3a7ca2d4447aafc43168c220894a7261ead9e05d Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 20 Nov 2009 14:29:21 +0100 Subject: fix a case where we don't process a crash if uid has no user record Signed-off-by: Denys Vlasenko --- lib/Plugins/CCpp.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'lib/Plugins/CCpp.cpp') diff --git a/lib/Plugins/CCpp.cpp b/lib/Plugins/CCpp.cpp index 83b0e9a..d83d9b5 100644 --- a/lib/Plugins/CCpp.cpp +++ b/lib/Plugins/CCpp.cpp @@ -99,10 +99,11 @@ static pid_t ExecVP(char** pArgs, uid_t uid, string& pOutput) int pipeout[2]; pid_t child; + gid_t gid = uid; struct passwd* pw = getpwuid(uid); - if (!pw) + if (pw) { - throw CABRTException(EXCEP_PLUGIN, string(__func__) + ": cannot get GID for UID."); + gid = pw->pw_gid; } xpipe(pipeout); @@ -124,8 +125,8 @@ static pid_t ExecVP(char** pArgs, uid_t uid, string& pOutput) /* Not a good idea, we won't see any error messages */ /* close(STDERR_FILENO); */ - setgroups(1, &pw->pw_gid); - setregid(pw->pw_gid, pw->pw_gid); + setgroups(1, &gid); + setregid(gid, gid); setreuid(uid, uid); setsid(); -- cgit