From a1330d4f0271e5a22f1764302b18bf5e1665a68e Mon Sep 17 00:00:00 2001 From: Jiri Moskovcak Date: Thu, 8 Oct 2009 12:47:35 +0200 Subject: Bugzilla: removed "+1" feature - this plugin added +1 as comment to existing bugzilla recognized as a duplicate of a bug being reported, this feature only adds "noise" to comments, so adding user to CC seems sufficient --- lib/Plugins/Bugzilla.cpp | 25 +------------------------ 1 file changed, 1 insertion(+), 24 deletions(-) (limited to 'lib/Plugins/Bugzilla.cpp') diff --git a/lib/Plugins/Bugzilla.cpp b/lib/Plugins/Bugzilla.cpp index a3c70f0..48c5eb5 100644 --- a/lib/Plugins/Bugzilla.cpp +++ b/lib/Plugins/Bugzilla.cpp @@ -147,28 +147,6 @@ bool CReporterBugzilla::CheckCCAndReporter(const std::string& pBugId) return false; } -void CReporterBugzilla::AddPlusOneComment(const std::string& pBugId) -{ - xmlrpc_c::paramList paramList; - map_xmlrpc_params_t addCommentParams; - map_xmlrpc_params_t ret; - - addCommentParams["id"] = xmlrpc_c::value_int(atoi(pBugId.c_str())); - addCommentParams["comment"] = xmlrpc_c::value_string("+1"); - - paramList.add(xmlrpc_c::value_struct(addCommentParams)); - xmlrpc_c::rpcPtr rpc(new xmlrpc_c::rpc("Bug.add_comment", paramList)); - try - { - rpc->call(m_pXmlrpcClient, m_pCarriageParm); - } - catch (std::exception& e) - { - throw CABRTException(EXCEP_PLUGIN, std::string("CReporterBugzilla::AddPlusOneComment(): ") + e.what()); - } - ret = xmlrpc_c::value_struct(rpc->getResult()); -} - void CReporterBugzilla::AddPlusOneCC(const std::string& pBugId) { xmlrpc_c::paramList paramList; @@ -424,10 +402,9 @@ std::string CReporterBugzilla::Report(const map_crash_report_t& pCrashReport, co update_client(_("Logging into bugzilla...")); Login(); m_bLoggedIn = true; - update_client(_("Check CC and add coment +1...")); + update_client(_("Checking CC...")); if (!CheckCCAndReporter(bugId) && m_bLoggedIn) { - AddPlusOneComment(bugId); AddPlusOneCC(bugId); } DeleteXMLRPCClient(); -- cgit