From ca4bb9b535f817b5b73c3c77dc884abda32564dc Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Thu, 6 Aug 2009 14:48:10 +0200 Subject: style cleanups in preparation for PluginManager move Signed-off-by: Denys Vlasenko --- lib/MiddleWare/PluginManager.cpp | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) (limited to 'lib/MiddleWare/PluginManager.cpp') diff --git a/lib/MiddleWare/PluginManager.cpp b/lib/MiddleWare/PluginManager.cpp index 81207f9..7224c4e 100644 --- a/lib/MiddleWare/PluginManager.cpp +++ b/lib/MiddleWare/PluginManager.cpp @@ -28,9 +28,14 @@ #include /** - * Text reprezentation of plugin types. + * Text representation of plugin types. */ -static const char* const plugin_type_str_t[] = { "Analyzer", "Action", "Reporter", "Database" }; +static const char* const plugin_type_str_t[] = { + "Analyzer", + "Action", + "Reporter", + "Database" +}; CPluginManager::CPluginManager( @@ -52,10 +57,11 @@ void CPluginManager::LoadPlugins() { while ((dent = readdir(dir)) != NULL) { + // FIXME: need to handle DT_UNKNOWN too if (dent->d_type == DT_REG) { std::string name = dent->d_name; - std::string extension = name.substr(name.length()-sizeof(PLUGINS_LIB_EXTENSION)+1); + std::string extension = name.substr(name.length() - sizeof(PLUGINS_LIB_EXTENSION) + 1); if (extension == PLUGINS_LIB_EXTENSION) { name.erase(0, sizeof(PLUGINS_LIB_PREFIX) - 1); @@ -71,11 +77,11 @@ void CPluginManager::LoadPlugins() void CPluginManager::UnLoadPlugins() { map_abrt_plugins_t::iterator it_p; - while ((it_p = m_mapABRTPlugins.begin()) != m_mapABRTPlugins.end()) - { - std::string pluginName = it_p->first; - UnLoadPlugin(pluginName); - } + while ((it_p = m_mapABRTPlugins.begin()) != m_mapABRTPlugins.end()) + { + std::string pluginName = it_p->first; + UnLoadPlugin(pluginName); + } } void CPluginManager::LoadPlugin(const std::string& pName) @@ -118,7 +124,6 @@ void CPluginManager::UnLoadPlugin(const std::string& pName) } } - void CPluginManager::RegisterPlugin(const std::string& pName) { if (m_mapABRTPlugins.find(pName) != m_mapABRTPlugins.end()) @@ -252,7 +257,6 @@ vector_map_string_string_t CPluginManager::GetPluginsInfo() plugin_info["WWW"] = it_abrt_plugin->second->GetWWW(); plugin_info["GTKBuilder"] = it_abrt_plugin->second->GetGTKBuilder(); ret.push_back(plugin_info); - } return ret; } -- cgit