summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Move PLUGIN_INFOs to .cpp files: same object must never be defined twiceDenys Vlasenko2009-07-3127-143/+136
| | | | | | | | and if structure is defined in a .h file, that happens. Since this particular structure has non-trivial destructor, it was running twice and resulted in double-free. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* dumpoops: a new tool, requested by AntonDenys Vlasenko2009-07-312-1/+60
| | | | | | Now it segfaults, next commit will fix it Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* KerneloopsReporter: plug a leak in writefunctionDenys Vlasenko2009-07-3110-33/+75
| | | | | | Also some preparatory cleanups for future dumpoops patch are included Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* New iface for getting plugins' infosZdenek Prikryl2009-07-316-23/+42
|
* updated urlZdenek Prikryl2009-07-311-1/+1
|
* added new option do bugzilla plugin.Zdenek Prikryl2009-07-314-18/+71
| | | | NoSSLVerify enables/disables certificate verification.
* rename auto variables to not have m_ prefixes - they are not members!Denys Vlasenko2009-07-311-19/+16
| | | | | | no logic changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* bug fixes in kerneloops scannerDenys Vlasenko2009-07-314-70/+60
| | | | | | | | | | | | | | | | | | | | | CKerneloopsScanner::Run - scan syslog file first, then dmesg (was other way around) CKerneloopsScanner::SaveOopsToDebug - cast time_t and size_t to long when we feed them to snprintf CKerneloopsScanner::ScanSysLogFile - do not seek to negative offsets, POSIX does not allow that CSysLog::QueueOops - plug memory leak Also used some abrtlib functions where appropriate, use open instead of fopen where appropriate, do not check error in time() - it never fails, move around bits of code in CKerneloopsScanner to make it easier in future to create a tool for parsing arbitrary files for oopses. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* using more x-functionsDenys Vlasenko2009-07-313-29/+21
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* style fixes, no code changesDenys Vlasenko2009-07-311-40/+36
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* add utility functionsDenys Vlasenko2009-07-307-24/+556
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Logging machinery provided by this patch consists of several functions: +extern void error_msg(const char *s, ...) __attribute__ ((format (printf, 1, 2))); +extern void error_msg_and_die(const char *s, ...) __attribute__ ((noreturn, format (printf, 1, 2))); +extern void perror_msg(const char *s, ...) __attribute__ ((format (printf, 1, 2))); +extern void perror_msg_and_die(const char *s, ...) __attribute__ ((noreturn, format (printf, 1, 2))); +/* This is a macro since it collides with log() from math.h */ +#undef log +#define log(...) error_msg(__VA_ARGS__) They are taking printf-style format strings. perror_msg_xxx functions append an errno string after the message: "xxx xxx xxx: No such file or directory" if errno is != 0. xxx_and_die functions do not return. All functions also ensure that the message ends with "\n", meaning that you do not need to add it into the message, but if you do, an extra "\n" will not be added. All functions ensure that the string is written in a single write() call, thus if two processes output to the same terminal or file, messages don't get intermingled. Ordinarily, messages go to the stderr. By setting global variable "logmode" to LOGMODE_SYSLOG or LOGMODE_NONE, they can be sent to syslog or be suppressed. Standard setting is LOGMODE_STDIO. LOGMODE_STDIO + LOGMODE_SYSLOG works too. Usually it is set by main() as needed, and then you can fearlessly use [p]error_msg[_and_die]() and be sure that message goes to the right place. +enum { + LOGMODE_NONE = 0, + LOGMODE_STDIO = (1 << 0), + LOGMODE_SYSLOG = (1 << 1), + LOGMODE_BOTH = LOGMODE_SYSLOG + LOGMODE_STDIO, +}; +extern int logmode; Exit code of xxx_and_die variants is controlled by the global variable +extern int xfunc_error_retval; By default it is = 1. Logging infrastructure uses a few other functions, which I find useful on their own, and since I discussed them with Zdenek and he thinks that they may be useful too, they are included in the patch also. The first group is "malloc or die" group: +void* malloc_or_warn(size_t size); +void* xmalloc(size_t size); +void* xrealloc(void *ptr, size_t size); +void* xzalloc(size_t size); +char* xstrdup(const char *s); +char* xstrndup(const char *s, int n); They are basically versions of malloc etc which exit on failure. The next group are simple I/O wrappers: +extern ssize_t safe_read(int fd, void *buf, size_t count); +extern ssize_t full_read(int fd, void *buf, size_t count); +extern void xread(int fd, void *buf, size_t count); +extern ssize_t safe_write(int fd, const void *buf, size_t count); +extern ssize_t full_write(int fd, const void *buf, size_t count); safe_xxx deal with the fact that read and write operations may "fail" with EINTR and in many cases we want to just repeat the operation. full_xxx deal with the fact that read and write are not guaranteed to read or write exact amount, they may to transfer less bytes. In this case we need to loop. The next group are the "x functions": +extern void xwrite(int fd, const void *buf, size_t count); +extern void xwrite_str(int fd, const char *str); +void xpipe(int filedes[2]); +void xdup2(int from, int to); +off_t xlseek(int fd, off_t offset, int whence); +void xsetenv(const char *key, const char *value); +int xsocket(int domain, int type, int protocol); +void xbind(int sockfd, struct sockaddr *my_addr, socklen_t addrlen); +void xlisten(int s, int backlog); +ssize_t xsendto(int s, const void *buf, size_t len, const struct sockaddr *to, socklen_t tolen); +void xstat(const char *name, struct stat *stat_buf); +void xmove_fd(int from, int to); +char* xasprintf(const char *format, ...); They are similar to xmalloc in a sense that they exit on the failure. Most of them closely resemble corresponding libc functions. xmove_fd() is a wrapper for typical idiom "if (fd1!=fd2) dup2(fd1,fd2)", with error checking on dup2 failure added. xasprintf() is a "strcat on steroids". It's a printf-like function which returns a malloced string. In my experience, it is surprisingly useful: it makes complex concatenations easy in C. All these functions are declared in a new header, inc/abrtlib.h. It also contains a list of #includes: +#include <ctype.h> +#include <dirent.h> +#include <errno.h> +#include <fcntl.h> +#include <inttypes.h> +#include <setjmp.h> +#include <signal.h> +#include <stdio.h> +#include <stdlib.h> +#include <stdarg.h> +#include <stddef.h> +#include <string.h> +#include <sys/poll.h> +#include <sys/mman.h> +#include <sys/socket.h> +#include <sys/stat.h> +#include <sys/time.h> +#include <sys/types.h> +#include <sys/wait.h> +#include <termios.h> +#include <time.h> +#include <unistd.h> +/* Try to pull in PATH_MAX */ +#include <limits.h> +#include <sys/param.h> +#ifndef PATH_MAX +# define PATH_MAX 256 +#endif +#include <pwd.h> +#include <grp.h> The rationale to do so is that these headers are pretty standard, and by having them included in this one file, we won't need to add #includes into many .c[pp] files later. The slowdown from gcc parsing these headers even if they are not needed is not worth spending time on optimizing out. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* two trivial fixlets in lib/Plugins/CCpp.cppDenys Vlasenko2009-07-291-4/+3
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* GUI: Added detection whether daemon is running (gui disables itself)Jiri Moskovcak2009-07-282-29/+48
|
* Applet: Added detection whether daemon is runningJiri Moskovcak2009-07-283-10/+70
|
* CommLayer: Added DaemonWatcher to watch if daemon is runningJiri Moskovcak2009-07-281-0/+88
|
* Be more paranoid about /proc/.../core_patternDenys Vlasenko2009-07-252-0/+21
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* fixing whitespace damage, no code changesDenys Vlasenko2009-07-252-3/+3
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* fixed exception throwingZdenek Prikryl2009-07-241-2/+1
|
* Merge branch 'master' of git://git.fedorahosted.org/abrtZdenek Prikryl2009-07-244-55/+26
|\
| * remove superfluous copying in ExecVP paramsDenys Vlasenko2009-07-241-3/+2
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| * remove GetGIDFromUID (two copies): getpwuid does the sameDenys Vlasenko2009-07-244-47/+12
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| * simplify CAnalyzerCCpp::CreateHashDenys Vlasenko2009-07-241-5/+12
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | plugin can report to different bugzillas in different reportsZdenek Prikryl2009-07-241-9/+18
| |
* | proper deinit of libmagicZdenek Prikryl2009-07-241-2/+2
| |
* | simple fixZdenek Prikryl2009-07-241-1/+1
| |
* | Added first part of gui support in reportingZdenek Prikryl2009-07-2422-23/+90
| |
* | Added gui desriptions for reportersZdenek Prikryl2009-07-244-0/+574
|/
* style fix by popular (Zdenek's) demandDenys Vlasenko2009-07-231-6/+3
| | | | | | | | | | | | | | | Zdenek said: Ahother thing: commit "CCpp.cpp: fix handling of pipes when we fork children". You added piece code with while(1) and then there is a break inside the loop. Personally, I don't like infinite loops :-). There can be something like: ... int r; while ((r = read(pipeout[0], buff, sizeof(buff) - 1) > 0) { Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* typo fixesDenys Vlasenko2009-07-232-29/+28
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* added forgotten "throw" keywordsDenys Vlasenko2009-07-222-4/+4
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2009-07-221-122/+137
|\
| * CCpp.cpp: fix handling of pipes when we fork childrenDenys Vlasenko2009-07-221-122/+137
| | | | | | | | | | | | Also simplified read loops Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | SPEC: merge gui with applet, create virtual abrt-desktop for easy installJiri Moskovcak2009-07-221-15/+16
|/
* Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2009-07-222-32/+35
|\
| * fix several resource leaks on error pathsDenys Vlasenko2009-07-222-32/+35
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* | PyHook: removed forgotten debug outputJiri Moskovcak2009-07-221-1/+0
| |
* | Applet: more fixes to work if configure was run with non-default prefixJiri Moskovcak2009-07-223-2/+7
| |
* | Utils: small fixJiri Moskovcak2009-07-221-1/+1
| |
* | Daemon: threading fixesJiri Moskovcak2009-07-222-16/+32
| |
* | CommLayer: added new signal "Warning"Jiri Moskovcak2009-07-222-0/+9
| |
* | GUI: single instance pattern rhbz#512390, trac#60Jiri Moskovcak2009-07-224-12/+83
|/ | | | - improved status window
* Fix build system for the case where configure was run with non-default prefixDenys Vlasenko2009-07-204-5/+15
| | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
* GUI: Fixed reporter dialog rhbz#497600Jiri Moskovcak2009-07-201-18/+28
|
* Merge branch 'master' of ssh://git.fedorahosted.org/git/abrtJiri Moskovcak2009-07-205-63/+159
|\
| * On exit, take care to emit consistent exit status.Denys Vlasenko2009-07-171-5/+13
| | | | | | | | | | | | If we were Ctrl-C'ed, then we should exit by killing ourself, not exit(N). Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| * rework unsafe handling of SIGINT/SIGTERMDenys Vlasenko2009-07-173-12/+69
| | | | | | | | | | | | | | | | | | | | Signals are asynchronous. It is unsafe to perform such complex operations in a signal handler. I changed signal handler to just set a flag, and added an event source which returns an event when this variable is set. The action is to stop event loop. Execution then falls through to program exit. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| * prevent leaking buf in some casesDenys Vlasenko2009-07-171-4/+12
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| * simplify CCrashWatcher::CreatePidFileDenys Vlasenko2009-07-171-23/+19
| | | | | | | | Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| * Restore /proc/sys/kernel/core_pattern on error exit.Denys Vlasenko2009-07-153-31/+58
| | | | | | | | | | | | The bug was observed when dbus-abrt.conf is missing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| * test commitroot2009-07-151-1/+1
| | | | | | | | Signed-off-by: root <root@dhcp-lab-117.englab.brq.redhat.com>
generated by cgit (git 2.34.1) at 2025-10-01 05:22:08 +0000