| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
|
|
| |
30k smaller code.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Example (strace):
10053 17:18:58.384259 close(0) = 0
10053 17:18:58.384293 open("/dev/null", O_RDWR) = 0
child is created:
10053 17:18:58.384354 clone(child_stack=0, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7f50eea1c880) = 10054
parent sleeps, child initializes:
10053 17:18:58.384678 nanosleep({0, 100000000}, <unfinished ...>
10054 17:18:58.384751 setsid() = 10054
10054 17:18:58.384794 close(1) = 0
10054 17:18:58.384828 close(2) = 0
10054 17:18:58.384870 dup(0) = 1
10054 17:18:58.384901 dup(0) = 2
10054 17:18:58.385099 open("/usr/app/abrt-TEST/var/etc/abrt/abrt.conf", O_RDONLY) = 3
...
10054 17:18:58.449108 inotify_init() = 4
10054 17:18:58.449148 inotify_add_watch(4, "/usr/app/abrt-TEST/var/cache/abrt", IN_CREATE) = 1
10054 17:18:58.449228 fstat(4, {st_mode=S_IFDIR|0600, st_size=0, ...}) = 0
10054 17:18:58.449288 fcntl(4, F_GETFL) = 0 (flags O_RDONLY)
child: initialization is done, it signals parent:
10054 17:18:58.449346 getppid() = 10053
10054 17:18:58.449380 kill(10053, SIGTERM) = 0
10054 17:18:58.449427 write(1, "Debug: Running...\n"..., 18 <unfinished ...>
10053 17:18:58.449447 <... nanosleep resumed> 0) = ? ERESTART_RESTARTBLOCK (To be restarted)
10054 17:18:58.449470 <... write resumed> ) = 18
10054 17:18:58.449494 open("/usr/app/abrt-TEST/var/run/abrt.lock", O_RDWR|O_CREAT, 0640 <unfinished ...>
10053 17:18:58.449517 --- SIGTERM (Terminated) @ 0 (0) ---
10054 17:18:58.449565 <... open resumed> ) = 5
10053 17:18:58.449583 rt_sigreturn(0xf <unfinished ...>
10054 17:18:58.449607 fcntl(5, F_SETLK, {type=F_WRLCK, whence=SEEK_CUR, start=0, len=0} <unfinished ...>
sleep(100ms) is interrupted:
10053 17:18:58.449629 <... rt_sigreturn resumed> ) = -1 EINTR (Interrupted system call)
10054 17:18:58.449664 <... fcntl resumed> ) = 0
10054 17:18:58.449688 unlink("/usr/app/abrt-TEST/var/run/abrt.pid" <unfinished ...>
parent exits 0 because it got TERM which means child is ok:
10053 17:18:58.449713 exit_group(0) = ?
...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|\ |
|
| |\ |
|
| |\ \
| | | |
| | | |
| | | |
| | | | |
Conflicts:
lib/CommLayer/DBusServerProxy.h
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
behaviour.
|
| |_|/
|/| |
| | |
| | | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |/
|/| |
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| |
| |
| | |
abrt daemon is SEGVing without this
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| |
| |
| | |
This reduces code size by 14k.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| | |
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| | |
|
| |
| |
| |
| |
| |
| | |
some cleanups and abrtlib work crept in too...
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|/
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|\ |
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|/ |
|
| |
|
| |
|
| |
|
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
|
|
|
| |
Also, running abrt-gui via popen is definiely wrong. We were leaking a FILE!
fixed now.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was struggling to read the code where classes have member functions
with no apparent reasons to be such: they do not use any members
of the class.
Having them members of the class have only disadvantages:
they need to be declared in the class (thus you need to touch TWO files),
they cannot be shared among different classes,
they look confusing at callsites - the code falsely suggests
that function uses or alters object's state,
they also are a bit less efficient.
I was hesitating to do so before, but now I was told that
there is a plan to gradually move to C implementation...
then this change makes it a bit closer to that.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
|
|
|
|
| |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| | |
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
|
|/ |
|