summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* spice: add proxy configuration to connection fileMarc-André Lureau2013-01-293-1/+33
|
* Remove unused labelChristophe Fergeau2013-01-241-1/+0
| | | | It's no longer used after aecd80ec7
* Remove unused variableChristophe Fergeau2013-01-241-1/+0
| | | | 'window' is no longer used after 412bcf6f.
* Fix warning when compiling without spice-gtk supportChristophe Fergeau2013-01-241-0/+1
| | | | | | | | | | | When remote-viewer is compiled without spice-gtk support, spice-session.h will not get included in remote-viewer.c, causing these warnings: remote-viewer.c: In function 'remote_viewer_start': remote-viewer.c:693:9: warning: implicit declaration of function 'virt_viewer_session_set_file' [-Wimplicit-function-declaration] remote-viewer.c:693:9: warning: nested extern declaration of 'virt_viewer_session_set_file' [-Wnested-externs]
* virt-viewer-display-spice: Get monitor under our windowHans de Goede2013-01-221-1/+2
| | | | | | | | | | | When getting monitor info for going fullscreen, Get the monitor under *our* window rather then under the root-window. Noticed this not working properly when testing the monitor coordinates stuff, but this should also help people seeing problems when using non equally sized monitors. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* vnc: add connection by fileMarc-André Lureau2013-01-185-22/+52
| | | | | | | | | | | | | | | Learn to connect to a VNC server with the connection details file, ex: [virt-viewer] type=vnc host=localhost port=2356 password=foobar v2: - add username/password support https://bugzilla.redhat.com/show_bug.cgi?id=843410
* file: add username supportMarc-André Lureau2013-01-182-0/+27
|
* Make hotkey configuration functionality available from the cmdline (v2)Hans de Goede2012-12-212-0/+8
| | | | | | | Changes in v2: -Add --hotkeys documentation to the man-pages Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Add a virt_viewer_app_set_hotkeys() helper functionHans de Goede2012-12-213-40/+55
| | | | Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Improve check for overridden grab key combinationChristophe Fergeau2012-12-202-4/+5
| | | | | | | | | remote-viewer can either use the default grab/ungrab handled by spice-gtk, or override it and use the standard gtk+ accelerator mechanism. However, the code currently assumes that if any accelerator is set in remote-viewer, then the grab key has been overridden. This commit makes sure the grab key is actually overridden before assuming so.
* Don't leak SpiceGrabSequence in enable_accel_changedChristophe Fergeau2012-12-201-2/+3
|
* Improve hotkeys controller behaviourChristophe Fergeau2012-12-201-0/+5
| | | | | | | Disable default accelerators when setting bindings from the controller in case the controller does not override them all. This ensures we don't inherit from the bindings set in VirtViewerApp::constructor if the controller doesn't set any bindings for a given action.
* Use monitor geometry, not screen sizeMarc-André Lureau2012-12-071-2/+6
| | | | | | | | | | | | | In a recent commit, 3bb6f5ec805ecfe78eba6d4d98e3ffcab195273a, I introduced a regression: going fullscreen would no longer match client and guest resolution correctly. A GdkScreen is not necessarily the physical screen monitor size. Lookup the physical monitor size using gdk_screen_get_monitor_geometry(). Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=881020
* session-spice: Cast CA string to gunit8 pointerMichal Privoznik2012-12-051-1/+1
| | | | | | | SpiceSession has 'ca' property which is type of GByteArray*. However, when we read the property from file, we read it as string. For conversion g_byte_array_new_take() is used which takes given pointer as guint8* so we need to do the cast.
* Sanitize syntax-checkMichal Privoznik2012-12-051-0/+1
| | | | | | | | make syntax-check is producing some errors about empty line at EOF and missing #include <config.h> in src/virt-viewer-file.c * src/virt-viewer-file.c: add #include <config.h> * data/virt-viewer-debug.nsis.in: remove empty line at EOF
* Make .desktop file comply with specDoug Goldstein2012-12-051-2/+2
| | | | | | | The .desktop file did not comply with the Desktop Entry spec as checked with desktop-file-validate. Boolean keys are defined as taking only 'true' or 'false', the entry Terminal had False. MimeType is a string list and therefore must be terminated with a ;
* remote-viewer: learn to connect from fileMarc-André Lureau2012-11-271-2/+22
| | | | | v2: - move some variables to inner-block as requested by reviewer
* spice: learn to connect from fileMarc-André Lureau2012-11-271-1/+90
|
* Add VirtViewerSession:file propertyMarc-André Lureau2012-11-273-0/+43
| | | | | | | | | | If VirtViewerSession:file is set, it should be used to define the connection parameters. Also correct the mime type used in this case. The mime type is needed to identify the kind of resources we are adding to the recent list. The recent list can then be filtered and various application handling that type may attempt to access that resource.
* Add VirtViewerFileMarc-André Lureau2012-11-273-0/+900
| | | | | | | v2: - use !! for boolean values setter - switch from bytearray/base64 to plain string for CA (PEM) - add file format comment
* Move spice_hotkey_to_gtk_accelerator() to utilMarc-André Lureau2012-11-273-114/+116
| | | | | To be compatible with RHEVM, VirtViewerFile hotkey format will use the Spice Controller format.
* recent: get mime type from sessionMarc-André Lureau2012-11-271-5/+4
| | | | | Do not use spice mime type for all kind of sessions, but depending on what is actually being used.
* session: add virt_viewer_session_mime_type()Marc-André Lureau2012-11-274-0/+27
|
* display: only un-constrain display size once it is mappedMarc-André Lureau2012-11-271-1/+2
| | | | | | Wait until the widget is actually on screen before removing its size constrain. This solves 50x50 window secondary window size when connecting to a multi-monitor spice guest.
* debug-helper: include <config.h>Michal Privoznik2012-11-211-0/+1
|
* spice: the session is connected when main channel openedMarc-André Lureau2012-11-211-2/+1
| | | | | | | The previous change in 399aae55aa384bf91dff0fc770497c0d5f935fa9 rely on correct session-connected signal. However, the spice backend is emiting it too early, when the main channel is created, where it should wait until it is connected instead.
* "Unable to connect to the graphic server" error on guest shutdownMarc-André Lureau2012-11-201-4/+6
| | | | | | | | | | In virt_viewer_app_activate(), priv->connected is set to FALSE when the connect/active is successfull. However, we rely on it to know whether the virt_viewer_app_disconnected() is an error, so only set it to FALSE when connection failed. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=875697
* Make sure png screenshots have a .png extensionsChristophe Fergeau2012-11-151-2/+10
| | | | | | When falling back to saving to .png, the filename might not end with .png. This commit appends the .png extension to the screenshot filename if it's missing.
* Allow to save to other formats than pngChristophe Fergeau2012-11-151-2/+53
| | | | | | Currently, the screenshots can only be saved to png. This commit checks if the file extension is a known one, and will save to this format if it is. Otherwise it will fallback to saving to png.
* Set a default dir/name for screenshotsChristophe Fergeau2012-11-151-3/+5
| | | | | | | It makes sense for the screenshots to be saved in ~/Images, especially as otherwise the filechooser will display 'recent documents' to which we cannot save. This commit also sets the default screenshot name to 'Screenshot'.
* Don't SIGSEGV if no transport is used.Michal Privoznik2012-11-141-1/+1
| | | | | | | | One of previous commits (74b1b62510d939) allowed us to connect to localhost directly if ssh transport was used. However, if there's not transport, we SIGSEGV'ed as g_str_equal doesn't like NULL as one of arguments. Change this to g_strcmp0 which does the same service but is more friendly to NULL arguments.
* Reconnect to libvirtd after connection breaksMichal Privoznik2012-11-132-8/+55
| | | | | | | | Currently, if user wants to reconnect to a domain he can use '-r' cmd line argument. This makes virt-viewer listen to domain events. However, if connection to libvirtd breaks somehow, we will receive no longer any event. Hence we must reconnect to the libvirt.
* Connect to localhost for display when transport is sshDave Allan2012-11-081-3/+11
| | | | | | | | | | | When connecting to a VM that does not have a 'listen' tag in its graphcs element, we have to guess where to try to connect to the VM's display. The current default is the host specified in the connection URI which is correct for most transports, however, the SSH transport makes the display connection from the remote end, so in that case, attempt to connect to localhost. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Fix jenkins build failureMarc-André Lureau2012-10-231-0/+1
| | | | | | | | | virt-viewer-util.c: In function 'virt_viewer_util_init': virt-viewer-util.c:289: warning: implicit declaration of function 'setlocale' virt-viewer-util.c:289: warning: nested extern declaration of 'setlocale' virt-viewer-util.c:289: error: 'LC_ALL' undeclared (first use in this function) virt-viewer-util.c:289: error: (Each undeclared identifier is reported only once virt-viewer-util.c:289: error: for each function it appears in.)
* Use a mutex to check if VirtViewer runningMarc-André Lureau2012-10-231-0/+9
| | | | | | | We need to warn user that installer can't proceed if there is already a running instance of VirtViewer or of the installer. https://bugzilla.redhat.com/show_bug.cgi?id=864033
* Use a common early init() functionMarc-André Lureau2012-10-234-32/+36
| | | | | There is a number of things both virt-viewer and remote-viewer need to do early during execution. Do it only in one place.
* windows: add debug-helperMarc-André Lureau2012-10-232-0/+75
| | | | | | | | | | | | This is a simple program that will set some debug variable, and run gdb and wait until it finished. This makes it possible to debug "remote-viewer --spice-controller" easily, by setting the necessary variables and keeping the parent process running (the activex whatches its death) To use it, replace the HKCU "Software\spice-space.org\spicex\client" value "$INSTDIR\bin\remote-viewer.exe --spice-controller" with "$INSTDIR\bin\debug-helper.exe remote-viewer.exe --spice-controller".
* win32: there is no CONERR$, only CONOUT$Marc-André Lureau2012-10-232-2/+2
|
* spice: only autoresize once with screen size in fullscreenMarc-André Lureau2012-10-183-2/+38
| | | | | | | | | | | | It's currently not possible to configure guest with higher resolution than native, as it will switch back to native, since the gtk widget allocation will always end up being the size of the screen. We special-case fullscreen mode, and only resize when entering fullscreen. Furthermore, it avoids sending extra unnecessary resize events to the guest whenever gtk+ call size allocate in various stages, with different values. https://bugzilla.redhat.com/show_bug.cgi?id=864929
* spice: avoid rounding issues when scaling up displayMarc-André Lureau2012-10-172-4/+5
| | | | | | | | | | | | Fix some unwanted guest resize due to rounding issues (at least when scaling up) We may want to save the original remote desktop size, instead of always checking widget requisition. That way zooming shouldn't resize guest at all, but it seems tricky to handle that special case vs user window resize that should trigger guest resize. https://bugzilla.redhat.com/show_bug.cgi?id=856678
* Do not resize window to minimum when toggling auto-resizeMarc-André Lureau2012-10-161-6/+7
| | | | | | | | | | | | | | | The virt_viewer_display_idle() will queue a resize event that will result in display size requisition of 50x50. If we later resize the window to 1x1 in virt_viewer_window_resize() we end up with a tiny window. It is legitimate not to force that 1x1 window resize when toggling the option. After the rest of the logic in virt_viewer_window_resize(), if the remote desktop ends up being resize, that will trigger another virt_viewer_set_desktop_size() and finally change the window size appropriately. https://bugzilla.redhat.com/show_bug.cgi?id=856610
* Fix check for IPv6 any addressDaniel P. Berrange2012-10-101-3/+22
| | | | | | | | | | The string '::' is just one of many possible ways to express the IPv6 "any" address. Others include '::0', '0:0:0:0:0:0:0:0', '0::0' and more. Instead of trying to do strcmp, actually try parsing the address with GInetAddress and then simply use an accessor to check what type it is Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Allow user to set a window title for remote-viewerDaniel P. Berrange2012-10-095-8/+31
| | | | | | | | | Currently the remote viewer windows get the URI as their title. Provide a --title STRING arg to remote-viewer to let the user override the title with something more meaningful to them. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Don't free SPICE ticket twiceChristophe Fergeau2012-10-011-1/+0
| | | | | | | Commit 2201a5a was supposed to free a SPICE ticket leak, but it's actually introducing a double-free as the SPICE ticket is unconditionally freed at the end of virt_viewer_session_spice_main_channel_event
* Append \n to message in virt_viewer_app_traceChristophe Fergeau2012-09-182-12/+13
| | | | | | | Callers manually add a trailing \n when they call virt_viewer_app_trace, but it's sometimes forgotten, leading to rhbz#822794. This commit removes the \n from all callers (it was missing in a few of them) and adds it in virt_viewer_app_trace.
* Use a more specific regex to fix enum include pathsDaniel P. Berrange2012-09-141-1/+1
| | | | | | Simply doing a search replace on $(srcdir) doesn't work very well in non-VPATH builds. Use a more specific regex that won't generate false matches
* Look in builddir for icons & strip build dir prefix from enum file includsDaniel P. Berrange2012-09-141-2/+4
|
* Document -f=auto-conf in remote-viewer --helpChristophe Fergeau2012-08-131-1/+1
| | | | | | virt-viewer does not support -f=auto-conf so this does not change the option there. Fixes rhbz#718001
* Use real binary name in help messageChristophe Fergeau2012-08-102-7/+15
| | | | | | | | | | | | Now that we have 2 distinct binaries, remote-viewer and virt-viewer, 'PACKAGE' can no longer be used in error messages as the name of the binary. This causes a small inconsistency when running 'remote-viewer --foobar' as the error message would be: 'Unknown option --foobar Run 'virt-viewer --help' to see a full list of available command line options' This commit makes sure we use argv[0] for this message. Fixes rhbz#814150
* Show status page by default if display not readyMarc-André Lureau2012-07-231-1/+5
| | | | Switch back to status page if display is not ready.