summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* win32: process message queue in debug-helperMarc-André Lureau2013-02-111-2/+14
| | | | | | | | | Process messages while waiting for pi.hProcess. Avoid the spice-x from hanging in WaitForInputIdle(), although the client itself might not be ready, not even started... https://bugzilla.redhat.com/show_bug.cgi?id=903190
* virtviewer-window: Make sure fullscreen window stays on the same monitorHans de Goede2013-02-111-1/+14
| | | | | | | | | | | | | Sometimes the guest may shortly disable and then re-enable a monitor while in fullscreen mode, this happens for example when changing display resolution through gnome-display-properties inside the guest. This causes the client window-manager to remap the window, and this can cause it to end up on a different monitor. This patch fixes this by remembering the position the window is places at when going fullcreen and moving it there again when its gets (re-)shown. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Fix "Do not ask me again" checkbox settings savingMarc-André Lureau2013-02-071-17/+22
| | | | | | | | | | | | | | | | | Based on bug report by Hans: The code block for saving was below this check: if (priv->session) { virt_viewer_session_close(VIRT_VIEWER_SESSION(priv->session)); if (priv->connected) { priv->quiting = TRUE; return; } } Which means it never executes when quiting virt-viewer while conneced, causing the "Do not ask me again" checkbox settings to not be saved.
* usbredir: Fix usbredir menu always being grayed out on monitor 2+Hans de Goede2013-02-061-0/+4
| | | | Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* virt-viewer-display-spice: Pass proper x and y coordinates in windowed modeHans de Goede2013-02-061-0/+7
| | | | | | | | | | | This stops monitor order from the guest from being re-arranged in multi- monitor setups when switching between fullscreen and windowed mode. Note this relies on spice-gtk's auto monitor alignment code, which currently does not properly handle setups where there is more then 1 row of monitors, ie 2x1 - 5x1 will work fine, but 2x2 will not. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* virt-viewer-display-spice: Use real monitor coordinates in fullscreenHans de Goede2013-02-061-1/+8
| | | | | | | | | Now that we pass the real monitor coordinates, tell spice-gtk to use them, rather then to use the passed coordinates as input for its automatic monitor alignment. This fixes ie monitors in a 2x2 grid, showing up as a 4x1 configuration in the guest. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* virt-viewer-display-spice: Pass real monitor coordinates in fullscreenHans de Goede2013-02-061-1/+4
| | | | | | Rather then always passing +0+0 Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* g_{message,warning}: Use printf styleMichal Privoznik2013-02-042-2/+2
| | | | | | The g_message() and g_warning functions expect printf style of arguments. That is, whenever we want to print a string, it has to be preceded with "%s" format.
* remote-viewer: controller sets spice session proxyMarc-André Lureau2013-01-311-1/+2
| | | | | Trivial change since spice-gtk now has proxy session property and controller message, just forward it.
* Add a "Do not ask me again" checkbox when closing appMarc-André Lureau2013-01-311-2/+62
|
* Always ask user about closing sessionMarc-André Lureau2013-01-311-11/+2
| | | | | | | | Currently, virt-viewer doesn't ask for user confirmation when closing a single monitor session. Always ask before closing, as requested by user. https://bugzilla.redhat.com/show_bug.cgi?id=803912
* spice: add proxy configuration to connection fileMarc-André Lureau2013-01-293-1/+33
|
* Remove unused labelChristophe Fergeau2013-01-241-1/+0
| | | | It's no longer used after aecd80ec7
* Remove unused variableChristophe Fergeau2013-01-241-1/+0
| | | | 'window' is no longer used after 412bcf6f.
* Fix warning when compiling without spice-gtk supportChristophe Fergeau2013-01-241-0/+1
| | | | | | | | | | | When remote-viewer is compiled without spice-gtk support, spice-session.h will not get included in remote-viewer.c, causing these warnings: remote-viewer.c: In function 'remote_viewer_start': remote-viewer.c:693:9: warning: implicit declaration of function 'virt_viewer_session_set_file' [-Wimplicit-function-declaration] remote-viewer.c:693:9: warning: nested extern declaration of 'virt_viewer_session_set_file' [-Wnested-externs]
* virt-viewer-display-spice: Get monitor under our windowHans de Goede2013-01-221-1/+2
| | | | | | | | | | | When getting monitor info for going fullscreen, Get the monitor under *our* window rather then under the root-window. Noticed this not working properly when testing the monitor coordinates stuff, but this should also help people seeing problems when using non equally sized monitors. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* vnc: add connection by fileMarc-André Lureau2013-01-185-22/+52
| | | | | | | | | | | | | | | Learn to connect to a VNC server with the connection details file, ex: [virt-viewer] type=vnc host=localhost port=2356 password=foobar v2: - add username/password support https://bugzilla.redhat.com/show_bug.cgi?id=843410
* file: add username supportMarc-André Lureau2013-01-182-0/+27
|
* Make hotkey configuration functionality available from the cmdline (v2)Hans de Goede2012-12-212-0/+8
| | | | | | | Changes in v2: -Add --hotkeys documentation to the man-pages Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Add a virt_viewer_app_set_hotkeys() helper functionHans de Goede2012-12-213-40/+55
| | | | Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Improve check for overridden grab key combinationChristophe Fergeau2012-12-202-4/+5
| | | | | | | | | remote-viewer can either use the default grab/ungrab handled by spice-gtk, or override it and use the standard gtk+ accelerator mechanism. However, the code currently assumes that if any accelerator is set in remote-viewer, then the grab key has been overridden. This commit makes sure the grab key is actually overridden before assuming so.
* Don't leak SpiceGrabSequence in enable_accel_changedChristophe Fergeau2012-12-201-2/+3
|
* Improve hotkeys controller behaviourChristophe Fergeau2012-12-201-0/+5
| | | | | | | Disable default accelerators when setting bindings from the controller in case the controller does not override them all. This ensures we don't inherit from the bindings set in VirtViewerApp::constructor if the controller doesn't set any bindings for a given action.
* Use monitor geometry, not screen sizeMarc-André Lureau2012-12-071-2/+6
| | | | | | | | | | | | | In a recent commit, 3bb6f5ec805ecfe78eba6d4d98e3ffcab195273a, I introduced a regression: going fullscreen would no longer match client and guest resolution correctly. A GdkScreen is not necessarily the physical screen monitor size. Lookup the physical monitor size using gdk_screen_get_monitor_geometry(). Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=881020
* session-spice: Cast CA string to gunit8 pointerMichal Privoznik2012-12-051-1/+1
| | | | | | | SpiceSession has 'ca' property which is type of GByteArray*. However, when we read the property from file, we read it as string. For conversion g_byte_array_new_take() is used which takes given pointer as guint8* so we need to do the cast.
* Sanitize syntax-checkMichal Privoznik2012-12-051-0/+1
| | | | | | | | make syntax-check is producing some errors about empty line at EOF and missing #include <config.h> in src/virt-viewer-file.c * src/virt-viewer-file.c: add #include <config.h> * data/virt-viewer-debug.nsis.in: remove empty line at EOF
* Make .desktop file comply with specDoug Goldstein2012-12-051-2/+2
| | | | | | | The .desktop file did not comply with the Desktop Entry spec as checked with desktop-file-validate. Boolean keys are defined as taking only 'true' or 'false', the entry Terminal had False. MimeType is a string list and therefore must be terminated with a ;
* remote-viewer: learn to connect from fileMarc-André Lureau2012-11-271-2/+22
| | | | | v2: - move some variables to inner-block as requested by reviewer
* spice: learn to connect from fileMarc-André Lureau2012-11-271-1/+90
|
* Add VirtViewerSession:file propertyMarc-André Lureau2012-11-273-0/+43
| | | | | | | | | | If VirtViewerSession:file is set, it should be used to define the connection parameters. Also correct the mime type used in this case. The mime type is needed to identify the kind of resources we are adding to the recent list. The recent list can then be filtered and various application handling that type may attempt to access that resource.
* Add VirtViewerFileMarc-André Lureau2012-11-273-0/+900
| | | | | | | v2: - use !! for boolean values setter - switch from bytearray/base64 to plain string for CA (PEM) - add file format comment
* Move spice_hotkey_to_gtk_accelerator() to utilMarc-André Lureau2012-11-273-114/+116
| | | | | To be compatible with RHEVM, VirtViewerFile hotkey format will use the Spice Controller format.
* recent: get mime type from sessionMarc-André Lureau2012-11-271-5/+4
| | | | | Do not use spice mime type for all kind of sessions, but depending on what is actually being used.
* session: add virt_viewer_session_mime_type()Marc-André Lureau2012-11-274-0/+27
|
* display: only un-constrain display size once it is mappedMarc-André Lureau2012-11-271-1/+2
| | | | | | Wait until the widget is actually on screen before removing its size constrain. This solves 50x50 window secondary window size when connecting to a multi-monitor spice guest.
* debug-helper: include <config.h>Michal Privoznik2012-11-211-0/+1
|
* spice: the session is connected when main channel openedMarc-André Lureau2012-11-211-2/+1
| | | | | | | The previous change in 399aae55aa384bf91dff0fc770497c0d5f935fa9 rely on correct session-connected signal. However, the spice backend is emiting it too early, when the main channel is created, where it should wait until it is connected instead.
* "Unable to connect to the graphic server" error on guest shutdownMarc-André Lureau2012-11-201-4/+6
| | | | | | | | | | In virt_viewer_app_activate(), priv->connected is set to FALSE when the connect/active is successfull. However, we rely on it to know whether the virt_viewer_app_disconnected() is an error, so only set it to FALSE when connection failed. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=875697
* Make sure png screenshots have a .png extensionsChristophe Fergeau2012-11-151-2/+10
| | | | | | When falling back to saving to .png, the filename might not end with .png. This commit appends the .png extension to the screenshot filename if it's missing.
* Allow to save to other formats than pngChristophe Fergeau2012-11-151-2/+53
| | | | | | Currently, the screenshots can only be saved to png. This commit checks if the file extension is a known one, and will save to this format if it is. Otherwise it will fallback to saving to png.
* Set a default dir/name for screenshotsChristophe Fergeau2012-11-151-3/+5
| | | | | | | It makes sense for the screenshots to be saved in ~/Images, especially as otherwise the filechooser will display 'recent documents' to which we cannot save. This commit also sets the default screenshot name to 'Screenshot'.
* Don't SIGSEGV if no transport is used.Michal Privoznik2012-11-141-1/+1
| | | | | | | | One of previous commits (74b1b62510d939) allowed us to connect to localhost directly if ssh transport was used. However, if there's not transport, we SIGSEGV'ed as g_str_equal doesn't like NULL as one of arguments. Change this to g_strcmp0 which does the same service but is more friendly to NULL arguments.
* Reconnect to libvirtd after connection breaksMichal Privoznik2012-11-132-8/+55
| | | | | | | | Currently, if user wants to reconnect to a domain he can use '-r' cmd line argument. This makes virt-viewer listen to domain events. However, if connection to libvirtd breaks somehow, we will receive no longer any event. Hence we must reconnect to the libvirt.
* Connect to localhost for display when transport is sshDave Allan2012-11-081-3/+11
| | | | | | | | | | | When connecting to a VM that does not have a 'listen' tag in its graphcs element, we have to guess where to try to connect to the VM's display. The current default is the host specified in the connection URI which is correct for most transports, however, the SSH transport makes the display connection from the remote end, so in that case, attempt to connect to localhost. Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Fix jenkins build failureMarc-André Lureau2012-10-231-0/+1
| | | | | | | | | virt-viewer-util.c: In function 'virt_viewer_util_init': virt-viewer-util.c:289: warning: implicit declaration of function 'setlocale' virt-viewer-util.c:289: warning: nested extern declaration of 'setlocale' virt-viewer-util.c:289: error: 'LC_ALL' undeclared (first use in this function) virt-viewer-util.c:289: error: (Each undeclared identifier is reported only once virt-viewer-util.c:289: error: for each function it appears in.)
* Use a mutex to check if VirtViewer runningMarc-André Lureau2012-10-231-0/+9
| | | | | | | We need to warn user that installer can't proceed if there is already a running instance of VirtViewer or of the installer. https://bugzilla.redhat.com/show_bug.cgi?id=864033
* Use a common early init() functionMarc-André Lureau2012-10-234-32/+36
| | | | | There is a number of things both virt-viewer and remote-viewer need to do early during execution. Do it only in one place.
* windows: add debug-helperMarc-André Lureau2012-10-232-0/+75
| | | | | | | | | | | | This is a simple program that will set some debug variable, and run gdb and wait until it finished. This makes it possible to debug "remote-viewer --spice-controller" easily, by setting the necessary variables and keeping the parent process running (the activex whatches its death) To use it, replace the HKCU "Software\spice-space.org\spicex\client" value "$INSTDIR\bin\remote-viewer.exe --spice-controller" with "$INSTDIR\bin\debug-helper.exe remote-viewer.exe --spice-controller".
* win32: there is no CONERR$, only CONOUT$Marc-André Lureau2012-10-232-2/+2
|
* spice: only autoresize once with screen size in fullscreenMarc-André Lureau2012-10-183-2/+38
| | | | | | | | | | | | It's currently not possible to configure guest with higher resolution than native, as it will switch back to native, since the gtk widget allocation will always end up being the size of the screen. We special-case fullscreen mode, and only resize when entering fullscreen. Furthermore, it avoids sending extra unnecessary resize events to the guest whenever gtk+ call size allocate in various stages, with different values. https://bugzilla.redhat.com/show_bug.cgi?id=864929
generated by cgit (git 2.34.1) at 2025-09-26 18:41:23 +0000