Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix close of VNC displays | Daniel P. Berrange | 2012-04-04 | 1 | -1/+15 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When clicking the close button on a virt-viewer window with a VNC session open, while the VNC session terminates, the window does not go away. The problem is that the virt_viewer_session_vnc_disconnected method never gets invoked. The close button triggers a call to virt_viewer_session_clear_displays which unrefs the VirtViewerDisplayVnc instance. This in turn triggers a call to gtk_container_destroy, which destroys all widgets it contains, ie the VncDisplay * object. With the VncDisplay object in its dispose phase, no signals will ever be emitted, thus the 'vnc-disconnected' signal never gets seen. The design issue is that VirtViewerDisplayVnc is assuming it owns the VncDisplay, whereas in fact the real owner is the VirtViewerSessionVnc object. The solution is to introduce a new virt_viewer_display_close method which can be used to de-parent the widget before VirtViewerDisplay is unref'd. The VirtViewerSessionVnc object also needs to hold a full ref on the VncDisplay object, not merely a floating reference * virt-viewer-display-spice.c, virt-viewer-display.c, virt-viewer-display.h: Add virt_viewer_display_close * virt-viewer-display-vnc.c: Deparent VNC widget in virt_viewer_display_close impl * virt-viewer-session-vnc.c: Improve logging * virt-viewer-session.c: Call virt_viewer_display_close before unrefing display * virt-viewer-window.c: Improve logging Signed-off-by: Daniel P. Berrange <berrange@redhat.com> | ||||
* | Add config.h to every source file | Daniel P. Berrange | 2012-02-06 | 1 | -0/+2 |
| | |||||
* | Update copyright headers | Daniel P. Berrange | 2012-02-06 | 1 | -2/+2 |
| | |||||
* | Convert TABS to spaces & reindent everywhere | Daniel P. Berrange | 2012-02-06 | 1 | -78/+75 |
| | |||||
* | Tune the first argument in calls to g_type_class_add_private() | Guannan Ren | 2012-01-31 | 1 | -1/+1 |
| | |||||
* | Emit display-desktop-resize from set_desktop_size() | Marc-André Lureau | 2011-11-07 | 1 | -1/+0 |
| | |||||
* | Split pull part of VirtViewerDisplay out into VirtViewerSession | Daniel P. Berrange | 2011-07-11 | 1 | -144/+45 |
| | | | | | | To facilitate introduction of multi-head support, pull some of the VirtViewerDisplay class out into a new VirtViewerSession class. | ||||
* | Remove circular dependancy between VirtViewerDisplay and VirtViewer | Daniel P. Berrange | 2011-07-11 | 1 | -100/+109 |
| | | | | | | | Add many signals to VirtViewerDisplay which are emitted when various events occur. This lets us remove all the code in the VirtViewerDisplay subclasses which call back into VirtViewer methods. Instead VirtViewer can simply connect signals to the display | ||||
* | Turn VirtViewerDisplay into a proper Gtk widget | Daniel P. Berrange | 2011-07-11 | 1 | -77/+7 |
| | | | | | Turn VirtViewerDisplay into a Gtk widget instead of just a GObject, by merging the functionality from VirtViewerAlign | ||||
* | Update to optionally build with GTK3 | Daniel P. Berrange | 2011-07-11 | 1 | -1/+1 |
| | |||||
* | Introduce standard naming convention to files & methods | Daniel P. Berrange | 2011-07-01 | 1 | -0/+359 |
All source files must be named virt-viewer-XXXX All methods named virt_viewer_XXX |