summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* window: fix send key menu popup positionMarc-André Lureau2013-05-141-3/+4
| | | | | | | | | Fix send key menu popup position. The current code wasn't correctly translating the menu coordinates based on the toplevel windows position, it was always using origin 0. https://bugzilla.redhat.com/show_bug.cgi?id=913601
* man: document running remote-viewer without URIMarc-André Lureau2013-05-131-1/+4
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=882133
* Add -- to seperate program arguments to server in man / --helpMarc-André Lureau2013-05-134-4/+4
| | | | | | | | Since some of the arguments are expecting following value, make it more explicit in the man and --help that -- can seperate options from server name or location. https://bugzilla.redhat.com/show_bug.cgi?id=843103
* Allow to fullscreen and position display independentlyMarc-André Lureau2013-05-131-1/+4
| | | | | | | | | | Currently, going from window to fullscreen mode changes all display to fullscreen and realize automatic positionning on corresponding client monitor. However, it allows for much more flexibility to allow entering fullscreen on the current monitor each windows seperately. This way the user can decide on arbitrary monitor arrangement. https://bugzilla.redhat.com/show_bug.cgi?id=558241
* spice: make sure display ready hint is sync after creationMarc-André Lureau2013-05-131-7/+7
| | | | | The ready state can be set during construction time and not notified immediately.
* misc: fix typoMarc-André Lureau2013-05-131-1/+1
|
* Do not restrict disabling display to != 0Marc-André Lureau2013-05-131-5/+1
| | | | | | | | | | | | | | | | Virt-viewer hides the display window 0, but doesn't disable the display. This is inconsistent with other displays, and prevent the guest OS from reconfiguring the main display. (for monitor 0 to be really disabled in multi-monitor guest, the agent need to support sparse monitor config. If not, the first display windows will be reopened to match the new un-sparse configuration) Note also the current Linux vdagent crashes when disabling 1st monitor, to be solved seperately. Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=958550
* remote-viewer: set auto-conf before fullscreenMarc-André Lureau2013-05-031-4/+2
| | | | | | | | | | | | If a monitor is already in fullscreen, setting auto-conf to true will not move it until it is re-fullscreen This was unnoticed, because usually, the first client window is opened on the first monitor. Also we may argue than relying on g_object_set() property order is lame and fragile, we better split it in two seperate calls as this might break upstream. https://bugzilla.redhat.com/show_bug.cgi?id=872288
* Sync spec with FedoraDaniel P. Berrange2013-05-011-6/+9
|
* Post release version bumpDaniel P. Berrange2013-05-011-1/+1
|
* Set PKG_CONFIG_LIBDIR variable for mingw buildsv0.5.6Daniel P. Berrange2013-05-011-0/+4
| | | | | | | | To avoid pkg-config accidentally falling back to native versions, set the PKG_CONFIG_LIBDIR var explicitly Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Set a default value for AUTOBUILD_INSTALL_ROOTDaniel P. Berrange2013-05-011-0/+1
| | | | Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Set MANUFACTURER env variable when running wixlDaniel P. Berrange2013-05-011-1/+2
| | | | | | | | The MANUFACTURER env variable is mandatory since it is used in the data files. wixl will exit with parser error if it is not set Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Add missing include of config.hDaniel P. Berrange2013-05-011-0/+2
|
* Remove tab from source fileDaniel P. Berrange2013-05-011-1/+1
|
* Refresh translations from transifexDaniel P. Berrange2013-05-0162-3264/+3826
| | | | Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* file: add delete-this-file optionMarc-André Lureau2013-04-302-0/+34
| | | | | | | In case the virt-viewer setting file is meant to temporary, you may use the delete-this-file=1 option to ask the client to remove it, once it has been read. This is useful for example in ovirt context, where connection settings file are generated and can't be reused.
* Exit virt-viewer when trying to close any windowChristophe Fergeau2013-04-253-43/+49
| | | | | | | | Currently, in multi-screen scenarios, when closing one remote-viewer window, the corresponding screen gets disabled in the guest OS. This can be confusing as this behaves very differently from File/Quit. This commit will exit the whole application when the user tries to close one of virt-viewer window.
* gtk-3: Rework window size handlingHans de Goede2013-04-232-16/+59
| | | | | | | | | | | | | | | | With gtk-2 we have a special hack, where at first we make the virt-viewer-display request its actual size, and then once the window is mapped, we request a size of 50x50 to allow the user to resize the window to something smaller. With gtk-3 >= 3.8.1 this is broken, and the window gets resized to a smaller size as soon as we change the size request to 50x50. gtk-3 has a much better way of dealing with this in the form of widgets being able to specify both a minimal and a natural size. This patch changes virt-viewer to use this with gtk-3, instead of the gtk-2 hack. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* ovBox: Make get_preferred_width/height differentiate between min and naturalHans de Goede2013-04-231-16/+45
| | | | | | | | gtk-3's widget size negotiation code differentiates between the minimum size and the natural size of a widget, fix ovBox to pass this along from its underlying widget to its parent. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* virt-viewer-window: cleanup zoom handlingHans de Goede2013-04-231-30/+18
| | | | | | | | We've 3 similar zoom function zoom in / out / reset. in / out do not schedule a window resize when there is no display, where as reset does, which is not consistent. Also there is some duplicate code between them. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* virt-viewer-display: Use virt_viewer_display_queue_resize where possibleHans de Goede2013-04-231-2/+2
| | | | Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* mingw spec: fix x64 msi locationMarc-André Lureau2013-04-231-1/+1
|
* Prepeare notes for release 0.5.6Marc-André Lureau2013-04-151-0/+12
|
* msi: build correct 64-bit msiMarc-André Lureau2013-04-154-23/+46
|
* msi: fix icon locationMarc-André Lureau2013-04-151-1/+1
|
* build-sys: generate MSI installer instead of NSISMarc-André Lureau2013-04-151-19/+24
|
* build-sys: regenerate spec files when they changeMarc-André Lureau2013-04-152-0/+9
|
* spice: forward secure-channelsMarc-André Lureau2013-04-154-0/+35
| | | | This needs spice-gtk >= 0.19.7 and will warn with lower version
* Remove redundant check, g_strdup(NULL) is allowedChristophe Fergeau2013-04-131-1/+1
| | | | This also makes the code consistent with its surroundings.
* Fix memory leak on remote-viewer exitChristophe Fergeau2013-04-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | When exiting remote-viewer, VirtViewepApp::dispose() calls virt_viewer_app_set_connect_info() with NULL parameters to free all internal fields. However, _set_connect_info() calls virt_viewer_app_update_pretty_address() which will always allocate a new string even if the fields it's using to fill the string are NULL. This commit fixes the leak by checking if the fields have non-NULL values before creating the newly-allocated string. ==24180== 14 bytes in 1 blocks are definitely lost in loss record 540 of 8,671 ==24180== at 0x4A0887C: malloc (vg_replace_malloc.c:270) ==24180== by 0x32D2B0A187: __vasprintf_chk (vasprintf_chk.c:80) ==24180== by 0x32D52845AA: g_vasprintf (stdio2.h:210) ==24180== by 0x32D52640DC: g_strdup_vprintf (gstrfuncs.c:517) ==24180== by 0x32D526417B: g_strdup_printf (gstrfuncs.c:543) ==24180== by 0x4136E6: virt_viewer_app_update_pretty_address (virt-viewer-app.c:1681) ==24180== by 0x414100: virt_viewer_app_set_connect_info (virt-viewer-app.c:1902) ==24180== by 0x4141D0: virt_viewer_app_free_connect_info (virt-viewer-app.c:1910) ==24180== by 0x4127C6: virt_viewer_app_dispose (virt-viewer-app.c:1353) ==24180== by 0x425488: remote_viewer_dispose (remote-viewer.c:131) ==24180== by 0x32D5E14787: g_object_unref (gobject.c:2986) ==24180== by 0x4280AF: main (remote-viewer-main.c:323)
* build-sys: Simplify setting of optional CFLAGS/LDFLAGSChristophe Fergeau2013-04-122-26/+15
| | | | | | | They don't need to be wrapped inside if HAVE_XXX blocks in Makefile.am as when XXX is not available, XXX_CFLAGS and XXX_LIBS will expand to the empty string, and thus we can carry them unconditionally in our app_CFLAGS/app_LDFLAGS variables.
* Be more consistent in #if/#ifdef useChristophe Fergeau2013-04-122-19/+17
| | | | | | | Some of the code is checking for spice-gtk/oVirt availability by using #ifdef HAVE_XXX, and some of the code is using #if HAVE_XXX. As configure.ac only AC_DEFINE() HAVE_XXX when XXX could be found, let's use the #ifdef HAVE_XXX form everywhere
* Add oVirt supportChristophe Fergeau2013-04-124-5/+262
| | | | | | This commit adds support for ovirt:// URIs. It does so by using libgovirt to get the spice/vnc connection information through oVirt xmlrpc API.
* build-sys: fix distcheckMarc-André Lureau2013-04-111-0/+1
|
* po: Remove extraenous backslash, breaking the buildHans de Goede2013-04-112-2/+2
|
* Refresh translations from transifexDaniel P. Berrange2013-04-0863-7359/+13786
|
* virt-viewer-app: Always allow users to close displays from the displays menuHans de Goede2013-04-051-2/+2
| | | | | | | | | | | | Marking display menu items as non sensitive for shown displays make no sense, since the user can always close them through the window-manager. Having a window for a display shown when the display is not selectable nor ready, can happen when the agent goes away. This happens for example when using a dual monitor config with a Linux guest and then switching to a text console inside the guest. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Use translations when looking up key combination to sendChristophe Fergeau2013-04-021-15/+15
| | | | | | | | | | | | virt_viewer_window_menu_send() compares the label of the menu item that was clicked on with a list of known labels to know which key combination should be sent to the guest. However, the menu label can be translated, but the table doing the label -> key combination mapping uses untranslated labels. This means the menu item will not send any key combination when clicked if translated. This can be observed with fr_FR where "Ctrl+Alt+_Del" is translated to "Ctrl+Alt+_Suppr".
* win32: maximize when leaving fullscreen the first timeMarc-André Lureau2013-04-021-0/+6
| | | | | | | | On windows, the client window may end up with a non-visible toolbar, and overlapping the windows statusbar. To workaround this, let's maximize the client the first time leaving fullscreen. https://bugzilla.redhat.com/show_bug.cgi?id=916810
* Do not enable extra monitors until they are explicitely enabledMarc-André Lureau2013-03-283-2/+6
|
* Make display menu item sensitive againMarc-André Lureau2013-03-281-2/+1
| | | | | | | | Even if the display has not been explicitely disabled, as long as the display is "selectable" Fix regression introduced with "Do not disable extra client monitors" 3b981d953f270662360e5b0c78183924276a18ed
* Remove gtk_window_present() callMarc-André Lureau2013-03-261-1/+0
| | | | | | | | | | | | | | | | | | gtk_window_present() may forcefully call gdk_window_show(), which will call ShowWindow(). Although gdk call is not supposed to move the window if it's already visible, it does restore the window position on Vista+. For example, a snapped window will be moved back to its previous position. Gtk+ ShowWindow() is currently using SW_SHOWNOACTIVATE, it should probably use SW_SHOWNA instead, but that didn't help anyway for a snapped window. Since virt_viewer_window_show() already ensure the window is visible, I am not sure why gtk_window_present() is there in the first place, so just remove it. https://bugzilla.redhat.com/show_bug.cgi?id=912713
* Add gtk_widget_get_realized() define for old gtk+Marc-André Lureau2013-03-261-0/+6
| | | | Fix build with gtk < 2.20
* window: keep display size when leaving fullscreen for first timeMarc-André Lureau2013-03-261-0/+2
| | | | | | | | | If the application was started in fullscreen, window geometry has not been saved, since the window was not realized. We can unfullscreen and restore 1:1 window to match guest display size with virt_viewer_display_queue_resize() https://bugzilla.redhat.com/show_bug.cgi?id=916810
* window: save window geometry if the window is realizedMarc-André Lureau2013-03-261-6/+5
| | | | | Protect against re-entering fullscreen by moving pre-condition, keey the last know window geometry, since it stays valid.
* window: resize to monitor geometryMarc-André Lureau2013-03-261-7/+7
| | | | This code is potentially bad, we should set size request to the size of the monitor
* display: make a function to queue the dirty display allocation trickMarc-André Lureau2013-03-252-10/+14
|
* app: add get_fullscreen_auto_conf()Marc-André Lureau2013-03-252-1/+10
|
* Reuse existing 'displays' submenu rather than recreating itChristophe Fergeau2013-03-251-4/+32
| | | | | | | | | | | Because of what apparently is a gtk+2 bug , we cannot recreate the submenu every time we need to refresh it, otherwise the application may get frozen with the keyboard and mouse grabbed if gtk_menu_item_set_submenu is called while the menu is displayed. Reusing the same menu every time works around this issue. https://bugzilla.redhat.com/show_bug.cgi?id=922712