summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* remote-viewer-connect: Changed dialog into a windowLukas Venhoda2015-06-163-28/+113
| | | | | | Changed connect dialog from GtkDialog to a GtkWindow. Added the necessary signals and buttons, to keep the behaviour of a dialog. (ESC to close, ENTER to submit)
* remote-viewer-connect: Check if uri is NULLLukas Venhoda2015-06-161-1/+3
| | | | URI should be NULL before passing it to remote_viewer_connect_dialog.
* remote-viewer-connect: Changed response to gbooleanLukas Venhoda2015-06-163-6/+17
| | | | | | remote_viewer_connect_dialog now returns TRUE and FALSE, instead of 0 and -1. Added a doxygen style comment to document this in code also.
* remote-viewer: Connect dialog moved to its own fileLukas Venhoda2015-06-164-158/+229
| | | | | | | | Connect dialog from remote-viewer is now in its own file. Most other dialog also have their own files. This will make changing the dialog into a window easier. Renamed connect_dialog to remote_viewer_connect_dialog.
* configure: Require spice-protocol 0.12.7Pavel Grunt2015-06-161-1/+1
| | | | We are already using SPICE_CHANNEL_WEBDAV from spice/enums.h
* Enable hotkeys after setting them in virt_viewer_app_set_hotkeysChristophe Fergeau2015-06-151-1/+1
| | | | | | | | | | | Enabling hotkeys will trigger a rebuild of the 'send keys' menu containing the new hotkeys. virt_viewer_app_set_hotkeys() was clearing and then enabling the hotkeys before parsing the string containing the new hotkeys. This was causing these hotkeys to be missing from the 'Send keys' menu when they are set through the spice controller because the 'send keys' menu was rebuilt before the new hotkeys are set. Resolves: rhbz#1055600
* nsis: Ship libwinpthread even without libvirt supportFabiano Fidêncio2015-06-111-1/+1
| | | | | Without libwinpthread, remote-viewer complains about missing this dll, when built using --without-libvirt
* Add InstallScope="perMachine" to virt-viewer.wxs.inSandy Stutsman2015-06-101-1/+1
| | | | | | | | | | | Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1146016 Without this parameter the installer will place the start menu icon in the Admin users path rather than the 'AllUsers'. Unprivileged users are unable to use the menu to start the remote-viewer. N.B. Because previous installations mixed Users and PerMachine (AllUsers) paths, this installation will *NOT* properly upgrade them. They must be manually uninstalled first.
* Add missing config.h header fileDaniel P. Berrange2015-06-101-0/+2
|
* vv-file: Show 'newer-version-url' when version check failsChristophe Fergeau2015-06-091-5/+17
| | | | | | | We currently display a generic error message when the current binary is older than the minimum version specified in the vv file. The previous commit added a 'newer-version-url' field to these .vv file. This commit adds that URL to the error message if it's set.
* vv-file: Add 'newer-version-url' key to .vv filesChristophe Fergeau2015-06-093-0/+34
| | | | | | If set, this URL will be displayed when one of the version checks ('version' of 'versions' key fail). This URL should contain explanations about how to get an updated remote-viewer version.
* test: Add test case for virt_viewer_compare_buildidChristophe Fergeau2015-06-092-0/+79
|
* util: Replace virt_viewer_compare_version with _compare_buildidChristophe Fergeau2015-06-094-20/+61
| | | | | | This allows us to do a more accurate version check if the .vv file producer wants to allow builds newer than x.y-z because they contain an important bug fix.
* vv-file: Use "versions" in min version checkChristophe Fergeau2015-06-091-2/+21
| | | | | | | | This tries to use the list of versions added to .vv files by the previous commit. If remote-viewer was built with an os-id specified, and if it's found in the 'versions' .vv file key, then the version associated with it is used for version checks, otherwise the 'version' field is used if present.
* Show osid in remote-viewer --versionChristophe Fergeau2015-06-091-1/+5
|
* build-sys: Add --with-osidChristophe Fergeau2015-06-091-0/+6
| | | | | | | | | This new configure flag allows to specify a string ID (eg fedora22, ubuntu10.04, ..) identifying the OS this remote-viewer build will be for. This will be used in combination with the new 'versions' field in .vv files in order to make it possible for the creator of the .vv file to specify which version it expects for the various OSes which may connect.
* vv-file: Add VirtViewerFile::versionsChristophe Fergeau2015-06-093-1/+82
| | | | | | | | | | | | Specifying a single minimal version in the .vv file is not enough as the client version will be highly dependent on the OS it's running in. Windows versioning is not the same as linux versioning, Fedora 21 and Fedora 22 may have different release numbers for the same version, and we may want to force a specific minimal release in case of a critical bug fix. This commit adds supports for a 'versions' field in .vv files where a list of os-id:version couples can be stored.
* vv-file: Refactor virt_viewer_file_check_min_versionChristophe Fergeau2015-06-091-12/+15
| | | | Reorganize the code a bit so that it's easier to extend it.
* vv-file: Move version checking code in its own functionChristophe Fergeau2015-06-091-5/+15
| | | | | | This moves the version checking code in a virt_viewer_file_check_min_version helper so that it can be reused/extended more easily.
* build-sys: Always prepend '-' to BUILDIDChristophe Fergeau2015-06-091-2/+2
| | | | | | | | | | | | | This was removed by commit 28a6bd6 as WINDOWS_PRODUCTVERSION needs a buildid without a dash. Apart from this variable, all other uses of buildid/BUILDID in virt-viewer source tree need a dash between the version number and the buildid to avoid getting output like "3.01" instead of "3.0-1" Rather than patching every location where BUILDID is used, this commit appends the "-" before substituting/defining BUILDID in configure.ac. This does not modifies the buildid configure.ac variable, this way WINDOWS_PRODUCTVERSION won't get an unwanted '-'.
* build-sys: Don't substitute buildid when it was not setChristophe Fergeau2015-06-091-2/+7
| | | | | Since it defaults to being 0, we'll get a spurious 0 on remote-viewer --version if we AC_DEFINE/AC_SUBST it when the user did not specify it.
* monitor-mapping: Do not allow to skip a displayPavel Grunt2015-06-043-0/+17
| | | | | | | | | | Skipping a display does not have an effect because displays will be reconfigured and shifted on the guest side anyway. these monitor mappings are not valid: 'monitor-mapping=1:2;3:1' - display #2 is not specified 'monitor-mapping=4:2;2:1' - displays #1, #3 are not specified 'monitor-mapping=3:3' - displays #1, #2 are not specified
* session-spice: Only update displays geometry if the agent is connectedFabiano Fidêncio2015-06-021-3/+8
|
* virt-viewer: Fix choose VM dialog alt-tab in gnome2Lukas Venhoda2015-05-211-2/+0
| | | | | | | Choose VM dialog was not visible in taskbar and alt-tab when running on system with gnome2. rhbz#1223285
* Revert "display-vnc: fix zoom-level set by command line"Fabiano Fidêncio2015-05-211-1/+0
| | | | | | | | | | | | | This reverts commit 68148e1bd1a47ff370c78e2569a57ae0f3d8a400. The commit in question was causing a regression about a tiny window being displayed when opening a vnc guest. The issue only happens with the gtk2 version of virt-viewer. rhbz#1170071 that was solved by the reverted commit is avoided by the commit c45a30e909656434aa842d48d828ef038ec7364a. Resolves: rhbz#1201679
* session-vnc: Set window for display to avoid gtk-vnc v0.3.8 crashPavel Grunt2015-05-211-0/+5
| | | | | | | The VNC display widget of gtk-vnc v0.3.8 needs a window at the moment it is initialized otherwise it would crash. Resolves: rhbz#1196517
* virt-viewer-display-vnc: Set uuid when using VNCLukas Venhoda2015-05-212-1/+8
| | | | | | | | Notify user, that VNC does not provide uuid. Set uuid to string "VNC does not provide guid". This is more informative then just plain "Unknown". User will now know WHY the GUID is unknown, when using remote-viewer.
* virt-viewer-display-vnc: Set guest name when using VNCLukas Venhoda2015-05-211-0/+14
| | | | | | | | | | | | If it's not already set, set guest name field in virt-viewer-app when using VNC. Wait for VNC to be initialized (virt_viewer_display_vnc_initialized()). In this callback get field guest name from app and check whether it was already set before (FE from libvirt). If not, set the guest name to name provided by VNC from vnc_display_get_name(). This fill fix issue in remote-viewer: Guest name is Unknown when using VNC.
* Fix syntax-checkMichal Privoznik2015-04-291-1/+1
| | | | | | | | | | | | Commit c45a30e9 broke syntax-check: trailing_blank src/virt-viewer-window.c:1478: maint.mk: found trailing blank(s) maint.mk:700: recipe for target 'sc_trailing_blank' failed make: *** [sc_trailing_blank] Error 1 Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
* virt-viewer-window: Set initial zoom only oncePavel Grunt2015-04-221-1/+3
| | | | | | | It is not needed to do it more times as it may cause unnecessary resize events especially when leaving the fullscreen mode related: rhbz#1206460
* virt-viewer-window: Make sure that minimum zoom level is lower than ↵Pavel Grunt2015-04-221-1/+2
| | | | | | | | | NORMAL_ZOOM_LEVEL The minimum size of the desktop is 100x100 if the minimum window size is greater than this, the zoom level is greater than NORMAL_ZOOM_LEVEL related: rhbz#1206460
* virt-viewer: Set toolbar buttons not sensitive when neededLukas Venhoda2015-04-225-0/+43
| | | | | | | | | | | | | | File->Screenshot, File->Preferences, View->Zoom and Send keys are now sensitive only while quest is connected. Changed behaviour of zoom: Previously, zoom could be set while quest wasn't connected. The zoom would then be set on connection. There was no indication of current zoom level while not connected to guest. Now, the menu is not sensitive while not connected to guest. Zoom can now be only modified while connected to guest, or from the command line.
* app/window: Set display menu not sensitive when neededLukas Venhoda2015-04-223-1/+19
| | | | | Displays menu must be sensitive only when at least one display is enabled.
* cosmetic: move the "break" to inside the {} blockFabiano Fidêncio2015-04-221-1/+1
|
* spice-session: use the error message, when available, on _channel_destroy()Fabiano Fidêncio2015-04-221-1/+4
|
* session-spice: Destroy the channel instead of emit a "session-disconnect" signalFabiano Fidêncio2015-04-221-2/+2
| | | | | | | | Whenever we reach these branches, we will abort or have to create a new spice session (from the dialog showed to the user). So, destroying the channel on these situations seems sane enough. It also avoids an error dialog to be popped out twice with (basically) the same information.
* session-spice: Do not use _UNUSED for used attributesFabiano Fidêncio2015-04-221-1/+1
| | | | channel attribute is actually used for error treatment
* display: remove useless identation levelFabiano Fidêncio2015-04-221-23/+21
|
* SessionSpice: Protect against unreffing window twiceJonathon Jongsma2015-04-151-2/+1
| | | | | | In theory, the dispose method can be called multiple times, so any member variables that are unreffed should be set to NULL so that we don't accidentally unref them multiple times.
* build-sys: Ship mingw-virt-viewer.spec in tarballsChristophe Fergeau2015-04-151-0/+2
| | | | | virt-viewer.spec is already shipped in tarballs, it's convenient to have a pregenerated mingw-virt-viewer.spec in there as well.
* virt-viewer-main: '--wait' should not be used without domain namePavel Grunt2015-04-141-0/+5
| | | | | | | | | | | Commit a830275344c88aef12166661b68ea2b4429c7212 required the domain name to be placed just after the '--wait' option. It broke the command line api, because running 'virt-viewer $vm --wait' was considered as the error. This patch rather checks whether the domain name was specified. Related: rhbz#1209398, rhbz#1211573
* Revert "virt-viewer-main: Require domain name as argument for '--wait'"Pavel Grunt2015-04-141-5/+4
| | | | | | | | | | | This reverts commit a830275344c88aef12166661b68ea2b4429c7212. Commit a830275344c88aef12166661b68ea2b4429c7212 required the domain name to be placed just after the '--wait' option. It broke the command line api, because running 'virt-viewer $vm --wait' was considered as the error. Related: rhbz#1209398, rhbz#1211573
* Revert "man: document that '--wait' requires domain as parameter"Pavel Grunt2015-04-141-1/+1
| | | | | | | | | | | This reverts commit 9ba2d28a0f35b69befd26d7c122bbe4cd626422f. Commit a830275344c88aef12166661b68ea2b4429c7212 required the domain name to be placed just after the '--wait' option. It broke the command line api, because running 'virt-viewer $vm --wait' was considered as the error. Related: rhbz#1209398, rhbz#1211573
* Revert "virt-viewer-main: exit when domain names doesn't match"Pavel Grunt2015-04-141-5/+0
| | | | | | | | | | | This reverts commit 10264d0d1ecbd67d3e59e3a1a3032936b0635eda. Commit a830275344c88aef12166661b68ea2b4429c7212 required the domain name to be placed just after the '--wait' option. It broke the command line api, because running 'virt-viewer $vm --wait' was considered as the error. Related: rhbz#1209398, rhbz#1211573
* virt-viewer-main: exit when domain names doesn't matchPavel Grunt2015-04-141-0/+5
| | | | | | | | | Since the domain name is required as a parameter for the '--wait' option (commit a830275344c88aef12166661b68ea2b4429c7212 ), it is neccessary to check whether all domains names are the same. Otherwise it wouldn't be clear which name should be used. related: rhbz#1211573
* man: document that '--wait' requires domain as parameterPavel Grunt2015-04-141-1/+1
| | | | related: rhbz#1211573
* man: document usage of domain name as optionalPavel Grunt2015-04-142-2/+6
| | | | related: rhbz#1211573
* ovirt: Allow to cancel authentication without showing error dialogPavel Grunt2015-04-142-1/+24
| | | | Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1201604
* ovirt: Add support for an 'admin' key in vv fileChristophe Fergeau2015-04-093-0/+31
| | | | | | | | | | | When using a user with administrator rights, the VMs this user can access from the user portal and the admin portal are different, and REST API users must indicate which set of VMs they want through a specific header. libgovirt already has support for that in its API, but virt-viewer was not making use of that API. This commit adds support for an 'admin' field in the [ovirt] section of .vv files so oVirt can indicate remote-viewer whether this header should be set or not.
* virt-viewer-app: Do not show error dialog twice for unknown graphicPavel Grunt2015-04-091-2/+0
| | | | Related: rhbz#1085216
generated by cgit (git 2.34.1) at 2025-09-30 09:01:50 +0000