summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* window: auto-add hot key combos to "Send key" menuMarc-André Lureau2013-07-301-0/+73
| | | | | | | Auto-add hotkey combos to "Send key" menu. Because they are captured by virt-viewer, there is currently no way to pass them to the guest. https://bugzilla.redhat.com/show_bug.cgi?id=846006
* window: use dynamically generated menuMarc-André Lureau2013-07-302-170/+31
| | | | | Remove the static Glade menu in favour of the one generated dynamically already used for the toolbar.
* window: use a menu item property for key combosMarc-André Lureau2013-07-301-41/+53
| | | | | | | Allow to add dynamically generated key combos later on. This also removes the extra combo lookup, which used to be problematic due to translations etc.
* compat: add a few GDK_Key definesMarc-André Lureau2013-07-301-0/+2
|
* file: add missing field commentMarc-André Lureau2013-07-301-0/+1
|
* Remove restore window location codeMarc-André Lureau2013-07-301-14/+0
| | | | | | | | | It turns out gdk on win32 already restores properly the window size/positon when leaving fullscreen. On non-win32, the WM should do the job. This solves the first window having too small size after leaving fullscreen: https://bugzilla.redhat.com/show_bug.cgi?id=978362
* win32: fix first window un-shrinkable at startMarc-André Lureau2013-07-301-8/+26
| | | | | | The fix 0dca975d64fcf0782ec7b3e3bd965f1bcf47c528 make the first window unshrinkable right after start. Wait until the window is mapped and remove the dirty-resizable state after (win32/gtk2).
* Make zoom-reset a global key bindingMarc-André Lureau2013-07-304-1/+6
|
* spice: if zoom-level is changed, resize guest, even in fullscreenMarc-André Lureau2013-07-302-0/+17
|
* spice: factor out spice resize code from gtk signal handlerMarc-André Lureau2013-07-301-4/+14
| | | | | This will allow that part of the code to be called with a different resize-guest setting.
* msi: use ProductVersion compatible with Windows InstallerMarc-André Lureau2013-07-302-2/+16
| | | | | | | | | Windows Installer expects version of form major.minor.build in order to perform updates. Following Daniel Berrange suggestion, compute a ProductVersion compatible with this scheme by shifting virt-viewer "micro" release number and adding the extra "buildid".
* wxs: add usb.ids and keyboard-shortcuts.pngMarc-André Lureau2013-07-301-0/+25
|
* Hide extra monitors that don't fit in auto-confMarc-André Lureau2013-07-301-1/+4
| | | | | | | | | | Virt-viewer sometimes opens one too many windows if the guest is configured with more monitors than the client (the spice monitor configuration request and the current config aren't related, so there is some race). Instead, let's hide extra monitors that wouldn't fit in auto-conf. https://bugzilla.redhat.com/show_bug.cgi?id=985898
* Realize the display when it's added to the windowMarc-André Lureau2013-07-301-0/+1
| | | | | Make sure the widget get some dimensions, so if the display is enabled before it is actually shown, it will have non-zero size
* Initialize fullscreen_monitor to invalid valueMarc-André Lureau2013-07-301-0/+1
| | | | This makes it easier to debug when a window has no associated monitor.
* Disable auto-conf when user toggle displayMarc-André Lureau2013-07-301-0/+2
| | | | Let's get out of auto-conf mode whenever user tricks display visibility.
* Remove dead functionMarc-André Lureau2013-07-301-7/+0
|
* Remove typo \\n in de.po translationDaniel P. Berrange2013-07-291-1/+1
| | | | Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* Unregister events and callbacks on disposeJán Tomko2013-07-291-12/+19
| | | | | | Without these libvirtd reports an error on virt-viewer shutdown: virNetSocketReadWire:1377 : End of file while reading data: Input/output error
* virt-viewer: Allow TLS-only SPICE connectionsChristophe Fergeau2013-07-111-12/+12
| | | | | | | | | | | | | | | | | | | | | When trying to connect to a VM which uses SPICE with only a tls port set: <graphics type='spice' tlsPort='-1' autoport='no' listen='0' keymap='en-us'> <listen type='address' address='0'/> </graphics> the connection will fail with "Cannot determine the graphic address for the guest spice" virt_viewer_extract_connect_info() indeed assumes that if no non-TLS port is set, then this means we are trying to connect through an already open socket, and otherwise the connection fails. The presence of a TLS port is only checked when a non-TLS port is set. This commit reworks that logic to start by extracting both the non-TLS and TLS ports (only when using SPICE for the latter), and by only trying to parse the socket to use if none of these 2 ports is set This fixes rhbz#982840
* Refresh translations from transifexDaniel P. Berrange2013-07-0965-5013/+5634
| | | | Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
* vnc: implement release_cursor()Marc-André Lureau2013-07-081-0/+9
| | | | | Error reported in: https://bugzilla.redhat.com/show_bug.cgi?id=904094
* app: always use maybe_quit()Marc-André Lureau2013-07-083-3/+2
| | | | | | | Now that closing a window is like quiting, there is no reason to ask or skip the confirm dialog depending on how you quit (menu/toolbar/window). https://bugzilla.redhat.com/show_bug.cgi?id=905684
* usbredir: Don't depend on channel orderingHans de Goede2013-07-064-27/+63
| | | | | | | | | | | | | Before this patch-set virt-viewer was calling spice_session_has_channel_type( session, SPICE_CHANNEL_USBREDIR) from the session-initialized signal handler, So as soon as the display channel gets added to the session, the check was done. This causes the check to return FALSE for usbredir capable vms if the usbredir channel(s) get added to the session after the display channed. This patch refactors things to not depend on channel creation order. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Use display fullscreen state instead of app stateMarc-André Lureau2013-07-051-6/+6
| | | | | | | | This is a recent regression introduced by independant fullscreen windows support, which reopened the bug "Resolution higher than native could not be set in fullscreen" https://bugzilla.redhat.com/show_bug.cgi?id=864929
* window: set display fullscreen stateMarc-André Lureau2013-07-051-2/+7
|
* display: add fullscreen propertyMarc-André Lureau2013-07-052-0/+33
| | | | | Now that fullscreen state is no longer global to application, we need to have the current state per display
* Remove debugging leftoverMarc-André Lureau2013-07-051-1/+0
|
* data/remote-viewer.desktop: Fix missing trailing ;Marc-André Lureau2013-07-041-1/+1
| | | | | | | data/remote-viewer.desktop: error: value "x-scheme-handler/spice;application/x-virt-viewer" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
* Use -H instead of -h for the short --hotkeysChristophe Fergeau2013-07-034-4/+4
| | | | | | -h conflicts with the short version of --help. Fixes rhbz#980846
* Fix build --without-spice-gtkMarc-André Lureau2013-06-281-29/+27
|
* Use format stringGuido Günther2013-06-261-1/+1
| | | | | | | | to fix virt-viewer.c: In function 'virt_viewer_connect': virt-viewer.c:686:13: error: format not a string literal and no format arguments [-Werror=format-security] g_warning(error->message);
* ovirt: Set host subject if neededChristophe Fergeau2013-06-112-1/+5
| | | | | | | | | | For some VMs, setting host subject on SpiceSession is needed to be able to connect to it using SPICE/SSL. Until recently, this was not exposed in oVirt REST API/libgovirt. Since oVirt 3.2/libgovirt 0.1.0, the host subject is available, this patch makes use of it. This should fix connection to oVirt VMs that were migrated to a different host than the one they were started on.
* spec: Add missing % in %if 0{?fedora}Christophe Fergeau2013-06-041-1/+1
| | | | This was missing in previous commit.
* spec: Deprecate spice-clientChristophe Fergeau2013-06-041-0/+5
| | | | | This has been true for quite some time, it's high time we stop building spicec and have remote-viewer replace it on upgrades.
* Support Spice controller "auto-display-res" flagMarc-André Lureau2013-05-271-4/+3
| | | | | | | | The controller "auto-display-res" flag should be use to reconfigure guest to match client configuration. This is what the --fullscreen=auto-conf option is already made for. https://bugzilla.redhat.com/show_bug.cgi?id=967154
* man: document auto-conf fullscreen optionMarc-André Lureau2013-05-241-2/+7
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=875559
* Use a more descriptive FileDescriptionMarc-André Lureau2013-05-231-2/+2
| | | | | | This field is used to invite the user to close running instances, when updating the installation with an MSI. "A remote desktop client" isn't specific enough, use a VirtViewer specific description.
* build-sys: add debug-helper ruleMarc-André Lureau2013-05-231-0/+6
|
* app: move display on client monitors with --full-screenMarc-André Lureau2013-05-221-7/+3
| | | | | | | | | | | There used to be a check to fullscreen the only visible display on current monitor, by checking the number of visible monitors. Now that fullscreen is independant for each display, and goes on current monitor, it's useless. However, this code path is still used for the app --full-screen, at startup time. And it is still nicer to open the display on respective client monitors, rather than all on current monitor.
* Fix trivial criticalMarc-André Lureau2013-05-211-5/+7
| | | | | | GLib-CRITICAL **: g_strv_length: assertion `str_array != NULL' Committed without review under trivial rule.
* Show connect dialog again if connection from dialog failedMarc-André Lureau2013-05-174-19/+39
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=864026
* spice-session: use a more robust signal connectMarc-André Lureau2013-05-171-4/+4
| | | | | | The Spice session may outlive the virt-viewer session, due to it's async nature. Use the more robust virt_viewer_signal_connect_object() to fix delayed potential crashes.
* Move connect dialog to remote-viewer.cMarc-André Lureau2013-05-173-97/+120
|
* Silence unused arguments warningsMarc-André Lureau2013-05-161-3/+3
| | | | | | | | | | In file included from virt-viewer-session-spice.c:41: gbinding.c: In function 'on_source_notify': gbinding.c:381: warning: unused parameter 'gobject' gbinding.c: In function 'on_target_notify': gbinding.c:422: warning: unused parameter 'gobject' gbinding.c: In function 'g_binding_init': gbinding.c:709: warning: unused parameter 'binding'
* Rename variable, fix gcc warningMarc-André Lureau2013-05-162-8/+8
| | | | virt-viewer-main.c:61: warning: declaration of 'basename' shadows a global declaration
* Remove the "container" logic used by legacy browser pluginMarc-André Lureau2013-05-165-67/+7
|
* window: wait until mapped before fullscreenMarc-André Lureau2013-05-161-27/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | On RHEL6, when starting virt-viewer --full-screen, metacity will remaximize & force-fullscreen when leaving fullscreen, which prevents user from accessing window titlebar, and end up with an incorrect fullscreen state. Thanks Owen Taylor for help debugging this: <owen> elmarco: So the interesting thing here is that the "legacy" isn't triggered off a configure request to a particular size, mutter seems to constrain the window back to fullscreen size on its own when it sees a change to WM_NORMAL_HINTS <owen> commit 4943d79d6844af3f7fc0a15ceadb69d95c4c5c61 <owen> Author: Peter Bloomfield <PeterBloomfield@BellSouth.net> <owen> Date: Wed Jan 20 10:59:07 2010 -0500 <owen> prevent window self-maximisation <owen> Is not in rhel6 metacity <owen> So probably that's the main difference <owen> can you just make your program not fullscreen initially but wait until it's mapped? (gets map-event on the toplevel) <elmarco> owen that seems to work <owen> I don't have a better solution to offer - sorry for the ugliness (code and initial mapping appearance) https://bugzilla.redhat.com/show_bug.cgi?id=876445
* Only fullscreen the new windowMarc-André Lureau2013-05-161-14/+26
| | | | | The current code will forcefully reset fullscreen all windows when a new window is created
* window: leave fullscreen on current windowMarc-André Lureau2013-05-141-1/+6
| | | | | | Since fdaa9b0ca, virt-viewer allows to fullscreen a single window. It feels more symetric to leave a single window from fullscreen as well, unless the application was started in fullscreen.
generated by cgit (git 2.34.1) at 2025-10-02 02:32:14 +0000