From 6e3547f8b192f5b01d478ca222bf46736f5c700c Mon Sep 17 00:00:00 2001 From: Frediano Ziglio Date: Thu, 17 Sep 2015 15:01:05 +0100 Subject: Prevent leak if size from red_get_data_chunks don't match in red_get_image Signed-off-by: Frediano Ziglio --- server/red_parse_qxl.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'server') diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index 3ce44314..dd526029 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -526,6 +526,7 @@ static SpiceImage *red_get_image(RedMemSlotInfo *slots, int group_id, &chunks, qxl->bitmap.data); spice_assert(size == bitmap_size); if (size != bitmap_size) { + red_put_data_chunks(&chunks); goto error; } red->u.bitmap.data = red_get_image_data_chunked(slots, group_id, @@ -546,6 +547,7 @@ static SpiceImage *red_get_image(RedMemSlotInfo *slots, int group_id, &chunks, (QXLDataChunk *)qxl->quic.data); spice_assert(size == red->u.quic.data_size); if (size != red->u.quic.data_size) { + red_put_data_chunks(&chunks); goto error; } red->u.quic.data = red_get_image_data_chunked(slots, group_id, -- cgit