From 5b441c9bc500faec08e3aa5400c909310fefceb9 Mon Sep 17 00:00:00 2001 From: Alon Levy Date: Wed, 25 Aug 2010 13:34:41 +0300 Subject: server: when woken up by data ready to be read, don't call write. This used to be a callback for the vdi_port "data ready" interrupt, which did indicate either data ready to read or data ready to write, but this is no longer the case now that virtio-serial is used. This seemingly simple fix prevents a race that needs to be fixed with another patch, see freedesktop bz #29903 --- server/reds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'server') diff --git a/server/reds.c b/server/reds.c index 5829531e..ca587728 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1311,7 +1311,7 @@ static int read_from_vdi_port(void) void vdagent_char_device_wakeup(SpiceCharDeviceInstance *sin) { - while (write_to_vdi_port() || read_from_vdi_port()); + while (read_from_vdi_port()); } static void reds_handle_agent_mouse_event() -- cgit