From 00086b8898ad9527aba72d3b4348e8892de42eba Mon Sep 17 00:00:00 2001 From: Yonit Halperin Date: Wed, 15 Jun 2011 17:21:02 +0300 Subject: server: add missing calls to red_handle_drawable_surfaces_client_synced red_handle_drawable_surfaces_client_synced was called only from red_pipe_add_drawable, while it should also be called from red_pipe_add_drawable_after. Otherwise, the client might receive a command with a reference to a surface it doesn't hold and crash. --- server/red_worker.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'server') diff --git a/server/red_worker.c b/server/red_worker.c index 672f0781..bfb3cf96 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1194,6 +1194,7 @@ static inline void red_pipe_add_drawable_to_tail(RedWorker *worker, Drawable *dr if (!worker->display_channel) { return; } + red_handle_drawable_surfaces_client_synced(worker, drawable); drawable->refs++; red_pipe_add_tail(&worker->display_channel->common.base, &drawable->pipe_item); } @@ -1209,6 +1210,7 @@ static inline void red_pipe_add_drawable_after(RedWorker *worker, Drawable *draw red_pipe_add_drawable(worker, drawable); return; } + red_handle_drawable_surfaces_client_synced(worker, drawable); drawable->refs++; red_channel_pipe_add_after(&worker->display_channel->common.base, &drawable->pipe_item, &pos_after->pipe_item); } -- cgit