From fdcef173645e564be71f1b73d476c0716e91663d Mon Sep 17 00:00:00 2001 From: Uri Lublin Date: Tue, 13 Dec 2011 17:09:58 +0200 Subject: client: foreign-menu: pass "active" param when creating a ForeignMenu (#769020) The default stays the same -- false. A race could prevent setting ForeignMenu::_active correctly. That happened when Application::on_app_activated was called before _foriegn_menu was created. When foriegn_menu was created its _active defaults to false, and that has not changed, until focus was taken out and back in spice-client window. This caused usbrdr to sometimes not auto-share devices, unless the user switched focus to a different application and back to spicec. The fix updates ForiegnMenu::_active upon creation. --- client/foreign_menu.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'client/foreign_menu.cpp') diff --git a/client/foreign_menu.cpp b/client/foreign_menu.cpp index 00cc57ca..d1df49d0 100644 --- a/client/foreign_menu.cpp +++ b/client/foreign_menu.cpp @@ -36,9 +36,9 @@ #define PIPE_NAME "/tmp/SpiceForeignMenu-%lu.uds" #endif -ForeignMenu::ForeignMenu(ForeignMenuInterface *handler) +ForeignMenu::ForeignMenu(ForeignMenuInterface *handler, bool active) : _handler (handler) - , _active (false) + , _active (active) , _refs (1) { char pipe_name[PIPE_NAME_MAX_LEN]; -- cgit