From 84c7a95c22ba3a0fc5623c7cd66c9793e02ebcf8 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Tue, 13 Mar 2012 16:11:03 +0000 Subject: Avoid jumping across variables declarations with initializers If a 'goto' statement jumps across a variable declaration which also has an initializer, the variable is in an undefined state. Splitting the the declaration & initialization doesn't change that, but the compiler can at least now detect use of the unintialized variable Signed-off-by: Daniel P. Berrange --- server/reds.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index 8ae569ca..1696fbc7 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3666,9 +3666,10 @@ static int do_spice_init(SpiceCoreInterface *core_interface) reds->vdi_port_write_timer_started = FALSE; #ifdef RED_STATISTICS - int shm_name_len = strlen(SPICE_STAT_SHM_NAME) + 20; + int shm_name_len; int fd; + shm_name_len = strlen(SPICE_STAT_SHM_NAME) + 20; reds->stat_shm_name = (char *)spice_malloc(shm_name_len); snprintf(reds->stat_shm_name, shm_name_len, SPICE_STAT_SHM_NAME, getpid()); if ((fd = shm_open(reds->stat_shm_name, O_CREAT | O_RDWR, 0444)) == -1) { -- cgit