summaryrefslogtreecommitdiffstats
path: root/server
Commit message (Collapse)AuthorAgeFilesLines
* syntax-check: remove trailing whitespacesUri Lublin2013-07-163-8/+7
| | | | Only whitespace changes in this commit.
* syntax-check: make sure config.h is the first included .h fileUri Lublin2013-07-163-1/+3
|
* syntax-check: use test A && test B instead of test A -a BUri Lublin2013-07-161-1/+1
|
* syntax-check: fix no-newline or empty line at EOFUri Lublin2013-07-162-2/+1
|
* syntax-check: s/the the/the/ in a commentUri Lublin2013-07-162-2/+2
|
* syntax-check: fix cast_of_argument_to_freeUri Lublin2013-07-161-1/+2
| | | | | | | | In this case, make syntax-check is wrong, and we actually do need the cast. A cast is needed when types are uint64_t <--> pointer Using a local "ptr" variable makes both gcc and syntax-check happy.
* syntax-check: fix avoid_if_before_freeUri Lublin2013-07-161-6/+2
|
* server/tests: fix timer for test_empty_successUri Lublin2013-07-161-1/+9
|
* server/tests: test_display_width_stride: add destroy commandUri Lublin2013-07-161-0/+9
| | | | | Otherwise, the test exits after the first iteration over all tests, on the second attempt to create an already created surface.
* server/tests: remove option from usage if AUTOMATED_TESTS is not configuredUri Lublin2013-07-161-6/+19
|
* server/tests: invalid-option: print the bad argumentUri Lublin2013-07-161-1/+1
| | | | optind points to the next argument to parse.
* server/tests: fix produce_command for create surfaceUri Lublin2013-07-161-2/+4
| | | | | | | | | | | Earlier in this function, test->target_surface is set to 1, which is the only allowed non-primary surface currently. If surface parameters are given (and specifically data is checked) they are being used, otherwise a default surface is used. Earlier in this function, "command" is set to a non-NULL value. Thus, the else part was unreachable code, which is fixed now.
* server/tests: test_display_base: set rect according to appropriate surfaceUri Lublin2013-07-161-5/+2
| | | | | | | | | When surface_id == 0, primary is used. Otherwise (currently 1), secondary is used. Also, remove unused test_width and test_height. Since commit caea7699434c20dceef8fc79d21b8eeb663fbf53, test->width and test->height are used.
* red_channel: replace RING_FOREACH with RING_FOREACH_SAFE in some placesUri Lublin2013-07-161-4/+4
| | | | | | | | This was originally intended to fix the problem fixed by commit 53488f0275d6c8a121af49f7ac817d09ce68090d. What is left are FOREACH loops that are at less risk and maybe safe (no read/write or disconnect/destroy are called from within them).
* red_worker: use a generic SAFE_FOREACH macroUri Lublin2013-07-161-29/+22
| | | | | | Introduce SAFE_FOREACH macro Make other safe iterators use SAFE_FOREACH
* red_worker: delete unused CCC_FOREACHUri Lublin2013-07-161-6/+0
|
* red_worker: make DRAWABLE_FOREACH_DPI safeUri Lublin2013-07-161-9/+11
|
* red_worker: use only DRAWABLE_FOREACH_GLZ_SAFEUri Lublin2013-07-161-9/+2
|
* red_worker: make WORKER_FOREACH_DCC safeUri Lublin2013-07-161-45/+48
| | | | | | | | | | | | | | | | | Specifically, the loop in red_pipes_add_draw can cause spice to abort. In red_worker.c (WORKER_FOREACH_DCC): red_pipes_add_drawable red_pipe_add_drawable red_handle_drawable_surfaces_client_synced red_push_surface_image red_channel_client_push red_channel_client_send red_peer_handle_outgoing reds_stream_writev (if fails -- EPIPE) handler->cb->on_error = red_channel_client_disconnect() red_channel_remove_client() ring_remove() -- of rcc from channel.clients ring.
* red_worker: reuse DCC_FOREACH in WORKER_DCC_FOREACHUri Lublin2013-07-161-7/+4
| | | | The only thing that is needed is to get the channel out of the worker.
* red_worker: use only RCC_FOREACH_SAFEUri Lublin2013-07-161-9/+2
| | | | | | | | | | | RCC_FOREACH may be dangerous The following patches replace FOREACH loops with a SAFE version. Using unsafe loops may cause spice-server to abort (assert fails). Specifically a read/write fail in those loops, may cause the client to disconnect, removing the node currently iterated, which cause spice to abort in ring_next(): -- assertion `pos->next != NULL && pos->prev != NULL' failed
* Use RING_FOREACH_SAFE in red_channel.c functions which are missing itDavid Gibson2013-07-051-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, both red_channel_pipes_add_type() and red_channel_pipes_add_empty_msg() use plaing RING_FOREACH() which is not safe versus removals from the ring within the loop body. Although it's rare, such a removal can occur in both cases. In the case of red_channel_pipes_add_type() we have: red_channel_pipes_add_type() -> red_channel_client_pipe_add_type() -> red_channel_client_push() And in the case of red_channel_client_pipes_add_empty_msg() we have: red_channel_client_pipes_add_empty_msg() -> red_channel_client_pipe_add_empty_msg() -> red_channel_client_push() But red_channel_client_push() can cause a removal from the clients ring if a network error occurs: red_channel_client_push() -> red_channel_client_send() -> red_peer_handle_outgoing() -> handler->cb->on_error callback = red_channel_client_default_peer_on_error() -> red_channel_client_disconnect() -> red_channel_remove_client() -> ring_remove() When this error path does occur, the assertion in RING_FOREACH()'s ring_next() trips, and the process containing the spice server is aborted. i.e. your whole VM dies, as a result of an unfortunately timed network error on the spice channel. Please apply. Signed-off-by: David Gibson <dgibson@redhat.com>
* red_worker: fix for stuck display_channel over WAN (jpeg_enabled=true)Yonit Halperin2013-06-251-0/+4
| | | | | | | | | | | | | | The image descriptor flags shouldn't be copied as is from the flags that were set by the driver. Specifically, the CACHE_ME flag shouldn't be copied, since it is possible that (a) the image won't be cached (b) the image is already cached, but in its lossy version, and we may want to set the bit for CACHE_REPLACE_ME, in order to cache it in its lossless version. In case (b), the client first looks for the CACHE_ME flag, and only if it is not set it looks for CACHE_REPLACE_ME (see canvas_base.c). Since both flags where set, the client ignored REPLACE_ME, and didn't turned off the lossy flag of the cach item. Then, when a request from this lossles item reached the client (FROM_CACHE_LOSSLESS), the client display channel waited endlessly for the lossless version of the image.
* red_worker: improve stream stats readability and ease of parsingYonit Halperin2013-06-242-8/+15
| | | | also added start/end-bit-rate and avg-quality to the final stream stats.
* mjpeg_encoder: add mjpeg_encoder_get_statsYonit Halperin2013-06-242-0/+18
|
* spice: silencing most of the ping/pong loggingYonit Halperin2013-06-241-11/+2
| | | | Those messages are too frequent and don't contribute much
* server: Add support for filtering out agent file-xfer msgs (rhbz#961848)Hans de Goede2013-06-065-7/+37
| | | | Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* red_channel: replace an assert upon threads mismatch with a warningYonit Halperin2013-05-241-3/+25
| | | | | | | | | | | | | | | | | | | | | | | The assert: spice_assert(pthread_equal(pthread_self(), client->thread_id)) and the assert: spice_assert(pthread_equal(pthread_self(), rcc->channel->thread_id)) were coded in order to protect data that is accessed from the main context (red_client and most of the channels), from access by threads of other channels (namely, the display and cursor channels), and vice versa. However, some of the calls to the sound channel interface, and also the char_device interface, can be done from the vcpu thread. It doesn't endanger these channels internal data, since qemu use global mutex for the vcpu and io threads. Thus, pthread_self() can be != channel->thread_id, if one of them is the vcpu thread and the other is the io-thread, and we shouldn't assert. Future plans: A more complete and complicated solution would be to manage our own thread for spice-channels, and push input from qemu to this thread, instead of counting on the global mutex of qemu rhbz#823472
* main_channel: fix double release of migration target dataYonit Halperin2013-05-231-0/+2
| | | | | | | If client_migrate_info was called once with cert-host-subject and then again without cert-host-subject, on a third call to client_migrate info, the cert-host-subject from the first call would have been freed for the second time.
* Log actual address spice-server binds toChristophe Fergeau2013-05-191-5/+10
| | | | | | | | | | | It's not always obvious what address spice-server will bind to, in particular when the 'addr' parameter is omitted on QEMU commandline. The decision of what address to bind to is made in reds_init_socket with a call to getaddrinfo. Surprisingly, that function had a call to getnameinfo() already, but it does not seem to be using the result of that call in any way. This commit moves this call after the socket is successfully bound and add a log message to indicate which address it's bound to.
* server/red_parse_qxl: two coding convention pointer cast fixAlon Levy2013-05-171-2/+2
|
* server/dispatchers: initialize stack to 0 for valgrindAlon Levy2013-05-172-5/+5
|
* server/red_dispatcher: close pa hole in RedWorkerMessageDisplayConnect for ↵Alon Levy2013-05-171-2/+2
| | | | valgrind
* server/tests: test_display_width_strideAlon Levy2013-05-174-7/+154
|
* server/red_worker: simplify monitors_config updateAlon Levy2013-05-171-7/+6
|
* server/tests/test_display_base: add missing set_client_capabilities, fix ↵Alon Levy2013-05-171-1/+11
| | | | client_monitors_config signature
* server/red_worker: turn critical (assert) non error into warningAlon Levy2013-05-171-1/+4
| | | | | The situation causing this assert is unknown but it doesn't cause correctness issues with later rendering, and it is causing an abort.
* server/red_worker: s/driver_has_monitors_config/driver_cap_monitors_config/ ↵Alon Levy2013-05-171-5/+7
| | | | (plus small comment)
* red_worker: don't get bit_rate from main_channel_client, if it wasn't ↵Yonit Halperin2013-05-091-12/+30
| | | | | | | | | | | | initialized When setting an initial video stream bit rate, if the bit rate wasn't calculated by main_channel_client, and we don't have estimation from previos streams, use some default values. The patch also removes updating dcc->streams_max_bit_rate when the bit_rate held by the main_channel is larger than it. It is not necessary since we compare those 2 values each time we set the initial bit rate for a stream.
* reds: fix memory leak when core->base.minor_version < 3Yonit Halperin2013-05-081-3/+2
|
* reds: move handle_channel_event logic from main_dispatcher to redsYonit Halperin2013-05-083-9/+19
| | | | | main_dispactcher role is to pass events to the main thread. The logic that handles the event better not be inside main_dispatcher.
* red_worker: fail handle_migrate_data instead of aborting when there is an ↵Yonit Halperin2013-05-081-11/+25
| | | | error during restoration of surfaces
* red_channel: notify and shutdown a channel client when its ↵Yonit Halperin2013-05-081-2/+5
| | | | handle_migrate_data fails
* red_channel: add spice_channel_client_errorYonit Halperin2013-05-081-0/+11
| | | | | | | | spice_channel_client_error prints warning and shutdowns the channel_client that hit the error. This macro is useful for errors that are specific for one session and that are unrecoverable only with respect to this session. Prefer disconnecting a client over aborting when possible.
* red_worker: fix incorrect is_low_bandwidth after migrating a low bandwidth ↵Yonit Halperin2013-05-081-0/+3
| | | | | | | | | | | | | | | connection rhbz#956345 After a spice session has been migrated, we don't retest the network (user experience considerations). Instead, we obtain the is_low_bandwidth flag from the src-server, via the migration data. Before this patch, if we migrated from server s1 to s2 and then to s3, and if the connection to s1 was a low bandwidth one, we erroneously passed is_low_bandwidth=FALSE from s2 to s3. Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
* red_worker: cleanup: add is_low_bandwidth flag to CommonChannelClientYonit Halperin2013-05-081-14/+15
| | | | | | Replace the mixed calls to display_channel_client_is_low_bandwidth and to main_channel_client_is_low_bandwidth, with one flag in CommonChannelClient that is set upon channel creation.
* main_channel: add routine for checking if a network test had been conducted ↵Yonit Halperin2013-05-082-1/+15
| | | | and completed
* red_worker: remove wrong TODOAlon Levy2013-05-051-2/+0
| | | | | | red_create_stream is called even without any client but there is no encoding since the mjpeg encoder is now associated with StreamAgent which is only created when we have a client.
* red_channel: on migration target, start sending ping messages only after the ↵Yonit Halperin2013-05-011-1/+15
| | | | | | | | | | client's migration has completed The connection to the target server is established before migration starts. However, the client reads and replies to messages from the server only after migration completes. Thus, we better not send ping msgs from the target before migration completes (because the observed roundtrip duration will be bigger than the real one).
* red_channel: stop sending ping messages after migration has completedYonit Halperin2013-05-011-0/+5
| | | | | We mustn't send any msg to the client, besides MSG_MIGRATE_DATA, after we send MSG_MIGRATE.
generated by cgit (git 2.34.1) at 2024-04-20 03:09:48 +0000