summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* red_worker: make WORKER_FOREACH_DCC safeUri Lublin2013-07-161-45/+48
| | | | | | | | | | | | | | | | | Specifically, the loop in red_pipes_add_draw can cause spice to abort. In red_worker.c (WORKER_FOREACH_DCC): red_pipes_add_drawable red_pipe_add_drawable red_handle_drawable_surfaces_client_synced red_push_surface_image red_channel_client_push red_channel_client_send red_peer_handle_outgoing reds_stream_writev (if fails -- EPIPE) handler->cb->on_error = red_channel_client_disconnect() red_channel_remove_client() ring_remove() -- of rcc from channel.clients ring.
* red_worker: reuse DCC_FOREACH in WORKER_DCC_FOREACHUri Lublin2013-07-161-7/+4
| | | | The only thing that is needed is to get the channel out of the worker.
* red_worker: use only RCC_FOREACH_SAFEUri Lublin2013-07-161-9/+2
| | | | | | | | | | | RCC_FOREACH may be dangerous The following patches replace FOREACH loops with a SAFE version. Using unsafe loops may cause spice-server to abort (assert fails). Specifically a read/write fail in those loops, may cause the client to disconnect, removing the node currently iterated, which cause spice to abort in ring_next(): -- assertion `pos->next != NULL && pos->prev != NULL' failed
* Use RING_FOREACH_SAFE in red_channel.c functions which are missing itDavid Gibson2013-07-051-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, both red_channel_pipes_add_type() and red_channel_pipes_add_empty_msg() use plaing RING_FOREACH() which is not safe versus removals from the ring within the loop body. Although it's rare, such a removal can occur in both cases. In the case of red_channel_pipes_add_type() we have: red_channel_pipes_add_type() -> red_channel_client_pipe_add_type() -> red_channel_client_push() And in the case of red_channel_client_pipes_add_empty_msg() we have: red_channel_client_pipes_add_empty_msg() -> red_channel_client_pipe_add_empty_msg() -> red_channel_client_push() But red_channel_client_push() can cause a removal from the clients ring if a network error occurs: red_channel_client_push() -> red_channel_client_send() -> red_peer_handle_outgoing() -> handler->cb->on_error callback = red_channel_client_default_peer_on_error() -> red_channel_client_disconnect() -> red_channel_remove_client() -> ring_remove() When this error path does occur, the assertion in RING_FOREACH()'s ring_next() trips, and the process containing the spice server is aborted. i.e. your whole VM dies, as a result of an unfortunately timed network error on the spice channel. Please apply. Signed-off-by: David Gibson <dgibson@redhat.com>
* red_worker: fix for stuck display_channel over WAN (jpeg_enabled=true)Yonit Halperin2013-06-251-0/+4
| | | | | | | | | | | | | | The image descriptor flags shouldn't be copied as is from the flags that were set by the driver. Specifically, the CACHE_ME flag shouldn't be copied, since it is possible that (a) the image won't be cached (b) the image is already cached, but in its lossy version, and we may want to set the bit for CACHE_REPLACE_ME, in order to cache it in its lossless version. In case (b), the client first looks for the CACHE_ME flag, and only if it is not set it looks for CACHE_REPLACE_ME (see canvas_base.c). Since both flags where set, the client ignored REPLACE_ME, and didn't turned off the lossy flag of the cach item. Then, when a request from this lossles item reached the client (FROM_CACHE_LOSSLESS), the client display channel waited endlessly for the lossless version of the image.
* red_worker: improve stream stats readability and ease of parsingYonit Halperin2013-06-242-8/+15
| | | | also added start/end-bit-rate and avg-quality to the final stream stats.
* mjpeg_encoder: add mjpeg_encoder_get_statsYonit Halperin2013-06-242-0/+18
|
* spice: silencing most of the ping/pong loggingYonit Halperin2013-06-241-11/+2
| | | | Those messages are too frequent and don't contribute much
* server: Add support for filtering out agent file-xfer msgs (rhbz#961848)Hans de Goede2013-06-065-7/+37
| | | | Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* red_channel: replace an assert upon threads mismatch with a warningYonit Halperin2013-05-241-3/+25
| | | | | | | | | | | | | | | | | | | | | | | The assert: spice_assert(pthread_equal(pthread_self(), client->thread_id)) and the assert: spice_assert(pthread_equal(pthread_self(), rcc->channel->thread_id)) were coded in order to protect data that is accessed from the main context (red_client and most of the channels), from access by threads of other channels (namely, the display and cursor channels), and vice versa. However, some of the calls to the sound channel interface, and also the char_device interface, can be done from the vcpu thread. It doesn't endanger these channels internal data, since qemu use global mutex for the vcpu and io threads. Thus, pthread_self() can be != channel->thread_id, if one of them is the vcpu thread and the other is the io-thread, and we shouldn't assert. Future plans: A more complete and complicated solution would be to manage our own thread for spice-channels, and push input from qemu to this thread, instead of counting on the global mutex of qemu rhbz#823472
* main_channel: fix double release of migration target dataYonit Halperin2013-05-231-0/+2
| | | | | | | If client_migrate_info was called once with cert-host-subject and then again without cert-host-subject, on a third call to client_migrate info, the cert-host-subject from the first call would have been freed for the second time.
* Log actual address spice-server binds toChristophe Fergeau2013-05-191-5/+10
| | | | | | | | | | | It's not always obvious what address spice-server will bind to, in particular when the 'addr' parameter is omitted on QEMU commandline. The decision of what address to bind to is made in reds_init_socket with a call to getaddrinfo. Surprisingly, that function had a call to getnameinfo() already, but it does not seem to be using the result of that call in any way. This commit moves this call after the socket is successfully bound and add a log message to indicate which address it's bound to.
* 0.12.3 releasev0.12.3Alon Levy2013-05-172-2/+20
|
* server/red_parse_qxl: two coding convention pointer cast fixAlon Levy2013-05-171-2/+2
|
* server/dispatchers: initialize stack to 0 for valgrindAlon Levy2013-05-172-5/+5
|
* server/red_dispatcher: close pa hole in RedWorkerMessageDisplayConnect for ↵Alon Levy2013-05-171-2/+2
| | | | valgrind
* server/tests: test_display_width_strideAlon Levy2013-05-174-7/+154
|
* server/red_worker: simplify monitors_config updateAlon Levy2013-05-171-7/+6
|
* server/tests/test_display_base: add missing set_client_capabilities, fix ↵Alon Levy2013-05-171-1/+11
| | | | client_monitors_config signature
* server/red_worker: turn critical (assert) non error into warningAlon Levy2013-05-171-1/+4
| | | | | The situation causing this assert is unknown but it doesn't cause correctness issues with later rendering, and it is causing an abort.
* server/red_worker: s/driver_has_monitors_config/driver_cap_monitors_config/ ↵Alon Levy2013-05-171-5/+7
| | | | (plus small comment)
* red_worker: don't get bit_rate from main_channel_client, if it wasn't ↵Yonit Halperin2013-05-091-12/+30
| | | | | | | | | | | | initialized When setting an initial video stream bit rate, if the bit rate wasn't calculated by main_channel_client, and we don't have estimation from previos streams, use some default values. The patch also removes updating dcc->streams_max_bit_rate when the bit_rate held by the main_channel is larger than it. It is not necessary since we compare those 2 values each time we set the initial bit rate for a stream.
* reds: fix memory leak when core->base.minor_version < 3Yonit Halperin2013-05-081-3/+2
|
* reds: move handle_channel_event logic from main_dispatcher to redsYonit Halperin2013-05-083-9/+19
| | | | | main_dispactcher role is to pass events to the main thread. The logic that handles the event better not be inside main_dispatcher.
* red_worker: fail handle_migrate_data instead of aborting when there is an ↵Yonit Halperin2013-05-081-11/+25
| | | | error during restoration of surfaces
* red_channel: notify and shutdown a channel client when its ↵Yonit Halperin2013-05-081-2/+5
| | | | handle_migrate_data fails
* red_channel: add spice_channel_client_errorYonit Halperin2013-05-081-0/+11
| | | | | | | | spice_channel_client_error prints warning and shutdowns the channel_client that hit the error. This macro is useful for errors that are specific for one session and that are unrecoverable only with respect to this session. Prefer disconnecting a client over aborting when possible.
* red_worker: fix incorrect is_low_bandwidth after migrating a low bandwidth ↵Yonit Halperin2013-05-081-0/+3
| | | | | | | | | | | | | | | connection rhbz#956345 After a spice session has been migrated, we don't retest the network (user experience considerations). Instead, we obtain the is_low_bandwidth flag from the src-server, via the migration data. Before this patch, if we migrated from server s1 to s2 and then to s3, and if the connection to s1 was a low bandwidth one, we erroneously passed is_low_bandwidth=FALSE from s2 to s3. Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
* red_worker: cleanup: add is_low_bandwidth flag to CommonChannelClientYonit Halperin2013-05-081-14/+15
| | | | | | Replace the mixed calls to display_channel_client_is_low_bandwidth and to main_channel_client_is_low_bandwidth, with one flag in CommonChannelClient that is set upon channel creation.
* main_channel: add routine for checking if a network test had been conducted ↵Yonit Halperin2013-05-082-1/+15
| | | | and completed
* red_worker: remove wrong TODOAlon Levy2013-05-051-2/+0
| | | | | | red_create_stream is called even without any client but there is no encoding since the mjpeg encoder is now associated with StreamAgent which is only created when we have a client.
* red_channel: on migration target, start sending ping messages only after the ↵Yonit Halperin2013-05-011-1/+15
| | | | | | | | | | client's migration has completed The connection to the target server is established before migration starts. However, the client reads and replies to messages from the server only after migration completes. Thus, we better not send ping msgs from the target before migration completes (because the observed roundtrip duration will be bigger than the real one).
* red_channel: stop sending ping messages after migration has completedYonit Halperin2013-05-011-0/+5
| | | | | We mustn't send any msg to the client, besides MSG_MIGRATE_DATA, after we send MSG_MIGRATE.
* reds: fix not sending the mm-time after migration when there is no audio ↵Yonit Halperin2013-05-011-4/+14
| | | | | | | | | | | | playback This bug results in the client dropping all the video frames after migration in case that (1) the hosts involved in migration have different mm-time; and that (2) there is no audio playback. This is relvant only for the client that was connected during the migration. rhbz#958276
* red_channel: fix not handling self pipe items in red_channel_client_release_itemYonit Halperin2013-04-301-0/+3
| | | | | | | When a client disconnects, red_channel_client_pipe_clear is called. Releasing pipe items of type == MIGRATE||EMPTY_MSG||PING wasn't handled, and was passed to channel_cbs.release_item. There, an error occured since the pipe items were not recognized.
* server: Add public spice_qxl_driver_unload methodHans de Goede2013-04-246-1/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | With a SPICE_DISPLAY_CAP_MONITORS_CONFIG capable client, the client needs to know what part of the primary to use for each monitor. If the guest driver does not support this, the server sends messages to the client for a single monitor spanning the entire primary. As soon as the guest calls spice_qxl_monitors_config_async once, we set the red_worker driver_has_monitors_config flag and stop doing this. This is a problem when the driver gets unloaded, for example after a reboot or when switching to a text vc with usermode mode-setting under Linux. To reproduce this start a multi-mon capable Linux guest which uses usermode mode-setting and then once X has started switch to a text vc. Note how the client window does not only not resize, if you try to resize it manually you always keep blackborders since the aspect is wrong. This patch is the spice-server side of fixing this, it adds a new spice_qxl_driver_unload method which clears the driver_has_monitors_config flag. The other patch needed to fix this is in qemu, and will calls this new method from qxl_enter_vga_mode. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* red_worker: assign mm_time to vga framesYonit Halperin2013-04-221-4/+9
|
* red_worker: increase the interval limit for stream framesYonit Halperin2013-04-221-1/+1
|
* collect and print video stream statisticsYonit Halperin2013-04-222-1/+77
|
* server/red_worker: add an option to supply the bandwidth via env varYonit Halperin2013-04-221-5/+24
| | | | | SPICE_BIT_RATE can be set for supplying red_worker the available bandwidth (in Mbps).
* server/red_worker.c: use the bit rate of old streams as a start point for ↵Yonit Halperin2013-04-223-1/+22
| | | | | | | | new streams mjpeg_encoder modify the initial bit we supply it, according to the client feedback. If it reaches a bit rate which is higher than the initial one, we use the higher bit rate as the new bit rate estimation.
* red_worker: video streams - adjust client playback latencyYonit Halperin2013-04-221-5/+54
|
* reds: support mm_time latency adjustmentsYonit Halperin2013-04-225-1/+64
| | | | | | | | When there is no audio playback, we set the mm_time in the client to be older than the one in the server by at least the requested latency (the delta is actually bigger, due to the network latency). When there is an audio playback, we adjust the mm_time in the client by adjusting the playback buffer using SPICE_MSG_PLAYBACK_LATENCY.
* snd_worker: support sending SPICE_MSG_PLAYBACK_LATENCYYonit Halperin2013-04-223-0/+46
| | | | also update spice-common submodule
* dispatcher.h: fix - s/#define MAIN_DISPATCHER_H/#define DISPATCHER_HYonit Halperin2013-04-222-3/+4
|
* red_worker: ignoring video frame drops that are not due to pipe congestionYonit Halperin2013-04-221-3/+13
| | | | | | A frame can be dropped if a new frame was added during the same call to red_process_command (we didn't attempt to send the older frame). Such drops are ignored.
* red_worker: notify mjpeg_encoder on server frame dropsYonit Halperin2013-04-221-4/+13
|
* red_worker: support SPICE_MSGC_DISPLAY_STREAM_REPORTYonit Halperin2013-04-223-2/+85
| | | | | | update mjpeg_encoder with reports from the client about the playback quality. The patch also updates the spice-common submodule.
* red_worker: start using mjpeg_encoder rate control capabilitiesYonit Halperin2013-04-223-59/+68
| | | | | | | | | | This patch only employs setting the stream parameters based on the initial given bit-rate, the latency, and the encoding size. Later patches will also employ mjpeg_encoder response to client reports, and its control over frame drops. The patch also removes old stream bit rate calculations that weren't used.
* server/red_worker: enable latency monitoring in the display channelYonit Halperin2013-04-221-1/+4
|
generated by cgit (git 2.34.1) at 2024-06-21 03:07:47 +0000