| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
qemu can call spice_server_set_name(s, NULL) when the name is not
given. Let's not crash in this case
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add spice_server_set_name() and spice_server_set_uuid() that allows
the client to identify a Spice server (useful to associate settings
with a particular server)
The SPICE_MSG_MAIN_NAME and SPICE_MSG_MAIN_UUID messages are only sent
to capable clients, announcing SPICE_MAIN_CAP_NAME_AND_UUID.
Conflicts:
spice-protocol
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simplify keeping count of self_bitmap_image by putting it in
RedDrawable. It is allocated on reading from the command pipe and
deallocated when the last reference to the RedDrawable is dropped,
instead of keeping track of it in GlzDrawable and Drawable.
(cherry picked from commit 05f4276cc128c500cd88df13e44b4bff7d5d0937)
Conflicts:
server/red_worker.c
Over s/ASSERT/spice_assert/
|
|
|
|
| |
(cherry picked from commit cc1fd8eae7a126d9320c4432eb6ebc54b1ffc201)
|
|
|
|
|
|
| |
whitespace line removed
(cherry picked from commit c6bb40947febf651706a0cd804bb2a8096574ea7)
|
|
|
|
|
|
|
|
|
| |
(cherry picked from commit 96bfcea9659cebb5b121d1472bde045add3ee491)
Conflicts:
server/red_worker.c
s/ASSERT/spice_assert/
|
|
|
|
|
|
|
|
|
|
|
| |
(later add a local drawable)
(cherry picked from commit bab771c10dfa1cc5751f4fd33548b997f7200dbd)
Conflicts:
server/red_worker.c
s/ASSERT/spice_assert/
|
|
|
|
| |
(cherry picked from commit c8cefd4a8f28bde14b70a72272c0ccb80c77af04)
|
|
|
|
|
| |
RHBZ: 808936
(cherry picked from commit 6935bd3d604288a64f491e4226f3d31aafdbf81e)
|
|
|
|
|
|
| |
times out the display channel freakily fast.
(cherry picked from commit 8d3ebe31ddb4004a4aa794bc1da444573a9914f8)
|
|
|
|
|
|
| |
It should have been the allocated size and not the occupied one.
This led to a lot of unnecessary allocations and deallocations.
(cherry picked from commit c211774422455802299545b19ffdffd9496fdc31)
|
|
|
|
|
|
| |
each frame
(cherry picked from commit fecc1e3d4d3d93ade71a318ad655e85974638162)
|
|
|
|
|
|
|
| |
RHBZ: 819484
Signed-off-by: Alon Levy <alevy@redhat.com>
(cherry picked from commit ce8e865cf1fcd7ee6ef2e6f8b33506df31e3345e)
|
|
|
|
|
|
| |
assumption that unsigned long == QXLPHYSICAL causes get_virt to compute
the wrong slot. Fix by replacing addr variables to be of type
QXLPHYSICAL.
|
| |
|
|
|
|
|
| |
Cannot assume unsigned long == QXLPHYSICAL, not true for 32 bit
architectures.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cb_get_virt and cb_validate_virt have disappeared a long time ago,
not needed since:
commit 5ac88aa79fa6445f96e5419d8bf4fce81da63b90
Author: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu Jul 1 17:55:33 2010 +0200
Properly parse QXLImage to the new-world SpiceImage
SpiceImage now replaces RedImage and has all image types in it.
All image data are now chunked (and as such not copied when demarshalling).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MSDN says the following about SetClipboardViewer(): "If an error occurs or there
are no other windows in the clipboard viewer chain, the return value is NULL".
Seems like the buggy case was "no other windows in the clipboard viewer chain",
which explains the 3rd party clipboard manager workaround detailed in the bug
description.
It also seems like SetClipboardViewer() does not clear the error state on
succcess. Calling SetLastError(0) before SetClipboardViewer() seems to solves
this issue.
Since we could not reproduce the bug on our env, the customer has verified on
several of their systems that a private build resolved the issue.
|
|
|
|
|
|
|
|
| |
Add support for sending volume keys scancodes to the guest
RHBZ #552539
Signed-off-by: Yonit Halperin <yhalperi@redhat.com>
(cherry picked from commit d2cd7b2b020da1dc7efe778ddfc4525e31784dbb)
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for sending volume keys scancodes to the guest
RHBZ #552539
A good reference for mapping keymaps to scancodes can be found in
spice-gtk/gtk/keymaps.csv
Signed-off-by: Yonit Halperin <yhalperi@redhat.com>
(cherry picked from commit 68cdc5488da1a008fa4e8a4447b85aa8ac9c2735)
|
|
|
|
|
|
|
| |
The addition of smartcard control to the controller doesn't handle
the case when smartcard support is disabled at compile time. When
this is the case, this causes compile errors.
(cherry picked from commit a50619e7334ff3620034a8b2ea75ceeffd4a805a)
|
| |
|
|
|
|
| |
client test
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
fixes rhbz 790749 use after free of SpiceChannelEventInfo.
The lifetime of the SpiceChannelEventInfo was that of RedsStream, but it
is used by main_dispatcher_handle_channel_event after the RedsStream is
freed for the cursor and display channels. Making SCEI allocation be at
RedsStream allocation, and deallocation after the DESTROY event is
processed by core->channel_event, fixes use after free.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
spicevmc calls red_channel_client_destroy() on the rcc when it disconnects
since we don't want to delay the destroy until the session gets closed as
spicevmc channels can be opened, closed and opened again during a single
session.
This causes red_channel_client_destroy() to get called twice, triggering
an assert, when a connected channel gets destroyed.
This was fixed with commit ffc4de01e6f9ea0676f17b10e45a137d7e15d6ac for
the case where: a spicevmc channel was open on client disconnected, and
the main channel disconnect gets handled first.
But the channel can also be destroyed when the chardev gets unregistered
with the spice-server. This path still triggers the assert.
This patch fixes this by adding a destroying flag to the rcc struct, and
also moves the previous fix over to the same, more clean, method of
detecting this special case.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
RHBZ #788444
CC: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Yonit Halperin <yhalperi@redhat.com>
(cherry picked from commit 5868c99da65610898202a5cc896e36e4835b5b87)
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| | |
These turn into errors because of our -Werror use, breaking the build.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
| |
| |
| |
| | |
Signed-off-by: Alon Levy <alevy@redhat.com>
|
| |
| |
| |
| | |
Signed-off-by: Alon Levy <alevy@redhat.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This matches what we do in client/Makefile.am to actually run the
python scripts, which is to use the python binary we find first,
preferring 'python2' over 'python'. This makes the compile work on odd
systems such as Arch Linux where the python binary is actually python3.
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
There is no more usage of epoll on the client side, so no need to
include these header files.
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
dc7855967f4e did this for the TCP_NODELAY and IP_TOS calls; we should do
it for priority as well if necessary.
We also #ifdef the setting of the low-level socket priority based on
whether we have a definition of SO_PRIORITY available. This option is
not available on Illumos/Solaris platforms; however, since we set IP_TOS
anyway it is not a big deal to omit it here.
|
| |
| |
| |
| |
| |
| |
| |
| | |
output to send a SIGIO signal to the running program. However, we don't
handle this signal anywhere in the code, so setting the option is
unnecessary.
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
|
| |
| |
| |
| | |
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
This ensures all line lengths are down below 100 characters as well as
removing some trailing spaces.
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These are all existing errors; fix them so they don't block future
commits in this file unnecessarily.
error (1): length @ server/main_channel.c +369
error (2): length @ server/main_channel.c +444
error (3): length @ server/main_channel.c +764
error (4): length @ server/main_channel.c +932
error (5): length @ server/main_channel.c +1044
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
|
| |
| |
| |
| | |
removed vdi_port
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With Daniel P. Berrange's patches to allow use of pre-supplied fd's
as channels, we can no longer be sure that our connections are TCP
sockets, so it makes no sense to complain if a TCP/IP specific
setsockopt fails with an errno of ENOTSUP.
Note that this extends Daniel's commit 492ddb5d1d595e2d12208f4602b18e4432f4e6b4
which already added the same check to server/inputs_channel.c
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|\| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The 'make syntax-check' target is used to perform various code
style sanity checks, as well as to detect certain trivial error
patterns. The target is placed in GNUmakefile, instead of Makefile.am
since it relies on GNU specific make extensions.
The actual GNUmakefile and maint.mk files are taken from the
GNULIB project, unchanged
The cfg.mk file is used to configure which of the syntax checks
are activated, to allow addition of new project specific syntax
checks, and to blacklist certain files which should not be checked
* .mailmap: Add mapping for various broken email addrs in
commit log, to stop complaints about AUTHORS file missing
entries
* GNUmakefile: define the 'syntax-check' rule
* maint.mk: definition of standard syntax checks
* cfg.mk: configuration for checks
|
| | |
|
| |
| |
| |
| |
| | |
The '-a' and '-o' operators to test are not portable. Always
combine two invocations of 'test' using || or && instead.
|
| |
| |
| |
| | |
Not all files were including config.h
|