diff options
| author | Daniel P. Berrange <berrange@redhat.com> | 2012-03-13 15:28:26 +0000 |
|---|---|---|
| committer | Daniel P. Berrange <berrange@redhat.com> | 2012-04-25 09:42:11 +0100 |
| commit | 6a8b7585e2051baa911b665ed713835bc65515d6 (patch) | |
| tree | 348a1d418b42a4565c96b9f183b8be451c5d7468 /server/red_worker.c | |
| parent | 832a98800d7ec97796eec3697e00e81f92a07898 (diff) | |
| download | spice-6a8b7585e2051baa911b665ed713835bc65515d6.tar.gz spice-6a8b7585e2051baa911b665ed713835bc65515d6.tar.xz spice-6a8b7585e2051baa911b665ed713835bc65515d6.zip | |
Fix multiple printf format problems
All printf var-args style methods should be annotation with
their format. All format strings must be const strings.
* client/application.cpp, client/cmd_line_parser.cpp,
client/hot_keys.cpp: Avoid non-const format
* client/client_net_socket.cpp: Fix broken format specifier
* client/red_peer.cpp: Fix missing format specifier
* client/platform.h: Add SPICE_GNUC_PRINTF annotation to term_printf
* client/utils.h: Add SPICE_GNUC_PRINTF annotation to string_printf
* server/glz_encoder_config.h, server/red_worker.c: Add
SPICE_GNUC_PRINTF annotation to warning callbacks
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Diffstat (limited to 'server/red_worker.c')
| -rw-r--r-- | server/red_worker.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/server/red_worker.c b/server/red_worker.c index 3bb7d3ef..1a0438ea 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -5274,7 +5274,7 @@ static int red_display_free_some_independent_glz_drawables(DisplayChannelClient /****************************************************** * Encoders callbacks *******************************************************/ -static void quic_usr_error(QuicUsrContext *usr, const char *fmt, ...) +static SPICE_GNUC_PRINTF(2, 3) void quic_usr_error(QuicUsrContext *usr, const char *fmt, ...) { EncoderData *usr_data = &(((QuicData *)usr)->data); va_list ap; @@ -5287,7 +5287,7 @@ static void quic_usr_error(QuicUsrContext *usr, const char *fmt, ...) longjmp(usr_data->jmp_env, 1); } -static void lz_usr_error(LzUsrContext *usr, const char *fmt, ...) +static SPICE_GNUC_PRINTF(2, 3) void lz_usr_error(LzUsrContext *usr, const char *fmt, ...) { EncoderData *usr_data = &(((LzData *)usr)->data); va_list ap; @@ -5300,7 +5300,7 @@ static void lz_usr_error(LzUsrContext *usr, const char *fmt, ...) longjmp(usr_data->jmp_env, 1); } -static void glz_usr_error(GlzEncoderUsrContext *usr, const char *fmt, ...) +static SPICE_GNUC_PRINTF(2, 3) void glz_usr_error(GlzEncoderUsrContext *usr, const char *fmt, ...) { EncoderData *usr_data = &(((GlzData *)usr)->data); va_list ap; @@ -5315,7 +5315,7 @@ static void glz_usr_error(GlzEncoderUsrContext *usr, const char *fmt, ...) // and the client } -static void quic_usr_warn(QuicUsrContext *usr, const char *fmt, ...) +static SPICE_GNUC_PRINTF(2, 3) void quic_usr_warn(QuicUsrContext *usr, const char *fmt, ...) { EncoderData *usr_data = &(((QuicData *)usr)->data); va_list ap; @@ -5326,7 +5326,7 @@ static void quic_usr_warn(QuicUsrContext *usr, const char *fmt, ...) spice_printerr("%s", usr_data->message_buf); } -static void lz_usr_warn(LzUsrContext *usr, const char *fmt, ...) +static SPICE_GNUC_PRINTF(2, 3) void lz_usr_warn(LzUsrContext *usr, const char *fmt, ...) { EncoderData *usr_data = &(((LzData *)usr)->data); va_list ap; @@ -5337,7 +5337,7 @@ static void lz_usr_warn(LzUsrContext *usr, const char *fmt, ...) spice_printerr("%s", usr_data->message_buf); } -static void glz_usr_warn(GlzEncoderUsrContext *usr, const char *fmt, ...) +static SPICE_GNUC_PRINTF(2, 3) void glz_usr_warn(GlzEncoderUsrContext *usr, const char *fmt, ...) { EncoderData *usr_data = &(((GlzData *)usr)->data); va_list ap; |