diff options
| author | Yonit Halperin <yhalperi@redhat.com> | 2011-06-15 17:21:02 +0300 |
|---|---|---|
| committer | Alon Levy <alevy@redhat.com> | 2011-07-21 15:09:28 +0300 |
| commit | e22354141e6b2cfdc71380e0815ff52d7f5131f6 (patch) | |
| tree | de35f537bd9ae6730139cc9c2930de60c3d54b96 /server/red_worker.c | |
| parent | ec6198218a8280f3b5cd800c840ad30b41eff433 (diff) | |
| download | spice-e22354141e6b2cfdc71380e0815ff52d7f5131f6.tar.gz spice-e22354141e6b2cfdc71380e0815ff52d7f5131f6.tar.xz spice-e22354141e6b2cfdc71380e0815ff52d7f5131f6.zip | |
server: add missing calls to red_handle_drawable_surfaces_client_synced
red_handle_drawable_surfaces_client_synced was called only from red_pipe_add_drawable, while it
should also be called from red_pipe_add_drawable_after. Otherwise, the client
might receive a command with a reference to a surface it doesn't hold and crash.
Diffstat (limited to 'server/red_worker.c')
| -rw-r--r-- | server/red_worker.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/server/red_worker.c b/server/red_worker.c index f62db9f7..72bdc31c 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1258,6 +1258,7 @@ static inline void red_pipe_add_drawable_to_tail(RedWorker *worker, Drawable *dr if (!worker->display_channel) { return; } + red_handle_drawable_surfaces_client_synced(worker, drawable); drawable->refs++; red_pipe_add_tail(&worker->display_channel->base, &drawable->pipe_item); } @@ -1273,6 +1274,7 @@ static inline void red_pipe_add_drawable_after(RedWorker *worker, Drawable *draw red_pipe_add_drawable(worker, drawable); return; } + red_handle_drawable_surfaces_client_synced(worker, drawable); drawable->refs++; red_pipe_add_after(&worker->display_channel->base, &drawable->pipe_item, &pos_after->pipe_item); } |