summaryrefslogtreecommitdiffstats
path: root/client/screen.cpp
diff options
context:
space:
mode:
authorYonit Halperin <yhalperi@redhat.com>2011-05-26 17:20:19 +0300
committerYonit Halperin <yhalperi@redhat.com>2011-06-14 10:15:41 +0300
commit8131249d6cabadfa94f2c251e5cfec204b190ae1 (patch)
tree844ed9d247dbb37259211159d4e7c37e1c690973 /client/screen.cpp
parentd1a1a1b4c71791fdb27467be6a3bb451846ee26d (diff)
downloadspice-8131249d6cabadfa94f2c251e5cfec204b190ae1.tar.gz
spice-8131249d6cabadfa94f2c251e5cfec204b190ae1.tar.xz
spice-8131249d6cabadfa94f2c251e5cfec204b190ae1.zip
client: fix for redundant shift+f11 RHBZ #674532
After shift+F11, both in Windows 7 and xp clients, WM_KEYUP events were missing for SHIFT and F11. For F11 it was less important since unpress_all was preformed for all keys. However, we perform sync for all the keyboard modifiers and the GetKeyboardState returns "down" for shift. In windows7 client, we sometimes received afterwards a F11 KEYDOWN event repetition, and this caused SHIFT+F11 to be called again. Not performing hiding of the windows while changing client resolutions, solved the problem of missing events, and I don't see any difference in how spice looks while toggling to full screen. Using GetAsyncKeyState, returns "UP" for shift in windows 7, and helps avoid performing shift+f11 again, if there is an F11 repetition before we receive the KEYUP event for shift.
Diffstat (limited to 'client/screen.cpp')
-rw-r--r--client/screen.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/client/screen.cpp b/client/screen.cpp
index f17a0ba2..7259ed4b 100644
--- a/client/screen.cpp
+++ b/client/screen.cpp
@@ -830,7 +830,11 @@ void RedScreen::show_full_screen()
return;
}
RecurciveLock lock(_update_lock);
+#ifndef WIN32
+ /* performing hide during resolution changes resulted in
+ missing WM_KEYUP events */
hide();
+#endif
save_position();
_full_screen = true;
__show_full_screen();