Fix multiple printf format problems

All printf var-args style methods should be annotation with
their format. All format strings must be const strings.

* client/application.cpp, client/cmd_line_parser.cpp,
  client/hot_keys.cpp: Avoid non-const format
* client/client_net_socket.cpp: Fix broken format specifier
* client/red_peer.cpp: Fix missing format specifier
* client/platform.h: Add SPICE_GNUC_PRINTF annotation to term_printf
* client/utils.h: Add SPICE_GNUC_PRINTF annotation to string_printf
* server/glz_encoder_config.h, server/red_worker.c: Add
  SPICE_GNUC_PRINTF annotation to warning callbacks

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

1 files changed, 1 insertions, 3 deletions

diff --git a/client/hot_keys.cpp b/client/hot_keys.cpp
index 2d0b9db4..763ba2ca 100644
--- a/client/hot_keys.cpp
+++ b/client/hot_keys.cpp
@@ -139,9 +139,7 @@ void HotKeysParser::add_hotkey(const std::string& hotkey, const CommandsMap& com
     std::string command_name = hotkey.substr(0, key_start);
 
     if (commands_map.find(command_name) == commands_map.end()) {
-        char buf[1000];
-        snprintf(buf, sizeof(buf), "invalid action bname %s", command_name.c_str());
-        THROW(buf);
+        THROW("invalid action bname %s", command_name.c_str());
     }
     int command_id = commands_map.find(command_name)->second;
     std::string keys = hotkey.substr(key_start + 1);