Fix multiple printf format problems

All printf var-args style methods should be annotation with
their format. All format strings must be const strings.

* client/application.cpp, client/cmd_line_parser.cpp,
  client/hot_keys.cpp: Avoid non-const format
* client/client_net_socket.cpp: Fix broken format specifier
* client/red_peer.cpp: Fix missing format specifier
* client/platform.h: Add SPICE_GNUC_PRINTF annotation to term_printf
* client/utils.h: Add SPICE_GNUC_PRINTF annotation to string_printf
* server/glz_encoder_config.h, server/red_worker.c: Add
  SPICE_GNUC_PRINTF annotation to warning callbacks

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/client/client_net_socket.cpp b/client/client_net_socket.cpp
index e9f1e770..9df68014 100644
--- a/client/client_net_socket.cpp
+++ b/client/client_net_socket.cpp
@@ -147,7 +147,7 @@ void ClientNetSocket::push_send(SendBuffer& buf)
     }
 
     if (_fin_pending || _close_pending) {
-        THROW("%s: unexpected send attempt for connection_id=% - shutdown send pending",
+        THROW("%s: unexpected send attempt for connection_id=%d - shutdown send pending",
               __FUNCTION__, _id);
     }