diff options
author | Christophe Fergeau <cfergeau@redhat.com> | 2011-07-04 14:27:11 +0200 |
---|---|---|
committer | Christophe Fergeau <cfergeau@redhat.com> | 2011-07-18 18:15:40 +0200 |
commit | c4d6f9791a7c5664843ad08bbb674b96d6dee594 (patch) | |
tree | 150d4f403a392816cdb79833e7a08a289e308f27 /COPYING | |
parent | 082431ba8dbdbf990a146e7109876d6318f0f7b9 (diff) | |
download | spice-c4d6f9791a7c5664843ad08bbb674b96d6dee594.tar.gz spice-c4d6f9791a7c5664843ad08bbb674b96d6dee594.tar.xz spice-c4d6f9791a7c5664843ad08bbb674b96d6dee594.zip |
Fix spice-server/qemu channel version checks
When qemu creates a channel, reds.c contains code to check the
minor/major channel versions known to QEMU (ie the ones that were
current in spice-server when QEMU was compiled) and to compare these
versions against the current ones the currently installed spice-server
version.
According to kraxel [1], the rules for these interface numbers are:
"The purpose of the versions is exactly to avoid the need for a new
soname. The rules are basically:
(1) You add stuff to the interface, strictly append-only to not break
binary compatibility.
(2) You bump the minor version of the interface.
(3) You check the minor version at runtime to figure whenever the
added fields contain valid stuff or not.
An example is here (core interface, minor goes from 2 to 3, new
channel_event callback):
http://cgit.freedesktop.org/spice/spice/commit/?id=97f33fa86aa6edd25111b173dc0d9599ac29f879
"
The code currently refuses to create a channel if QEMU minor version is
less than the current spice-server version. This does not correspond
to the intended behaviour, this patch changes to fail is qemu was compiled
with a spice-server that is *newer* than the one currently installed. This
case is something we cannot support nicely.
[1] http://lists.freedesktop.org/archives/spice-devel/2011-July/004440.html
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions