spice.git, branch 0.8 Spice client: fix two narrowing conversion c++-11 warnings 2012-03-14T14:51:51+00:00 Alon Levy alevy@redhat.com 2012-03-14T14:51:51+00:00 da1b0ee3d267a611f950f3122aa513fce689506a Warnings are from initializing members of type int from uint32_t. Fix is to change alt_image and red_icon height and width fields to ints. Example warning fixed: res.cpp:58:1: error: narrowing conversion of ‘_red_icon.<anonymous struct>::width’ from ‘const uint32_t {aka const unsigned int}’ to ‘int’ inside { } is ill-formed in C++11 [-Werror=narrowing] Signed-off-by: Alon Levy <alevy@redhat.com> 
Warnings are from initializing members of type int from uint32_t. Fix is
to change alt_image and red_icon height and width fields to ints.

Example warning fixed:
 res.cpp:58:1: error: narrowing conversion of ‘_red_icon.<anonymous
 struct>::width’ from ‘const uint32_t {aka const unsigned int}’ to ‘int’
 inside { } is ill-formed in C++11 [-Werror=narrowing]

Signed-off-by: Alon Levy <alevy@redhat.com>
client/windows: fix SetClipboardViewer error handling rhbz#786554 2012-03-01T12:18:57+00:00 Arnon Gilboa agilboa@redhat.com 2012-03-01T11:06:24+00:00 30f347e41ae768745d6ccb6711f1ca46ebfbe045 MSDN says the following about SetClipboardViewer(): "If an error occurs or there are no other windows in the clipboard viewer chain, the return value is NULL". Seems like the buggy case was "no other windows in the clipboard viewer chain", which explains the 3rd party clipboard manager workaround detailed in the bug description. It also seems like SetClipboardViewer() does not clear the error state on succcess. Calling SetLastError(0) before SetClipboardViewer() seems to solves this issue. Since we could not reproduce the bug on our env, the customer has verified on several of their systems that a private build resolved the issue. 
MSDN says the following about SetClipboardViewer(): "If an error occurs or there
are no other windows in the clipboard viewer chain, the return value is NULL".
Seems like the buggy case was "no other windows in the clipboard viewer chain",
which explains the 3rd party clipboard manager workaround detailed in the bug
description.

It also seems like SetClipboardViewer() does not clear the error state on
succcess. Calling SetLastError(0) before SetClipboardViewer() seems to solves
this issue.

Since we could not reproduce the bug on our env, the customer has verified on
several of their systems that a private build resolved the issue.
client: RedScreen::RedScreen: fix initialization order of _menu_needs_update 2011-12-22T09:43:39+00:00 Uri Lublin uril@redhat.com 2011-12-22T08:51:19+00:00 9d2bd519a33decc7dd54546459a7450aef47fcce Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3 (cherry picked from commit a3a3b34a46f57ce86da444532e1db292638a74cd) 
Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3
(cherry picked from commit a3a3b34a46f57ce86da444532e1db292638a74cd)
client: foreign-menu: pass "active" param when creating a ForeignMenu (#769020) 2011-12-21T11:05:12+00:00 Uri Lublin uril@redhat.com 2011-12-13T15:09:58+00:00 df17a852fa23ab2bb47038313eda78f6614dd7f0 The default stays the same -- false. A race could prevent setting ForeignMenu::_active correctly. That happened when Application::on_app_activated was called before _foriegn_menu was created. When foriegn_menu was created its _active defaults to false, and that has not changed, until focus was taken out and back in spice-client window. This caused usbrdr to sometimes not auto-share devices, unless the user switched focus to a different application and back to spicec. The fix updates ForiegnMenu::_active upon creation. (cherry picked from commit fdcef173645e564be71f1b73d476c0716e91663d) 
The default stays the same -- false.

A race could prevent setting ForeignMenu::_active correctly.
That happened when Application::on_app_activated was called before
_foriegn_menu was created. When foriegn_menu was created its
_active defaults to false, and that has not changed, until focus
was taken out and back in spice-client window.

This caused usbrdr to sometimes not auto-share devices, unless
the user switched focus to a different application and back to
spicec.

The fix updates ForiegnMenu::_active upon creation.
(cherry picked from commit fdcef173645e564be71f1b73d476c0716e91663d)
client: update menu if needed when exiting full-screen mode (#758260) 2011-12-21T11:05:04+00:00 Uri Lublin uril@redhat.com 2011-12-20T12:46:50+00:00 7d8cc134bf0b2175cae69c08bfe07b859d45a306 (cherry picked from commit a91b0b3ff712eb2a7d91a951f2af7842495357c3) 
(cherry picked from commit a91b0b3ff712eb2a7d91a951f2af7842495357c3)
client: menu: make RedWindow::set_menu() return an error-code (#758260) 2011-12-21T11:04:01+00:00 Uri Lublin uril@redhat.com 2011-12-20T14:36:13+00:00 67e785f4fc853985ae968b44280c8985651e41ac RedWindow::set_menu() can fail (on Windows when in fullscreen mode). For Windows spice-client, when in fullscreen mode, the system-menu is NULL. Returns 0 upon success, non-0 (currently only -1) upon failure. (cherry picked from commit 24d5852611c3d5be3ba824af64cd5a3356b82b9c) (seperator vs separator --> a small typo that got fixed) 
RedWindow::set_menu() can fail (on Windows when in fullscreen mode).
For Windows spice-client, when in fullscreen mode, the system-menu
is NULL.

Returns 0 upon success, non-0 (currently only -1) upon failure.

(cherry picked from commit 24d5852611c3d5be3ba824af64cd5a3356b82b9c)
(seperator vs separator --> a small typo that got fixed)
client controller/foreign_menu: use memmove instead of memcpy in readers 2011-12-21T10:58:07+00:00 Uri Lublin uril@redhat.com 2011-12-06T13:36:38+00:00 baa375e8b51de94ee44466fe416202c29ea43e23 When src/dst memory areas may overlap, it's safer to use memmove. (cherry picked from commit 5d28d1662e6e415367bb283d051e0a690a8ec2f2) 
When src/dst memory areas may overlap, it's safer to use memmove.
(cherry picked from commit 5d28d1662e6e415367bb283d051e0a690a8ec2f2)
client: handle the redundant right ctrl windows' message send when a alt-gr is pressed bz#709074 2011-11-24T16:31:07+00:00 Gal Hammer ghammer@redhat.com 2011-11-14T10:51:39+00:00 1f2d55b38b7a0628c20385f306533f4e6bd66d7f Hello, The second patch check to see if Windows is sending a fake VK_CONTROL message when the user pressed Alt-Gr when using a non-US keyboard layout (German, Czech, etc...). If the function is_fake_ctrl return true and key event is translated to a REDKEY_INVALID and the event is discarded. Gal. (cherry picked from commit 9ffa2e9990dc5d5ae61c227d10d5234753c08402) 
Hello,

The second patch check to see if Windows is sending a fake VK_CONTROL
message when the user pressed Alt-Gr when using a non-US keyboard layout
(German, Czech, etc...).

If the function is_fake_ctrl return true and key event is translated to
a REDKEY_INVALID and the event is discarded.

     Gal.
(cherry picked from commit 9ffa2e9990dc5d5ae61c227d10d5234753c08402)
client: handle the redundant right ctrl windows' message send when a alt-gr is pressed bz#709074 2011-11-24T16:31:04+00:00 Gal Hammer ghammer@redhat.com 2011-11-14T10:51:33+00:00 66f611bccf865701a26967c6c9ceef4cd130b04d Hello, I first updated the translate_key function. It now requires the windows message as parameter (will be used later). It also use the raw wparam and lparam parameters in order to remove the code duplication when calling the function. Gal. (cherry picked from commit 33be8633f5712062752efe75adc745130a72c4c2) 
Hello,

I first updated the translate_key function. It now requires the windows
message as parameter (will be used later). It also use the raw wparam
and lparam parameters in order to remove the code duplication when
calling the function.

     Gal.
(cherry picked from commit 33be8633f5712062752efe75adc745130a72c4c2)
client: add xinerama support 2011-11-13T12:43:42+00:00 Arnon Gilboa agilboa@redhat.com 2009-11-26T11:22:27+00:00 39ea97ce6082aaefb73f401c7d65a7d9b75323d7 RHEL-6 Bugzilla: 695323 cherry-picked from qspice commit 003667ac99beeec9b330a07bc3569c59a96d4588 which fixes RHEL-5 541566 with merge of the one line qspice fix to SPICE_REQUIRES: 9f3fe4755f11044a45c4b21148466a997fcbf735 spice: fixed reference to xinerama pkg config file (Xinerama.pc=>xinerama.pc) Author: Yonit Halperin <yhalperi@redhat.com> (cherry picked from master, commit a30d96faa49bca73f9c6000c4123a8ffb996ee1b) Conflicts: client/Makefile.am 
RHEL-6 Bugzilla: 695323

cherry-picked from qspice commit
 003667ac99beeec9b330a07bc3569c59a96d4588
 which fixes RHEL-5 541566

with merge of the one line qspice fix to SPICE_REQUIRES:
 9f3fe4755f11044a45c4b21148466a997fcbf735
 spice: fixed reference to xinerama pkg config file
 (Xinerama.pc=>xinerama.pc)
 Author: Yonit Halperin <yhalperi@redhat.com>

(cherry picked from master, commit a30d96faa49bca73f9c6000c4123a8ffb996ee1b)

Conflicts:

	client/Makefile.am