diff options
| author | Frediano Ziglio <fziglio@redhat.com> | 2015-07-21 17:45:32 +0100 |
|---|---|---|
| committer | Christophe Fergeau <cfergeau@redhat.com> | 2015-07-23 11:11:03 +0200 |
| commit | 5bad231e80ad6202b1860783cc29093b0457d296 (patch) | |
| tree | 684f2a05cc30612398ba40238e4216fbf8971999 | |
| parent | 4a2a9966749c09465aa85a5fbd19cf7995d06f45 (diff) | |
| download | spice-protocol-5bad231e80ad6202b1860783cc29093b0457d296.tar.gz spice-protocol-5bad231e80ad6202b1860783cc29093b0457d296.tar.xz spice-protocol-5bad231e80ad6202b1860783cc29093b0457d296.zip | |
codegen: Simplify if/else blocks
Blocks were mainly the same, this reduces the amount of code.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
| -rw-r--r-- | python_modules/marshal.py | 29 |
1 files changed, 11 insertions, 18 deletions
diff --git a/python_modules/marshal.py b/python_modules/marshal.py index b77b910..1d38d3d 100644 --- a/python_modules/marshal.py +++ b/python_modules/marshal.py @@ -380,25 +380,18 @@ def write_protocol_marshaller(writer, proto, is_server, private_marshallers): writer.ifdef(channel.attributes["ifdef"][0]) writer.header.ifdef(channel.attributes["ifdef"][0]) if is_server: - for m in channel.client_messages: - message = m.message_type - f = write_message_marshaller(writer, message, is_server, private_marshallers) - if channel.has_attr("ifdef") and f not in functions: - functions[f] = channel.attributes["ifdef"][0] - elif message.has_attr("ifdef") and f not in functions: - functions[f] = message.attributes["ifdef"][0] - else: - functions[f] = True + messages = channel.client_messages else: - for m in channel.server_messages: - message = m.message_type - f = write_message_marshaller(writer, message, is_server, private_marshallers) - if channel.has_attr("ifdef") and f not in functions: - functions[f] = channel.attributes["ifdef"][0] - elif message.has_attr("ifdef") and f not in functions: - functions[f] = message.attributes["ifdef"][0] - else: - functions[f] = True + messages = channel.server_messages + for m in messages: + message = m.message_type + f = write_message_marshaller(writer, message, is_server, private_marshallers) + if channel.has_attr("ifdef") and f not in functions: + functions[f] = channel.attributes["ifdef"][0] + elif message.has_attr("ifdef") and f not in functions: + functions[f] = message.attributes["ifdef"][0] + else: + functions[f] = True if channel.has_attr("ifdef"): writer.endif(channel.attributes["ifdef"][0]) writer.header.endif(channel.attributes["ifdef"][0]) |