| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GNULIB has a helpful module 'manywarnings' which makes it easy
to turn on every single GCC warning. The general goal is that
every possible GCC warning should be enabled, except for certain
blacklisted warnings.
This imports the GNULIB m4 macros, and updates configure.ac to
use this new capability. As & when new GCC warnings are created,
the 'manywarnings.m4' can be refreshed from upstream GNULIB
* m4/manywarnings.m4, m4/warnings.m4: GNULIB warning macros
* configure.ac: Remove custom compiler warning checks
* m4/spice-compile-warnings.m4: Decide what GCC warnings to enable
|
|
|
|
| |
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
| |
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
| |
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
| |
When running "./configure --disable-usbredir" the
"USB redirection support" line in the summary at the end of ./configure
would be empty after "support" instead of ending with yes or no.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
| |
Spice protocol contains only headers. We would like to be able to use
a protocol update without having to wait for the release, a git
submodule works well for this purpose.
|
| |
|
|
|
|
|
|
|
|
| |
Unfortunately not all device makers go to the "trouble" of adding device
identification strings to a device's descriptors. This patch makes spice-gtk
translate vid/pid into strings if the device lacks the strings.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
| |
|
|
|
|
|
|
| |
spice-gtk uses usbredirfilter_string_to_rules which is defined
in usbredirparser but does not link with it. This causes link errors
on some distributions. Fixes fdo bug #45761.
|
|
|
|
|
|
|
|
| |
Josh Bressers has been so kind to review the usb-acl-helper for possible
security issues. One of his recomendations was to harden the usb-acl-helper
by building it as a Position Independent Executable.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
configure.ac was using 2 slightly different styles for have_foo tests:
if test x"$have_foo" = "xyes"; then
and:
if test "x$have_foo" = "xyes"; then
Switch to the latter style everywhere for consistency.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
* No need to set AM_CONDITIONAL WITH_POLKIT from the enable_usbredir tests, it
get sets from the enable_polkit tests in all paths
* Improve the help text: mention auto as option, policykit -> PolicyKit,
not yes but auto is the default
* Warn when building with usbredir support but not building the acl helper
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
| |
This check is only added to configure.ac contrary to the pyparsing
patch.
|
|
|
|
|
|
| |
Check both in configure.ac (after checking if we need to rebuild
the marshalling files) and in the python script using pyparsing
(for people modifying .proto files in tarballs)
|
|
|
|
|
|
|
|
| |
GOBJECT_INTROSPECTION_CHECK will alread test for the presence of
gobject-introspection. The PKG_CHECK_MODULES(GOBJECT_INTROSPECTION)
call only needs to set the has_symbol_prefix variable, so we can
use PKG_CHECK_EXISTS here, and let GOBJECT_INTROSPECTION_CHECK do
the rest of the work.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, usb redirection and policykit are enabled by default,
and configure will error out if the required dependencies cannot
be found. This commit changes the default behaviour, by default
usb redirection/policykit support is automatically enabled/disabled
depending on the availability of the needed dependencies. Passing
--enable-usbredir will error out if the dependencies for usb
redirection cannot be found, ditto for policykit. This should make
things nicer for people running configure or autogen.sh with no
argument.
|
|
|
|
|
|
|
|
| |
For some unknown reason, this set DATADIRNAME='share' on Windows,
which is what is expected.
Although some people say only IT_PROG_INTLTOOL is necessary, it gets
the path wrong in this case too.
|
|
|
|
|
|
|
|
|
|
|
| |
Note this patch adds a default filter filtering out HID devices, since
redirecting ie a mouse plugged into a laptop is usually not what the user
wants. Also sometimes usb keyboards/mice may experience a glitch causing
them to temporarily drop of the bus. If this happens when the spice-client
has focussed it used to redirect them to the vm when they re-appeared,
not good!
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new (in usbredir-0.3.2) usbredirhost_open_full()
function allows us to be notified whenever usb packets completing
result in data to be send to the host. This removes the need for using
g_usb_source_set_callback and seeing if there is data to write on
any of the usb channels each time some usb event happens.
This also bumps the minimum needed libusbredirhost version to 0.3.2
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Currently, building vala bindings from a tarball is broken because
spice-client-glib-2.0.deps is missing from the tarball. This commit
adds it to EXTRA_DIST and also makes sure the vala bindings don't
get built/installed unless --enable-vala has been passed to configure.
This means vala must be installed to build the vala bindings from a
tarball. Fixes fdo bug #44000.
|
|
|
|
|
| |
They were work in progress and not meant to be committed, apologies
for the noise :-/
|
|
|
|
|
|
|
|
|
|
|
| |
Disable usbredir, since it wants to install file in /.
Disable vala for distcheck for 2 reasons: not needed after dist and
binding build issue.
Ship with spice-gtk-3.0 vala bindings
https://bugs.freedesktop.org/show_bug.cgi?id=44000
|
|
|
|
|
| |
It's currently installed in $bindir, but this patch makes it possible
for distros like fedora to install it in $libexecdir/spice/
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Mageia is using linker flags and miss symbols when linking.
The error can be reproduced with:
make LDFLAGS="-Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -Wl,-O1 -Wl,--build-id -Wl,--enable-new-dtags"
Based on patch by Christophe Fergeau.
https://bugs.freedesktop.org/show_bug.cgi?id=43416
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
spice-client needs to be able to open the device nodes under /dev/bus/usb
to be able to redirect a usb device to the guest. Normally opening these
nodes is only allowed by root. This patch adds a suid root helper which
asks policykit if it is ok to grant raw usb device access, and if policykit
says it is ok, opens up the acl so that the spice-client can open the device
node.
As soon as spice-client closes the stdin of the helper, the helper removes
the extra rights. This ensures that the acl gets put back to normal even if
the spice client crashes. Normally the spice-client closes stdin directly
after opening the device node.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
| |
|
|
|
|
|
|
| |
This is needed for usbredir support.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
| |
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While working on usb redirection support for spice-gtk I needed some
code to integrate libusb into glib's mainloop amongst other things. I ended
up borrowing code from colord for this. Richard (the colord author) and I
quickly agreed that doing generic glib bindings for libusb is a good idea,
akin to the gudev bindings for libudev we've called our WIP on this gusb:
https://gitorious.org/gusb
Since this very much is a WIP, the API is nowere near stable, so for now
we bundle a copy of this code with spice-gtk. When gusb has an official
release out the door with a stable API we should switch to that.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check for gtk+-win32/gtk+-osx to know when we should define
HAVE_WINDOWS/WITH_DISPLAY_WINDOWS and HAVE_QUARTZ/WITH_DISPLAY_QUARTZ
This is better than the old scheme that blindly tried to detect
libx11, and chose between x11/windows depending on only this
test.
We probably should check that only one of windows/x11/quartz is
enabled at once.
NB: for now the QUARTZ defines are not used since we will be
using a generic GnomeRR backend instead of having our own
OSX backend.
|
|
|
|
|
|
| |
No need to try to detect xrandr or xkb headers when we won't be
doing an X11 build. This is even detrimental on Mac OSX when
we want to attempt a native build but have the xkb headers installed.
|
| |
|
|
|
|
|
| |
Use gtk-x11-[23].0.pc to detect whether we want an x11 build or
not. Don't AC_SUBST X11_CFLAGS and X11_LIBS since they are unused.
|
|
|
|
| |
Gather all x11 related checks in the same place
|
| |
|
| |
|
| |
|