summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* namedpipelistener: do not leak the error messageIgnacio Casal Quinteiro2016-02-231-0/+1
|
* Simplify spice_usb_device_manager_device_to_libdev()Christophe Fergeau2016-02-181-6/+1
| | | | | | The Windows-specific version duplicates some code from spice_usb_device_equal_libdev(), this commit switches to using that helper instead.
* Simplify spice_usb_device_equal_libdev()Christophe Fergeau2016-02-181-9/+4
| | | | | | The Windows-specific version duplicates some code from spice_usb_device_manager_libdev_match(), this commit switches to using that helper instead.
* gtk: add spice-widget GL scanout supportMarc-André Lureau2016-02-166-21/+779
| | | | | | | | | | | | | | | | Hook to spice-glib events to show the GL scanout. The opengl context is created with egl, and is currently x11-only (supporting wayland with bare-egl doesn't seem trivial). Using GtkGLArea is left for a future series, since SpiceDisplay widget is a GtkDrawingArea and can't be replaced without breaking ABI. Furthermore, GtkGLArea won't work on non-egl contexts, so this approach is necessary on gtk+ < 3.16 or X11 (because gdk/x11 uses glx). Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Acked-by: Victor Toso <victortoso@redhat.com> Acked-by: Pavel Grunt <pgrunt@redhat.com>
* glib: add local GL scanout supportMarc-André Lureau2016-02-136-3/+196
| | | | | | | | | | | | | | Add spice-glib support for gl scanout messages. A note about SpiceGlScanout: it is struct with scanout details, registered as a boxed type, with associated gl-scanout property. That way, it doesn't need a seperate signal for change notification and the current scanout can be retrieve with gobject getter. Since boxed property are always duplicated by g_object_get(), an additional spice_display_get_gl_scanout() method returns the current scanout without duplication (that's what spice-gtk display widget will use). Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
* build-sys: check for epoxy-egl supportMarc-André Lureau2016-02-131-0/+26
| | | | | | | The following code requires epoxy with egl support. Check for pkg-config and egl headers. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
* Add spice_channel_unix_read_fd()Marc-André Lureau2016-02-132-0/+71
| | | | | | Utility function used in the messages with socket ancillary fd. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
* build-sys: bump to spice-protocol 0.12.11Marc-André Lureau2016-02-131-1/+1
| | | | | | Needed for GL messages Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
* typo: s/GTask/GSimpleAsyncResultFabiano Fidêncio2016-02-121-1/+1
| | | | | | | | | Seems that I messed up with cd0c1008316e90bce925e1448ffcabb366e88f8f while rebasing my GTask series on top of this patch, causing a build breakage due to non-intentional insertion of a GTask replacing a GSimpleAsyncResult. Acked-by: Pavel Grunt <pgrunt@redhat.com>
* Use #ifdef {HAVE,USE}_FOO instead of #if {HAVE,USE}_FOOFabiano Fidêncio2016-02-127-26/+26
| | | | | | | | | | | | | | | | | | | While "#if USE_FOO" checks for the value of the variable USE_FOO, "#ifdef" checks whether USE_FOO is defined or not. It means, if we had something like: #define USE_FOO 0, we would have: #if USE_FOO /* Any code in here would NOT be compiled */ #endif #ifdef USE_FOO /* Any code in here would be compiled */ #endif No problem was faced on spice-gtk till now because either USE_FOO is not defined or defined as 1, but let's try to have it standardized. Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
* gtk: replace configure-event for size-allocateMarc-André Lureau2016-02-031-7/+4
| | | | | | | | | | For size-allocate, it's simpler to connect to the signal rather than override the default signal handler since there is no automatic chaining to parent handler otherwise. Doing this removes the need to have a window. Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com> Acked-by: Victor Toso <victortoso@redhat.com>
* usb-device-{manager,widget}: Add counter of free channelsFabiano Fidêncio2016-01-222-5/+47
| | | | | | | | | | As the message showed when the last usbredir channel is taken can be a bit confusing, let's add a counter of free channels to the widget's label. In order to add the counter, a new property for SpiceUsbDeviceManager was introduced ("free-channels"). Related: rhbz#1298772
* Remove GSLice usageFabiano Fidêncio2016-01-227-21/+22
| | | | | It's being slowly deprecated in glib https://bugzilla.gnome.org/show_bug.cgi?id=754687
* gstaudio: set output parameter to NULL on errorVictor Toso2016-01-191-0/+4
| | | | | | | | This is not really triggered in the current code but this is usually expected in case of errors; Also, the same function on record side already does this. Acked-by: Jonathon Jongsma <jjongsma@redhat.com>
* build-sys: silence vala deprecated function usage warningsMarc-André Lureau2016-01-141-0/+1
| | | | | | | This silence usage of deprecated glib declarations from vala generated code. Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com> Acked-by: Fabiano Fidêncio <fidencio@redhat.com>
* Update spice-commonMarc-Andre Lureau2016-01-141-0/+0
| | | | | | | | | | | | | | | This is an update to fix build issues with spice-protocol.git. generated_server_demarshallers.c: In function ‘parse_msgc_display_gl_draw_done’: generated_server_demarshallers.c:767:23: error: ‘SpiceMsgcDisplayGlDrawDone’ undeclared (first use in this function) mem_size = sizeof(SpiceMsgcDisplayGlDrawDone); ... Also needed for upcoming gl-scanout messages. Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com> Acked-by: Frediano Ziglio <fziglio@redhat.com>
* channel-main: remove unused header rect.hVictor Toso2016-01-071-1/+0
| | | | | | | It was included in be8ff99571478deb5c8d116134f65ed2b788dbd3 but with no use. Acked-by: Marc-André Lureau <mlureau@redhat.com>
* build-sys: remove xrandrMarc-André Lureau2016-01-042-8/+0
| | | | | | Not needed anymore (probably since gnome-rr was removed in 30986505b) Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
* Grab keyboard based on session focus.snir sheriber2015-12-213-2/+44
| | | | | | | | | | | | | | | | | | | | When using multiple monitors moving mouse between monitors releases keyboard grab. Reproduce bug -Open multiple monitors remote-viewer session -Click on one of the monitors to get focus & keyboard-grab -Move mouse to another monitor and try keyboard command (do not click) At this point all keyboard commands are being executed on the client machine instead of the remote machine I added keyboard_has_focus and mouse_has_pointer variables at the session and now these properties are being tested for the session instead for the current widget (works also when using alt-tab). Resolves: rhbz#1275231 Acked-by: Pavel Grunt <pgrunt@redhat.com>
* ppc: Fix spicy-screenshot colors on BE machinesLukas Venhoda2015-12-211-0/+6
| | | | | | Save screenshot in proper endianess xRGB on LE machine and BGRx on BE machine Acked-by: Pavel Grunt <pgrunt@redhat.com>
* ppc: Fix colors on ppc when using GLZLukas Venhoda2015-12-211-1/+1
| | | | | Fixes color order on PowerPC when using GLZ image compression. Acked-by: Pavel Grunt <pgrunt@redhat.com>
* ppc: Fix message endianessFabiano Fidêncio2015-12-211-24/+37
|
* ppc: Fix header endianessFabiano Fidêncio2015-12-211-10/+10
|
* build-sys: Use sasl check from spice-commonPavel Grunt2015-12-182-45/+2
| | | | | | Support only libsasl2 providing libsasl2.pc file Acked-by: Christophe Fergeau <cfergeau@redhat.com>
* Call spice_marshaller_flush on message writeJavier Celaya2015-12-101-0/+1
| | | | | | | | | spice_marshaller_flush must be called before writing a message to calculate pointer offsets. This is only an issue when ptr submarshallers are used, which currently is only used by Tunnel::service_add. Since this is disabled by default, this buug is not going to be hit by the current codebase.
* gst: Fix typo in preprocessor symbolChristophe Fergeau2015-12-091-2/+2
| | | | | When the GStreamer backend is used, HAVE_GSTAUDIO is defined, not HAVE_GST_AUDIO.
* smartcard: Fix compilation with older libcacardChristophe Fergeau2015-12-092-0/+8
| | | | | | | | e0c2182937 dropped some #include from channel-smartcard.c and spicy.c as they were redundant with the headers already included from spice-common/common/messages.h. While this is true for the newer libcacard.h header, we need to include more headers to support older libcacard, or compilation breaks.
* spice-gtk: Recover from GStreamer audio initialization errorsFrancois Gouget2015-12-091-5/+7
| | | | | | | gst_init() will terminate the program in case of a failure so it's better to use gst_init_check() so we can recover from errors. Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
* build-sys: Warn about missing GStreamer 1.0 audio runtime elementsFrancois Gouget2015-12-081-1/+5
| | | | | | | | Their absence should not be reported as an error since they are not needed for the build, but the developer will need them to test the code so it's appropriate to warn him. Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
* build-sys: Check for GStreamer 1.0 audio with SPICE_CHECK_GSTREAMER()Christophe Fergeau2015-12-081-11/+8
| | | | Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
* build-sys: Allow simultaneous support for Pulse and GStreamer audioFrancois Gouget2015-12-083-40/+46
| | | | | | | | | | Rather than GStreamer/PulseAudio backend being mutually exclusive at compile-time, this commit allows to enable both at the same time. PulseAudio will then be favoured, with a fallback to GStreamer if it's not available. Note that --with-audio is kept for backward compatibility. Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
* Use libcacard.h if possibleMarc-André Lureau2015-12-083-10/+5
| | | | | | Drop unneeded includes (that are already undirectly included). Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
* Remove unmaintained spicy.nsisMarc-André Lureau2015-12-084-236/+3
| | | | | | Remove gtkrc too, and cleanup EXTRA_DIST ($(desktop_in_files) is unused) Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
* Update spice-commonMarc-André Lureau2015-12-081-0/+0
| | | | For new libcacard.h usage
* Fix use after free of uriMarc-André Lureau2015-12-081-1/+1
| | | | | | | | "path" points to "uri" memory, move free(uri) later. Found thanks to valgrind :) Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
* Update spice-common submoduleChristophe Fergeau2015-11-251-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | The next commit is going to use SPICE_WARNING which was added recently to spice-common This submodule update changes: Christophe Fergeau (5): build-sys: Add gio-2.0 to SPICE_CHECK_GLIB2 build-sys: Fix error in SPICE_CHECK_LZ4 description build-sys: Set automake conditional in SPICE_CHECK_SMARTCARD build-sys: Rename SUPPORT_GL to HAVE_GL build-sys: Add missing # to comment Francois Gouget (3): build-sys: Add the SPICE_WARNING() and SPICE_PRINT_MESSAGES m4 macros build-sys: Add SPICE_CHECK_GSTREAMER() build-sys: Add SPICE_CHECK_GSTREAMER_ELEMENTS() Lukas Venhoda (4): ssl-verify: Only check addr length when using IP addr m4: Require glib version >= 2.22 ssl-verify: Changed IPv4 hostname to IPv6 canvas_base: Remove redundant switch case block
* build-sys: Use SPICE_WARNING() to issue the DBus warningFrancois Gouget2015-11-251-3/+3
| | | | Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
* build-sys: Prefix the configure audio GStreamer variables with GSTAUDIO_Francois Gouget2015-11-242-11/+11
| | | | | | | | This lets us avoid naming conflicts when using GStreamer for other purposes. Signed-off-by: Francois Gouget <fgouget@codeweavers.com> Acked-by: Victor Toso <victortoso@redhat.com>
* file transfer: send cancel message when user cancels a transferJay.han2015-11-191-1/+2
| | | | | | | | | When a user cancel's a file transfer, we should send a STATUS_CANCELED message rather than an STATUS_ERROR message. The latter triggers a bug in the vdagent where the file remains opened by the vdagent in the guest and cannot be removed. Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
* Be more specific in the case of authentication errorMarek Kasik2015-11-193-5/+31
| | | | | | | | This patch adds SPICE_CLIENT_ERROR_AUTH_NEEDS_USERNAME error for the case when authentication fails because of missing username. This can happen when GSSAPI method is used. https://bugs.freedesktop.org/show_bug.cgi?id=92994
* spicy: Add support for changing compressionPavel Grunt2015-11-181-0/+63
|
* channel-display: Add spice_display_change_preferred_compressionPavel Grunt2015-11-185-7/+38
|
* Do not export symbol of non-existent functionPavel Grunt2015-11-112-2/+0
|
* file xfer: Fix segfault when rebootingJonathon Jongsma2015-11-101-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Recent changes to file transfer introduced a regression where the client would crash when rebooting a guest after performing a file transfer. This was caused because the SpiceFileTransferTask is freed when it is completed, but is not removed from the MainChannel's hash table. When we reboot the guest and lose our vdagent connection, we iterate through the list of tasks in the hash table and complete them. But since we did not remove the already-completed tasks from this hash table, this hash table contains already-freed memory. To fix the issue, take an extra ref for the async operations (so that completing the task won't free an object that is stored in the hash table). In addition, connect to the task's "finished" signal and remove it from the hash table when it becomes finished. Bug reported via email by Jay.han <ezzzehxx@gmail.com>. Valgrind report below: ==6926== Invalid read of size 8 ==6926== at 0x508177B: spice_file_transfer_task_completed (channel-main.c:2941) ==6926== by 0x50846DC: set_agent_connected (channel-main.c:462) ==6926== by 0x5073A43: spice_channel_recv_msg (spice-channel.c:1892) ==6926== by 0x5073BE3: spice_channel_iterate_read (spice-channel.c:2132) ==6926== by 0x5075D25: spice_channel_coroutine (spice-channel.c:2170) ==6926== by 0x50A6EFE: coroutine_trampoline (coroutine_ucontext.c:63) ==6926== by 0x50A6CC8: continuation_trampoline (continuation.c:55) ==6926== by 0x65C2B5F: ??? (in /lib/x86_64-linux-gnu/libc-2.19.so) ==6926== by 0x151331C7: ??? ==6926== Address 0x29971fd8 is 168 bytes inside a block of size 184 free'd ==6926== at 0x4C2BDEC: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==6926== by 0x5E33142: g_type_free_instance (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4000.0) ==6926== by 0x50815DA: file_xfer_close_cb (channel-main.c:1826) ==6926== by 0x5AEBD5C: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.4000.0) ==6926== by 0x5B0F41A: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.4000.0) ==6926== by 0x5B0F438: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.4000.0) ==6926== by 0x609BCE4: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0) ==6926== by 0x609C047: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0) ==6926== by 0x609C309: g_main_loop_run (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4000.0) ==6926== by 0x4058AB: main (spicy.c:1858)
* build-sys: Remove some dead configure.ac DBus codeFrancois Gouget2015-11-101-4/+0
| | | | | Signed-off-by: Francois Gouget <fgouget@codeweavers.com> Acked-by: Christophe Fergeau <cfergeau@redhat.com>
* spice-gtk: Fix error handling in stream_get_current_frame()Francois Gouget2015-11-041-8/+9
| | | | | | *data must always be set to NULL on error. Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
* channel-usbredir: drop isoc packets on low bandwidthVictor Toso2015-10-303-1/+35
| | | | | | | | | | | | | | | | | | | | When channel wants to send much more data then the wire can handle, the queue grows fast. This patch does not limit the queue growth but introduces an internal API to check if queue size is too big. This internal API is used in usbredir_buffered_output_size_callback which is called before any isoc pacaket is queued in usbredir. The usbredir implements the logic to: - only drop isoc packets - while dropping packtes does still give us video frames from and above 10fps streams An easy way to test locally is sharing and webcam and with tc: tc qdisc add dev lo root netem delay 100ms tc qdisc change dev lo root netem delay 1000ms tc qdisc del dev lo root netem Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1264156
* build-sys: Remove unused conditionalChristophe Fergeau2015-10-231-3/+0
|
* Adjust to spice-common spice-deps.m4 changesChristophe Fergeau2015-10-232-2/+2
| | | | | | | | | | | | | | | | | This commit updates spice-common to latest git master. Since the argument to the SPICE_CHECK_xxx macros is now unused, it's cleaner to remove it. Christophe Fergeau (3): Add marshaller test case build-sys: Use ${PKG_CONFIG} rather than pkg-config build-sys: Rework SPICE_CHECK_* m4 macros Frediano Ziglio (1): common: Fix typo in comment Javier Celaya (1): Fix linearization of several marshallers with one item
* Remove noisy debug statementJonathon Jongsma2015-10-221-1/+0
| | | | | This isn't terribly useful for general debugging and makes the log pretty noisy when transferring large files.
generated by cgit (git 2.34.1) at 2025-09-27 06:18:05 +0000