summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* build-sys: Use SPICE_CHECK_LZ4Christophe Fergeau2015-06-222-12/+1
| | | | | | spice-common now has an m4 macro adding a --enable-lz4 option and doing the needed checks, so we can use it in configure.ac rather than duplicating it here.
* build-sys: Use SPICE_CHECK_SMARTCARDChristophe Fergeau2015-06-221-17/+2
| | | | | | spice-common has an m4 macro adding a --enable-smartcard option and doing the needed checks, so we can use it in configure.ac rather than duplicating it here.
* spicy-*: Remove translation supportChristophe Fergeau2015-06-195-83/+64
| | | | | These are only meant to be test tools so they don't need to be translated.
* spicy: Enable recent chooser on windowsLukas Venhoda2015-06-182-10/+0
| | | | Recent chooser is working correctly in windows.
* spicy: Replace duplicated code with a for loopLukas Venhoda2015-06-181-11/+6
| | | | Changed piece of code working with fixed size array into a for loop.
* spicy: Host and port (or tls) are now requiredLukas Venhoda2015-06-181-5/+27
| | | | | Connect button is now non-sensitive when host and port (or tls) entry is empty. Pressing enter will now also NOT connect, when the entries are empty.
* spicy: Fixed reselecting in recent chooserLukas Venhoda2015-06-181-0/+11
| | | | | | | | | | | | Selecting an entry in the recent connections list, and then modifying the host/port/TLS port, and double-clicking on that same entry in the list would cause spicy to connect to the edited address rather than the one which was picked in the recent chooser. After this commit, the selection will be cleared from the recent chooser, and double-clicking on an entry after editing it will always trigger a 'selection-changed' signal, which will properly set the address to connect to.
* spicy: Changed the dialog into a windowLukas Venhoda2015-06-183-38/+120
| | | | | | | | | Changed connect dialog from GtkDialog to GtkWindow. Added the necessary signals and buttons, to keep then behaviour of a dialog (ESC to close, ENTER to submit). spicy_connect_dialog now returns TRUE and FALSE instead of 0 and -1.
* spicy: Move connect dialog to its own fileLukas Venhoda2015-06-185-125/+176
| | | | | | | | Connect dialog from spicy is now in its own file. Renamed connect_dialog to spicy_connect_dialog. Added new file for translation.
* spice-widget: keypress-delay set by env varVictor Toso2015-06-181-1/+9
|
* Prepare for 0.29 releaseMarc-André Lureau2015-06-151-0/+10
|
* channel: check too long passwordMarc-André Lureau2015-06-151-29/+48
| | | | | Make sure that the password length is under the maximum lenght. If not report it as an authentication failure with an adapted message.
* configure: Try gstreamer audio backend if pulse is not availablePavel Grunt2015-06-151-17/+18
| | | | | Disable audio if no backend is available and configure is used with the option '--with-audio=auto'
* webdav: keep phodav requirements inside USE_PHODAVVictor Toso2015-06-091-0/+4
| | | | | | | | | Commit 33d4016228798108250b0ef9173f2c4c719a5065 uses g_output_stream_write_all_async/finish which is on gio 2.44 version. This breaks the build on older systems even if --disable-webdav is used. Using #USE_PHODAV to wrap those functions that will not be called without --enable-webdav.
* spice-widget: Do not update display when resize-guest is disabledFabiano Fidêncio2015-06-091-4/+0
| | | | | | | | | | Updating the display causes weird behaviors in virt-viewer, like re-resizing to a previous monitor config when, after changing the display resolution (through System > PReferences > Displays). the agent reconnects. It is not perfect yet, because when the agent reconnects the guest resizes to the previous config and switch to the proper one, but this seems more like an agent bug than a spice-gtk one.
* channel: use class private handlers fieldMarc-André Lureau2015-06-084-11/+21
| | | | | | | | | Since spice-gtk requires glib 2.28, we can now fix a small FIXME. Since G_TYPE_CLASS_GET_PRIVATE is a bit expensive, it's still worth to cache it in klass->priv. However, there is no good place I can think of to put this. (channel_class_init() is called only once, and not per each subclass)
* Move gtk/ -> src/Marc-André Lureau2015-06-08155-29/+30
| | | | | For historical reasons, the code was placed under gtk/ subdirectory. If it was always bugging you, bug no more!
* TODO: updateMarc-André Lureau2015-06-081-4/+2
| | | | | | | | Remove outdated items: - ChannelBaseAudio?, - GDI backend wouldn't work well with scaling (moved to fdo bug) Fix fdo link
* usb-device-manager: Avoid error when compiling with --disable-usbredirPavel Grunt2015-06-081-1/+1
|
* usb: remove useless assignmentsMarc-André Lureau2015-06-051-3/+0
| | | | The struct is g_new0() already.
* win-usb: try to connect to usbclerk during initMarc-André Lureau2015-06-053-30/+44
| | | | | | | | | Fail early during initialization if the usbclerk service can't be reached. This changes the current behaviour that would retry to connect to usbclerk every time to perform an operation. Now, it will try each time the UsbDeviceManager is initialized.
* usb: do not return GError on programmer pre-condition checksMarc-André Lureau2015-06-051-23/+2
| | | | Use regular g_return precondition checks.
* win-usb: remove useless functionMarc-André Lureau2015-06-051-9/+2
|
* usb: misc code formattingMarc-André Lureau2015-06-051-2/+2
|
* usb: call win_usb_driver_new() during initable_init()Marc-André Lureau2015-06-052-7/+18
| | | | Throw an error when initialization failed.
* usb: use SPICE_CLIENT_ERROR_ prefixMarc-André Lureau2015-06-052-6/+11
| | | | To be consistent with GLib idioms, the code should use a common prefix for errors.
* usb: unref the device when it is no longer neededMarc-André Lureau2015-06-051-2/+2
| | | | | The current code unref() the device too early, it must be unref after it is no longer needed.
* win-usb: get rid of status code return in async opsMarc-André Lureau2015-06-053-24/+11
|
* win-usb: throw an error if reply.status == 0Marc-André Lureau2015-06-051-0/+8
|
* usb: use win-usb uninstall_finish()Marc-André Lureau2015-06-053-22/+46
|
* win-usb: rename async functionsMarc-André Lureau2015-06-053-29/+27
|
* win-usb: introduce a spice_win_usb_driver_op_finishMarc-André Lureau2015-06-051-15/+19
| | | | | | | | We want the exported functions to follow the gio async idom. Currently, both install() and uninstall() are paired with install_finish(). In the following patch we introduce uninstall_async() uninstall_finish() using that common internal op_finish() function. Then we correctly pair associated async/finish() calls.
* usb: remove useless declarationMarc-André Lureau2015-06-051-8/+0
|
* tests: add test to check for zombie GSourcesVictor Toso2015-06-051-0/+106
| | | | | | | | Using g_pollable_input_stream_create_source to generage several dummy GSources in order to check if giopipe sets all of them to be dispatched. This test check for zombie GSources during a write_all/read_chunk operation.
* tests: add test to concurrent write to pipeVictor Toso2015-06-051-0/+45
| | | | | Concurrent write is not supported and should fail. The GIO error is G_IO_ERROR_PENDING
* tests: pipe using _write_all_async functionVictor Toso2015-06-051-0/+75
|
* tests: remove read8_cb to use generic read_cbVictor Toso2015-06-051-16/+2
| | | | Both functions are basic the same so let's keep the generic one.
* webdav: write all buffer to client webdavVictor Toso2015-06-051-11/+14
| | | | | | Client's webdav can request less data (8192) then the amount sent by guest's webdav. Using g_output_stream_write_all_async in order to avoid losing data.
* giopipe: don't fail on create_sourceVictor Toso2015-06-051-30/+33
| | | | | | | | | | | | | PipeInputStream and PipeOutputStream should not fail when creating GPollableStream source as this currently does not work with default write_all and read_all functions; In order to avoid creating zombie GSource in create_source of both PipeInputStream and PipeOutputStream, we track all created GSources and set them to be dispatched when data is available to read/write. It is worth to mention that concurrent write/read is not possible with current giopipe and only the last created GSource will read the data as it is dispatched first.
* session: Enable proxy when requestedPavel Grunt2015-06-031-1/+1
| | | | | Disabling the proxy avoids usage of GProxyResolver to determine the necessary proxy protocol and to do the proxy negotiation.
* session: disable default socket proxyMarc-André Lureau2015-05-281-0/+1
| | | | | | | | | | | | | | | GSocketClient uses the system proxy by default, and it may end up using the system HTTP proxy with bad results if CONNECT is not supported. spice-gtk uses it's own SPICE_PROXY instead, and doesn't rely on GSocketClient default proxy but GProxyAddress instead. Disabling the default proxy solve a wrong proxy from being used. It may be worth to revisit this change if GSocketClient can be told to ignore proxies that are not eligible for Spice connections. (HTTP could be though, in which case it would be a user configuration issue) Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1040679
* Drop expansions of removed CFLAGS/LIBS variablesBenjamin Gilbert2015-05-211-6/+0
|
* iopipe: fix leak of streamsMarc-André Lureau2015-05-211-0/+5
| | | | | | | | | | | | | | | | | | | | | | g_simple_io_stream_new() do not steal references from us, unref the streams to avoid the leaks. Leak found by Victor Toso. ==30787== 2,808 (648 direct, 2,160 indirect) bytes in 9 blocks are definitely lost in loss record 479 of 482 ==30787== at 0x93AEBFD: g_type_create_instance (gtype.c:1849) ==30787== by 0x939128A: g_object_new_internal (gobject.c:1774) ==30787== by 0x9392AA0: g_object_newv (gobject.c:1921) ==30787== by 0x939338B: g_object_new (gobject.c:1614) ==30787== by 0x403B30: make_gio_pipe (giopipe.c:441) ==30787== by 0x403C8E: spice_make_pipe (giopipe.c:465) ==30787== by 0x4029B5: fixture_set_up (pipe.c:42) ==30787== by 0x9844EC8: test_case_run (gtestutils.c:2123) ==30787== by 0x9844EC8: g_test_run_suite_internal (gtestutils.c:2185) ==30787== by 0x984509A: g_test_run_suite_internal (gtestutils.c:2196) ==30787== by 0x98453FA: g_test_run_suite (gtestutils.c:2249) ==30787== by 0x9845430: g_test_run (gtestutils.c:1553) ==30787== by 0x402012: main (pipe.c:312)
* spicy: remove useless signal handlersMarc-André Lureau2015-05-121-45/+0
| | | | | | | | There is no strong reason to have signal handlers in spicy (a test tool). Clean quit can be achieved through the File/Quit menu. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1197175
* spice-gtk: Fixed build when using audio gstreamerLukas Venhoda2015-05-121-1/+1
| | | | | | | | Commit No. 63bf00275769928850113b4df205df08d6303b45 changed number of arguments of function playback_stop(), and didn't change call of this function on line 628. This would break building when using --with-audio=gstreamer
* webdav: check g_output_stream_write_all() return valueMarc-André Lureau2015-05-071-3/+4
| | | | | Check g_output_stream_write_all() return value to silence a coverity CHECKED_RETURN warning
* usb: channel-new handler to be after default handlersMarc-André Lureau2015-05-071-2/+1
| | | | | | | | | | | | | | | | Client usually connect to channel-new to connect their handlers, such as open-fd. The usbmanager channel-new handler will call channel_connect() on usbredir channels, which may call open-fd. However, open-fd can be emitted before the client had a chance to connect their handlers (from the channel-new callback). Connecting after the default handler solves this case. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=748665
* session: do not attempt to open_host if session changedMarc-André Lureau2015-05-071-2/+5
| | | | | Since channel can become session-less, let's check they still have the expected session when running the open-host idle.
* audio: stop playback on channel destroyedMarc-André Lureau2015-05-072-0/+4
| | | | Ensure playback is stopped when the channel is destroyed.
* audio: use swapped channel handler for stopMarc-André Lureau2015-05-072-7/+5
| | | | We are going to reuse playback_stop() in following commit.