| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Note this patch adds a default filter filtering out HID devices, since
redirecting ie a mouse plugged into a laptop is usually not what the user
wants. Also sometimes usb keyboards/mice may experience a glitch causing
them to temporarily drop of the bus. If this happens when the spice-client
has focussed it used to redirect them to the vm when they re-appeared,
not good!
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fix a hang on an image lookup that has already been remved. It
only happens in multihead, when stressing a bit the displays.
The decoder assumed that the last added images is the tail of the
window. However, there are "gaps" in the window that will be filled by
other channels. Instead of taking the last added image as the current
up to date tail, let's take the reference to the last image before the
first gap as the up to date tail, and release from there.
The spicec code does things differently, perhaps it needs slightly
less memory at the cost of added complexity by maintaining list of
missing images and much more conditions/synchronization.
|
|
|
|
|
| |
Make sure the display has the focus before grabing the keyboard for
the application.
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=44570
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=44570
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=44570
|
|
|
|
|
|
| |
Use the common g_coroutine_socket_wait()
https://bugs.freedesktop.org/show_bug.cgi?id=44570
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=44570
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=44570
|
|
|
|
|
|
|
| |
We try several connections, so it's normal to fail for some.
No need to warn.
https://bugs.freedesktop.org/show_bug.cgi?id=44570
|
|
|
|
| |
Needed to build on RHEL6
|
| |
|
|
|
|
| |
Required to build on RHEL, even upcoming 6.3
|
| |
|
|
|
|
|
| |
Don't send/receive serial and sub_list when the server supports the
above cap.
|
| |
|
| |
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=44179
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=44179
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this patch if you use:
spice://<host>:<port>
it will be treated the same as:
spice://<host>?port=<port>
You will also get a warning for the following double port definitions:
spice://<host>:<port1>?port=<port2>
spice://<host>:<port1>:<port2>
(similar to the double key warnings introduced in the previous commits)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On my system when running make install, after installing the libraries it
first executes install-binPROGRAMS:
/bin/sh ../libtool --mode=install /usr/bin/install -c spicy snappy spicy-st
libtool: install: /usr/bin/install -c .libs/spicy /usr/bin/spicy
libtool: install: /usr/bin/install -c .libs/snappy /usr/bin/snappy
libtool: install: /usr/bin/install -c .libs/spicy-stats /usr/bin/spicy-stats
Then the install-exec-hook:
make install-exec-hook
make[6]: Entering directory `/home/hans/projects/spice/spice-gtk/gtk'
chown root /usr/bin//spice-client-glib-usb-acl-helper
chmod u+s /usr/bin//spice-client-glib-usb-acl-helper
And only then does it install the actual helper by executing
install-aclPROGRAMS:
/bin/sh ../libtool --mode=install /usr/bin/install -c spice-client-glib-usb
libtool: install: /usr/bin/install -c spice-client-glib-usb-acl-helper /usr/bin
Which means that the install-exec-hook runs too early, either there is no
spice-client-glib-usb-acl-helper for it to make suid root, or if there is it
will later get overwritten and its rights will get reset.
The problem is that install-fooPROGRAMS gets run as part of install-data,
not install-exec. So we can fix this by changing the code to make the helper
suid root run from install-data-hook.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
| |
In glib <= 2.30 g_mutex_foo() are macro's so dereferencing them directly
does not work.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
channel_reset gets called from spice_channel_disconnect, and
spice_usbredir_channel_disconnect calls spice_channel_disconnect
(so as to disconnect the channel when a usb device gets disconnected).
So calling spice_usbredir_channel_disconnect from channel_reset leads to
undesirable recursion. More over calling spice_usbredir_channel_disconnect
disconnects / closes both the channel and *the usb device* and closing the
usb device on migration is not what we want.
Note that currently migration of usbredir channels does not work, and this
patch does not fix this, but it does fix a regression when disconnecting
usb devices normally (by unplugging them for example).
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Before this patch devices were described like this to the user:
USB device at 2-14
After this patch the description is:
SanDisk Cruzer Blade [0781:5567] at 2-14
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
| |
No that we no longer use GUsbSource we're hardly using any code from GUsb,
so drop our embeddied GUsb copy and do the last few things (device
enumeration through gudev) ourselves.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Now that we no longer use a GUsbSource this is no longer needed.
Note this is a change to our public API, but that is ok since we have not
yet done an official release with usbredir support.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
| |
This solves various latency issues with USB handling.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
| |
This is a preparation patch for handling usb packet completion in a
separate thread.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
| |
This is a preparation patch for handling usb packet completion in a
separate thread.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new (in usbredir-0.3.2) usbredirhost_open_full()
function allows us to be notified whenever usb packets completing
result in data to be send to the host. This removes the need for using
g_usb_source_set_callback and seeing if there is data to write on
any of the usb channels each time some usb event happens.
This also bumps the minimum needed libusbredirhost version to 0.3.2
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
| |
A usbredir channel must always be bi-directional. spice-server
allows only one client to connect even when in multi-client mode. Since
usually there are multiple usb channels available, it is allowed for one client
to use one channel, while another client uses another usb channel.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
| |
This is not necessary and as we get more private data it becomes
unyieldly.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
| |
This is a preparation patch for handling usb packet completion in a
separate thread.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
| |
spicec does this for all channels, and it seems like a good idea to do the
same in spice-gtk.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Currently, building vala bindings from a tarball is broken because
spice-client-glib-2.0.deps is missing from the tarball. This commit
adds it to EXTRA_DIST and also makes sure the vala bindings don't
get built/installed unless --enable-vala has been passed to configure.
This means vala must be installed to build the vala bindings from a
tarball. Fixes fdo bug #44000.
|
|
|
|
|
| |
They were work in progress and not meant to be committed, apologies
for the noise :-/
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Disable usbredir, since it wants to install file in /.
Disable vala for distcheck for 2 reasons: not needed after dist and
binding build issue.
Ship with spice-gtk-3.0 vala bindings
https://bugs.freedesktop.org/show_bug.cgi?id=44000
|
|
|
|
|
| |
It's currently installed in $bindir, but this patch makes it possible
for distros like fedora to install it in $libexecdir/spice/
|
| |
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=44019
|