summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Notify agent-connected property changeMarc-André Lureau2012-03-183-2/+19
|
* Improve spice_main_set_display_enabled()Marc-André Lureau2012-03-181-2/+11
| | | | | Check given display id is within the range of array. Allows to be call with -1 to turn set all displays.
* Fix non-semi-seamless migration in spicyMarc-André Lureau2012-03-181-47/+75
| | | | | | | | | | | | | | The windows are destroyed during non-semi-seamless migrations, but the gtk session and connected handlers remains. When a property changes again on it, it will signal a destroyed window and lead to a crash. The signal handler should be disconnected when the window is destroyed. Since we have N numbers of handlers, it's easier to use spice_signal_connect_object() helper to handle this for us by turning spice_window structure into a basic GObject. That GObject code could be improved, but that wasn't the goal of this patch.
* Use given color depth in monitor configurationMarc-André Lureau2012-03-181-1/+1
| | | | | | | | | The main channel only relied on VD_AGENT_DISPLAY_CONFIG_FLAG_SET_COLOR_DEPTH to set color depth when connecting to a guest. However, that doesn't seem to be enough. Instead send given color depth with monitor configuration. Fix --spice-color-depth option not "apparently" working.
* build-sys: if stow is installed, default prefix to itMarc-André Lureau2012-03-161-0/+7
| | | | This is going to make life easier for stow users, including myself.
* build: fix build with glib < 2.32Marc-André Lureau2012-03-163-11/+26
| | | | Using GMutex as a static mutex is only possible since 2.32.
* Add a G_GNUC_NORETURN to a function that exitsMarc-André Lureau2012-03-162-0/+1
|
* use common submoduleMarc-André Lureau2012-03-1558-26999/+17
|
* Fix incorrect array size checkMarc-André Lureau2012-03-151-1/+1
|
* Move undef FORTIFY below config.hMarc-André Lureau2012-03-141-2/+2
| | | | | | It used to be below, then was moved on top of all, but now it's defined in config.h. Hopefully below config.h is the right place. config.h should never have direct includes anyway.
* buildsys: Disable some warningsHans de Goede2012-03-141-0/+4
| | | | | | | | | | | Mostly so that they don't turn into errors when building from source: -Wno-missing-field-initializers: Because this has to be close to the most stupid warning gcc has ever produced -Wno-deprecated-declarations Because we use some deprecated functions to avoid #ifdef hell while maintaining compat with older gtk / glib versions Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* usbredir: Check for existing usb channels after libusb initHans de Goede2012-03-141-24/+21
| | | | | | | | | | | | | | | | | | | | | | Currently trying to view a usbredir enabled vm from virt-manager causes virt-manager to crash. This crash is caused by the following happening: -virt-manager sets up the session, including connecting all the channels -a spice-gtk internal code path calls spice_usb_device_manager_get() -spice_usb_device_manager_get calls channel_new on all already connected usb channels -channel_new does: spice_usbredir_channel_set_context(SPICE_USBREDIR_CHANNEL(channel), self->priv->context); -But self->priv->context has not been set yet (so is NULL) -> segfault! This patch fixes this by moving the iterating over already connected usb channels to after the setting of self->priv->context. Note this means that the channels will no longer get checked when there is no USB_REDIR support. That is not a problem since spice_usb_device_manager_initable_init will return FALSE in that case anyways. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Use GTK_DISABLE_DEPRECATED to avoid inclusion of problematic headersMarc-André Lureau2012-03-144-0/+27
| | | | /usr/i686-w64-mingw32/sys-root/mingw/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: error: function declaration isn't a prototype [-Werror=strict-prototypes]
* Fix 'libintl_printf' is an unrecognized format functionMarc-André Lureau2012-03-141-1/+2
| | | | ../common/lz.h:18:5: error: 'libintl_printf' is an unrecognized format function type [-Werror=format]
* Remove deprecation warningsMarc-André Lureau2012-03-145-16/+31
|
* Disable -Wwrite-strings for Python bindingDaniel P. Berrange2012-03-142-1/+5
| | | | | | The code generator for the python binding generates code which throws away const-ness on strings. Disable the -Wwrite-strings warning to avoid failing on this auto-generated code.
* Replace %02hhx with %02x in UUID formatDaniel P. Berrange2012-03-131-1/+1
| | | | | Use of 'hh' in the UUID format string is not required. Furthermore it causes errors on Mingw32, where the 'hh' modifier is not supported
* Import GNULIB's GCC warning macrosDaniel P. Berrange2012-03-134-69/+362
| | | | | | | | | | | | | | | GNULIB has a helpful module 'manywarnings' which makes it easy to turn on every single GCC warning. The general goal is that every possible GCC warning should be enabled, except for certain blacklisted warnings. This imports the GNULIB m4 macros, and updates configure.ac to use this new capability. As & when new GCC warnings are created, the 'manywarnings.m4' can be refreshed from upstream GNULIB * m4/manywarnings.m4, m4/warnings.m4: GNULIB warning macros * configure.ac: Remove custom compiler warning checks * m4/spice-compile-warnings.m4: Decide what GCC warnings to enable
* Avoid 'goto' jumping over variable initializationDaniel P. Berrange2012-03-131-1/+2
| | | | | | | | When a goto statement jumps over a variable declaration with an initializer, the state of that variable is undefined. Move the declaration further up, so that the goto doesn't jump over it. This lets the compiler then warn, if the goto jump results in use of undefined values.
* Fix no-arg functions declared () to use (void)Daniel P. Berrange2012-03-133-3/+3
| | | | * common/quic.h, common/rop3.h, common/sw_canvas.h: s/()/(void)/
* Add missing includes & make some functions staticDaniel P. Berrange2012-03-137-8/+11
| | | | | | | | | A number of functions were used without prior declaration. In some cases this was due to missing include files. In other cases the functions should have just been static. Ideally this would allow -Wmissing-declarations to be enabled, but the files generated by spice_codegen.py will still trip up on this.
* Ensure all no-args methods are declared (void) not ()Daniel P. Berrange2012-03-134-9/+9
| | | | | * common/quic.c, common/rop3.c, common/sw_canvas.c, gtk/spice-client-glib-usb-acl-helper.c: s/()/(void)/
* Add printf format annotations to all '...' functionsDaniel P. Berrange2012-03-134-10/+42
| | | | | | | | | | To allow the compile to detect incorrect printf formats, any var-args function should have a format annotation * common/macros.h: Helper to define ATTR_PRINTF for code which can't depend on glib * common/canvas_base.c, common/lz.h, common/macros.h: Annotate some var-args methods
* Replace duplicated header declarationsDaniel P. Berrange2012-03-132-4/+0
| | | | | | | | | | | The usb-helper-acl.h header file duplicated some declarations already present in usb-device-manager.h The channel-display.c file declared the object init function which is already done by the GObject helper macros * gtk/channel-display.c: Remove duplicate decl of init function * gtk/usb-acl-helper.h: Remove duplicate decls
* Remove arithmetic on void* pointersDaniel P. Berrange2012-03-131-1/+1
| | | | | | | Arithmetic on void * pointers is undefined by the C standard. Convert the one case of this to use guint8 instead. * gtk/channel-main.c: s/void */guint8 */
* Fix some integer range checks which always evaluate falseDaniel P. Berrange2012-03-133-4/+4
| | | | | | | | | | | | There are some integer range checks which always evaluate false due to use of unsigned integer types. One of these would prevent detection of encoding errors from celt. The others are simply no-ops. * gtk/channel-record.c: Make 'frame_size' signed to allow detection of celt encoding errors * gtk/spicy.c: nkeys is an unsigned type, so checks for nkeys < 0 are bogus * common/pixman_utils.c: SpiceROP is an enum & thus unsigned
* Avoid warnings about empty conditional statement bodiesDaniel P. Berrange2012-03-131-6/+9
| | | | | | | | | | | | Add extra {} braces around if/else statements which only call SPICE_DEBUG to avoid: ../common/ssl_verify.c: In function 'verify_pubkey': ../common/ssl_verify.c:87:50: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] ../common/ssl_verify.c: In function 'verify_hostname': ../common/ssl_verify.c:254:53: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] ../common/ssl_verify.c: In function 'verify_subject': ../common/ssl_verify.c:381:41: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
* Fix deprecation warning handlingDaniel P. Berrange2012-03-138-7/+15
| | | | | | | | | | | | | | | | | | Various methods are deprecated by using the G_GNUC_DEPRECATED_FOR macro. Unfortunately this macro was placed in the .c file impl, instead of the .h file decl. Thus applications building against SPICE-GTK would never see the deprecation warnings. At the same time, building SPICE-GTK itself would trigger some of the warnings preventing use of -Wdeprecated-declarations to detect use of deprecated GTK functions. The fix is in multiple parts * Replace calls to G_GNUC_DEPRECATED_FOR with SPICE_DEPRECATED_FOR * Move macros from .c to .h files * Turn SPICE_DEPRECATED_FOR into a no-op if SPICE_NO_DEPRECATED is defined * Define SPICE_NO_DEPRECATED when building
* Fix old style declaration where 'inline' came after return typeDaniel P. Berrange2012-03-131-1/+1
| | | | Fix a case of 'static int inline' to be 'static inline int'
* Fix const-correctness of functions & add explicit castsDaniel P. Berrange2012-03-134-11/+11
| | | | | | | Some functions should be declared to take const char * instead of plain char *. In other places we intentionally cast away const-ness, so we should add explicit casts to stop compiler warnings
* Remove non-existant include directories from CFLAGSDaniel P. Berrange2012-03-131-2/+0
|
* Don't delete gtk-doc.make in distcleanDaniel P. Berrange2012-03-131-1/+1
| | | | | gtk-doc.make is created by autogen.sh, therefore it should not be deleted in distclean, only maintainerclean
* Release v0.11v0.11Marc-André Lureau2012-03-083-1/+11
|
* Update since annotation for some session propertiesMarc-André Lureau2012-03-081-0/+6
|
* channel-usbredir: Handle some more usbredirhost_read_guest_data errorsHans de Goede2012-03-083-4/+24
| | | | Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Do not warn when starting spicy if usbredir is disabledMarc-André Lureau2012-03-071-6/+5
|
* sasl: sasl authentication failure results in disconnectionMarc-André Lureau2012-03-071-2/+1
| | | | | | | When SASL auth failure happen, the Spice server disconnects the client. Sadly, this is not easily distinguishable from an IO error. However, since it happens during authentication phase it is better to error out an authentication error.
* sasl: lower visibility of normal debug messageMarc-André Lureau2012-03-071-2/+2
| | | | | | Those two g_critical() can happen when collecting credentials for the first time. It is not something to be warned about, but merely useful for debugging
* build: move @SPICE_GLIB_REQUIRES@ to Requires.privateMarc-André Lureau2012-03-071-1/+2
| | | | | | | | | | The libraries listed in Requires aren't needed during build time, they are library depedencies. And since this is only needed if linking statically, we can safely move them to Requires.private. Succesfully tested change with compilation against virt-viewer. Later, this will also help fixing bug rhbz #799112.
* Fix semi-seamless migration handlingMarc-André Lureau2012-03-061-42/+25
| | | | | | SPICE_MSGC_MAIN_MIGRATE_END was dropped because the main channel was xmit_queue_blocked. When we swap the channels, we should also swap xmit_queue.
* Warn if a message is dropped (before connection or after reset)Marc-André Lureau2012-03-051-15/+20
| | | | | | Since c2ba62666beaee526e1b4288f9bd66976ce780ef messages can be ignored when a channel is reset. A warning can help explain why some messages are dropped.
* Support name & uuidMarc-André Lureau2012-03-059-2/+127
| | | | Allows a client to identify the server it is connected to.
* Add a spice-controller-dump testing toolMarc-André Lureau2012-02-293-6/+137
| | | | | By default, start a controller listener. If ran with --menu, start a foreign-menu listener.
* Add controller foreign menu supportMarc-André Lureau2012-02-298-3/+530
|
* Fix a few warnings on windows buildMarc-André Lureau2012-02-292-5/+12
|
* Allow open_fd() to be called with -1Marc-André Lureau2012-02-292-4/+14
| | | | | In this case, a valid fd will be requested via the SpiceChannel::open-fd signal.
* buildsys: Don't link glib-compat.o into libspice-client-gtk.soHans de Goede2012-02-242-1/+1
| | | | | | | | | | | | | | | | | | glib-compat.c was added to SPICE_GTK_SOURCES_COMMON since with the new SpiceUsbDeviceWidget libspice-client-gtk now also uses G_TYPE_ERROR and when compiling with an older glib this gets defined in glib-compat.o However doing this turns out to be a very BAD idea, since having glib-compat.o linked into 2 different libraries, each defining there own private spice_error_get_type, leads to the "GError" type getting registered twice with glib, which it does not like. So instead of linking glib-compat into 2 different libraries, put it only in libspice-client-glib and export spice_error_get_type from libspice-client-glib (this is ofcourse intended for libspice-client-gtk private use only). Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Fix building with policykit < 0.101Hans de Goede2012-02-242-0/+21
| | | | Signed-off-by: Hans de Goede <hdegoede@redhat.com>
* Release v0.10v0.10Marc-André Lureau2012-02-233-1/+15
|
* use :glz-window-size not :glz_window_sizeMarc-André Lureau2012-02-231-1/+1
|
generated by cgit (git 2.34.1) at 2025-10-02 19:17:38 +0000