summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@gmail.com>2015-11-17 18:45:03 +0100
committerMarc-André Lureau <marcandre.lureau@gmail.com>2015-12-08 14:11:49 +0100
commit7324f10cf483f366154b8925302f0d3d9e1dae10 (patch)
tree1b65c2ad43f25113492169b65acdcc1dbb90fdfa
parent0de7b5cf1f906b7801adc0d41fa260adbaa80c0a (diff)
downloadspice-gtk-7324f10cf483f366154b8925302f0d3d9e1dae10.tar.gz
spice-gtk-7324f10cf483f366154b8925302f0d3d9e1dae10.tar.xz
spice-gtk-7324f10cf483f366154b8925302f0d3d9e1dae10.zip
Fix use after free of uri
"path" points to "uri" memory, move free(uri) later. Found thanks to valgrind :) Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
-rw-r--r--src/spice-session.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/spice-session.c b/src/spice-session.c
index c673fa2..a36dcea 100644
--- a/src/spice-session.c
+++ b/src/spice-session.c
@@ -557,7 +557,6 @@ static int spice_parse_uri(SpiceSession *session, const char *original_uri)
end:
/* parsed ok -> apply */
- g_free(uri);
g_free(unescaped_path);
g_free(s->unix_path);
g_free(s->host);
@@ -566,6 +565,7 @@ end:
g_free(s->username);
g_free(s->password);
s->unix_path = g_strdup(path);
+ g_free(uri);
s->host = host;
s->port = port;
s->tls_port = tls_port;