summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* common/backtrace.h: disable for WIN32Alon Levy2012-03-201-0/+4
| | | | | This also catches mingw32 which is probably fine, but at least it fixes the build on visual studio.
* fix integer marshalling helpers on big endianChristophe Fergeau2012-03-201-6/+6
| | | | | | They were trying to convert the destination pointer to an integer before trying to dereference it. The initial conversion was meant to be a cast to a pointer of the right size, not to an integer.
* fix typo in big endian code pathChristophe Fergeau2012-03-201-2/+2
| | | | uint63_t should be uint64_t
* fix make distcheckChristophe Fergeau2012-03-201-1/+1
|
* common: add backtrace via gstack or glibc backtraceAlon Levy2012-03-204-0/+142
| | | | | | Add a backtrace printing function copied from xserver os/backtrace.c that uses gstack, and if that isn't found then glibc's backtrace. Used in ASSERT, tested on F15.
* don't #include config.h in generated header filesChristophe Fergeau2012-03-201-3/+4
| | | | | | | | 7e30572ab adds a #include <config.h> to the beginning of generated files. It also does this for generated headers and enums files, which is not wanted, especially if it's an installed file. This commit only adds this include for the non-header non-enum case (hopefully, enums are only generated for use in a .h file).
* add check for pyparsingChristophe Fergeau2012-03-201-3/+8
| | | | | | Check both in configure.ac (after checking if we need to rebuild the marshalling files) and in the python script using pyparsing (for people modifying .proto files in tarballs)
* sndworker: add AudioVolume/AudioMute messagesMarc-André Lureau2012-03-202-0/+22
| | | | | | | | | | | | | | | | | | | These messages allow the guest to send the audio device volume to the client. It uses an arbitrary scale of 16bits, which works good enough for now. Save VolumeState in {Playback,Record}State, so that we can send the current volume on channel connection. Note about future improvements: - add exact dB support - add client to guest volume change Updated since v2: - bumped record and playback interface minor version to allow conditional compilation Updated since v1: - sync record volume on connection too
* python: remove c-ism trailing ;Marc-André Lureau2012-03-205-25/+25
|
* codegen: typedef the protocol enumsMarc-André Lureau2012-03-201-4/+12
| | | | | | | Commit 9d5ef9beeca722b2ceff7d15aaa3aaaaf07ecfbf in spice-protocol introduced a typedef manually in the generated enums.h header. This patch adds them automatically to all enums during enums.h generation.
* common: add WIN64 ifdef for spice_bit_find_msb (fix broken windows x64 build)Arnon Gilboa2012-03-201-2/+2
| | | | | inline __asm is not supported in x64, so use the naive implementation until x64 asm implemented.
* common: use INLINE instead of inlineArnon Gilboa2012-03-207-38/+20
| | | | | | needed for spice/common files used by the client, server & qxl driver. in windows _inline works for both c/c++, while inline is c++ only. compiling the client with mixed c/c++ code required this define.
* common: fix ssl_verify windows build errorsArnon Gilboa2012-03-202-2/+8
|
* common: add ssl_verify.c common codeMarc-André Lureau2012-03-203-0/+543
| | | | | | | | | | | | | | | | | | Code adapter from RedPeer::ssl_verify_callback() and used by spice-gtk. Since v1: - fixed Makefile.am - added config.h include - autoconf alloca added in patch series - moved int escape inside for loop - added a failed case when missing assignment - replaced strlen () by -1 - skip spaces after comma - c++ guards I didn't use bool, because openSSL uses int, and it is more future proof for error reporting.
* common: add ring_get_length() for debugging purposesMarc-André Lureau2012-03-201-0/+13
| | | | | Please notice it has a "static" modifier, like the rest of the inlined functions in ring.h, so it won't warn if it isn't used.
* common: mem.h add alloca definitionMarc-André Lureau2012-03-201-0/+30
| | | | | We don't support the autoconf ALLOCA/C_ALLOC fallback. If one day, someone cares for a weird platform, he can fix it.
* common: spice_memdup could accept NULLMarc-André Lureau2012-03-201-0/+4
| | | | (this patch is not to solve a crash fix, but to align with glib API)
* common: add windows.h where required, make gdi_handlers staticMarc-André Lureau2012-03-203-1/+8
| | | | | This patch has not been verified with VS/brew. It should be safe hopefully. Compilation is fine with mingw32/spice-gtk.
* move get_time_stamp to main_channel.cChristophe Fergeau2012-03-201-7/+0
| | | | | There is only one user of get_time_stamp from spice_common.h so it's not really useful to keep it there.
* use standard do { } while (0) for spice_common.h macrosChristophe Fergeau2012-03-201-11/+11
|
* move WARN and WARN_ONCE to spice_common.hChristophe Fergeau2012-03-204-15/+7
|
* common: use PANIC from spice_common.hChristophe Fergeau2012-03-203-20/+0
|
* common,server: use ASSERT from spice_common.hChristophe Fergeau2012-03-207-36/+3
| | | | | | | spice_common.h provides an ASSERT macro, no need to duplicate it in many places. For now client/debug.h keeps its own copy since debug.h and spice_common.h have clashes on other macros which are trickier to unify.
* common: don't duplicate find_msb implementationChristophe Fergeau2012-03-204-67/+95
|
* add missing staticChristophe Fergeau2012-03-201-2/+2
|
* add comment to beginning of autogenerated filesChristophe Fergeau2012-03-201-0/+2
|
* add config.h to autogenerated files tooChristophe Fergeau2012-03-201-0/+4
| | | | | Modify the python (de)marshaller generator to add #include <config.h> at the beginning of the C files it generates
* add #include <config.h> to all source filesChristophe Fergeau2012-03-2020-5/+63
| | | | | | | | When using config.h, it must be the very first include in all source files since it contains #define that may change the compilation process (eg libc structure layout changes when it's used to enable large file support on 32 bit x86 archs). This commit adds it at the beginning of all .c and .cpp files
* autotools: correctly build canvas-related codeChristophe Fergeau2012-03-209-14/+39
| | | | | | | | | | | | | | | | | | | | | spice client and spice server shares code from common/{gdi,gl,sw}_canvas.[ch]. However, while most of the code is shared, the server code wants a canvas compiled with SW_CANVAS_IMAGE_CACHE defined while the client code wants a canvas compiled with SW_CANVAS_CACHE. The initial autotools refactoring didn't take that into account, this is now fixed by this commit. After this commit, the canvas files from common/ are no longer compiled as part of the libspice-common.la convenience library. Instead, there are "proxy" canvas source files in client/ and server/ which #include the appropriate C files after defining the relevant #define for the binary that is being built. To prevent misuse of the canvas c files and headers in common/, SPICE_CANVAS_INTERNAL must be set when including the canvas headers from common/ or when building the c files from common/ otherwise the build will error out.
* autotools: refactor the whole build machineryChristophe Fergeau2012-03-201-31/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | spice Makefile.am setup is a bit confusing, with source file names being listed several times in different Makefile.am (generally, once in EXTRA_DIST and another time in another Makefile.am in _SOURCES). The client binaries are built by client/x11/Makefile.am, which means recursing into client, then into x11 to finally build spicec. This Makefile.am is also referencing files from common/ and client/, which is a bit unusual with autotools. This patch attempts to simplify the build process to get something more usual from an autotools point of view. The source from common/ are compiled into a libtool convenience library, which the server and the client links against which avoids referencing source files from common/ when building the server and the client. The client is built in client/Makefile.am and directly builds files from x11/ windows/ and gui/ if needed (without recursing in these subdirectories). This makes the build simpler to understand, and also makes it possible to list source files once, which avoids potential make distcheck breakage when adding new files. There is a regression in this patch with respect to sw_canvas/gl_canvas/gdi_canvas. They should be built with different preprocessor #defines resulting in different behaviour of the canvas for the client and the server. However, this is not currently the case, both the client and the server will use the same code for now (which probably means one of them is broken). This will be fixed in a subsequent commit. make distcheck passes, but compilation on windows using the autotools build system hasn't been tested, which means it's likely to be broken. It shouldn't be too hard ot fix it though, just let me know of any issues with this.
* common: don't try to redefine PANIC if it already existsChristophe Fergeau2012-03-201-0/+2
| | | | | | | | | | canvas_base.c tries to define PANIC, but it might already be set if eg client/debug.h has been included before. All the other macros in this file are guarded by #ifndef, this commit adds the missing #ifndef to PANIC. Note that this is just a bandaid, ideally common/ would contain a logging frameword, and these macros would only be defined once instead of being defined in several places.
* use foo(void) instead of foo() in prototypesChristophe Fergeau2012-03-2011-11/+11
| | | | | In C, the latter isn't a prototype for a function with no arg, but declares a function with an undefined number of args.
* common: add missing header guards to gl_canvas.hChristophe Fergeau2012-03-201-0/+5
|
* common: add extern "C" guards to headersChristophe Fergeau2012-03-2023-2/+182
| | | | | | Since some spice C++ code is using code from common/, the C functions need to be marked as such for the C++ compiler, otherwise we'll get linkage issues.
* spice.proto: Fill.rop_descriptor type s/uint16/ropd (10x atiti)Alon Levy2012-03-201-1/+1
|
* draw: remove SPICE_ADDRESSChristophe Fergeau2012-03-201-1/+0
| | | | | | This commit removes the typedef for SPICE_ADDRESS which was no longer used. This is the last thing that was missing to close fdo bug #28984
* common/pixman: remove dead assignmentsChristophe Fergeau2012-03-201-7/+3
| | | | | | They were detected using clang-static-analyzer. Don't initialize the variable to a value to override it with a different value a few lines after.
* common/gl: remove unused variableChristophe Fergeau2012-03-201-3/+2
| | | | | | | clang static analyzer warned that 'len' was computed but never used in glc_vertex2d. glc_stroke_line_dash has side effects so we have to call it, but we don't need to save its return value since it's not used.
* python_modules/codegen.py: fix indent error in an unused functionAlon Levy2012-03-201-1/+1
|
* ring: add RING_FOREACH{,_SAFE,_REVERSED}Alon Levy2012-03-201-0/+21
|
* server/common: introduce common/spice_common.hAlon Levy2012-03-201-0/+70
| | | | | | move all the ASSERT/PANIC/PANIC_ON/red_error/red_printf* macros to a common file to be used with ring.h that is going to be used externally (by spice-gtk).
* common: add SpiceBuffer - based on qemu-vnc BufferMarc-André Lureau2012-03-202-0/+70
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=34795
* spice-client migration: fix minor for old migration support.Uri Lublin2012-03-201-4/+4
| | | | | | | For not too old spice-migration, minor is 1. For older (ancient) spice-migration, minor is 0. Affects only VM migration while a spice client is connected.
* demarshaller/marshaller fix gcc 4.6.0Alon Levy2012-03-202-9/+21
| | | | | | | | | | python_modules/demarshal.py and marshal.py fixes for gcc 4.6.0 warning about set but unused variables. The fixes disable creating of variables mem_size when they are not used (demarshall) and declaring a src variable when the message doesn't use it (marshal). You need to touch *.proto after applying this (should add a Makefile dependency).
* codegen: avoid creating out if not used (fix gcc 4.6.0 warning)Alon Levy2012-03-201-3/+5
|
* common/sw_canvas: remove unused error valAlon Levy2012-03-201-2/+1
| | | | | | | | | | | This is the only unused var change I'll want to revisit eventually, I'm submitting anyway since it doesn't change current behavior. I'm talking about ignoring the return value from canvas creation. Adding a print is possible but I didn't test (may be too verbose, also preferable to be a debug print if so, and we don't have that option in the code atm - probably an environment variable will do, or adding some spice_server_set_logging_level api, maybe even spice_server_set_logging_fd?)
* common/canvas_base.c: remove unused variablesAlon Levy2012-03-201-12/+0
|
* common, canvas_get_jpeg_alpha: let top_down be any valueAlon Levy2012-03-201-1/+1
| | | | | | | Allow top_down flag to have any value, only ASSERT it is positive when needs to be positive and zero otherwise. Allows older server bug of sending 4 instead of 1 in top down flag to not affect newer clients (previous patch fixes server).
* mingw32 build: python_modules/marshal: use unsigned for for_loop index variableAlon Levy2012-03-201-1/+1
|
* mingw32 build: various fixesAlon Levy2012-03-201-2/+2
|