Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | log: Fix log levels. | Gangadhar Sandrani | 2014-04-22 | 1 | -1/+1 |
| | | | | | Signed-off-by: Gangadhar Sandrani <gangadhar.sandrani@gmail.com> Reviewed-by: Andreas Schneider <asn@cryptomilk.org> | ||||
* | packet: Do not decrypt zero length rest of buffer | Alan Dunn | 2014-02-06 | 1 | -6/+13 |
| | | | | | | | | | | | | | | | | | | | | | | | If we receive a packet of length exactly blocksize, then packet_decrypt gets called on a buffer of size 0. The check at the beginning of packet_decrypt indicates that the function should be called on buffers of at least one blocksize, though the check allows through zero length. As is packet_decrypt can return -1 when len is 0 because malloc can return NULL in this case: according to the ISO C standard, malloc is free to return NULL or a pointer that can be freed when size == 0, and uclibc by default will return NULL here (in "non-glibc-compatible" mode). The net result is that when using uclibc connections with libssh can anomalously fail. Alternatively, packet_decrypt (and probably packet_encrypt for consistency) could be made to always succeed on len == 0 without depending on the behavior of malloc. Thanks to Josh Berlin for bringing conneciton failures with uclibc to my attention. Signed-off-by: Alan Dunn <amdunn@gmail.com> Reviewed-by: Andreas Schneider <asn@cryptomilk.org> | ||||
* | src: Rename buffer_add_data() to ssh_buffer_add_data(). | Andreas Schneider | 2014-01-19 | 1 | -1/+1 |
| | |||||
* | src: Rename buffer_init to ssh_buffer_init(). | Andreas Schneider | 2014-01-19 | 1 | -2/+2 |
| | |||||
* | src: Remove enter_function() and leave_function(). | Andreas Schneider | 2013-07-14 | 1 | -7/+3 |
| | |||||
* | src: Migrate to SSH_LOG. | Andreas Schneider | 2013-07-14 | 1 | -10/+10 |
| | |||||
* | src: Add fall trough comments. | Andreas Schneider | 2013-06-18 | 1 | -0/+1 |
| | |||||
* | packet1: Don't free an invalid address. | Andreas Schneider | 2013-06-17 | 1 | -1/+0 |
| | |||||
* | packet: Make default_packet_handlers static. | Andreas Schneider | 2012-02-19 | 1 | -1/+1 |
| | | | | Fixes sparse warnings. | ||||
* | build: Fix zlib support. | Andreas Schneider | 2011-09-23 | 1 | -2/+2 |
| | |||||
* | build: Fix SSHv1 build. | Andreas Schneider | 2011-09-22 | 1 | -1/+5 |
| | |||||
* | priv: Create crc32.h. | Andreas Schneider | 2011-09-18 | 1 | -0/+1 |
| | | | | As crc32 is only needed by SSHv1, build it only with SSHv1. | ||||
* | SSH1: handle exit-status message (channels would not close) | Aris Adamantiadis | 2011-09-14 | 1 | -1/+1 |
| | |||||
* | packet1: Fixed dead assignments. | Andreas Schneider | 2010-12-21 | 1 | -3/+1 |
| | | | | Found by http://test.libssh.org/scan-build/ | ||||
* | build: Fixed build warning on FreeBSD. | Andreas Schneider | 2010-12-20 | 1 | -0/+5 |
| | |||||
* | misc: Rename libssh/ to src/ | Andreas Schneider | 2010-09-06 | 1 | -0/+362 |