summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Added known host test casesAris Adamantiadis2014-02-011-0/+122
|
* tests: fix compilation on OSX (libargp detection)Aris Adamantiadis2014-02-011-1/+1
|
* pki_crypto: Fix memory leak with EC_KEY_set_public_key().Andreas Schneider2014-01-281-1/+3
| | | | BUG: https://red.libssh.org/issues/146
* doc: Document the unit for ssh_select() timeout.Andreas Schneider2014-01-231-1/+1
| | | | BUG: https://red.libssh.org/issues/143
* dh: Fix NULL check for p_group14.Rod Vagg2014-01-231-1/+1
| | | | Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* pki_crypto: fix DSA signature extractionJon Simons2014-01-231-26/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | Fix the DSA portion of 'pki_signature_to_blob': before this change, it is possible to sometimes observe DSA signature validation failure when testing with OpenSSH clients. The problem ended up being the following snippet which did not account for the case when 'ssh_string_len(x)' may be less than 20: r = make_bignum_string(sig->dsa_sig->r); ... memcpy(buffer, ((char *) ssh_string_data(r)) + ssh_string_len(r) - 20, 20); Above consider the case that ssh_string_len(r) is 19; in that case the memcpy unintentionally starts in the wrong place. The same situation can happen for value 's' in this code. To fix, adjust the offsets used for the input and output pointers, taking into account that the lengths of 'r' and 's' can be less than 20. With the fix I am no longer able to reproduce the original failure mode. BUG: https://red.libssh.org/issues/144 Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* pki: Use ssh_buffer_add_data() in pki_gcrypt..Andreas Schneider2014-01-221-3/+3
|
* doc: Fix description of error parameter for ssh_get_error*Alan Dunn2014-01-221-2/+2
| | | | | | | | | ssh_get_error can actually work on anything with an ssh_common_struct as its first member. It is already used in examples in the distribution with ssh_sessions and ssh_binds. Signed-off-by: Alan Dunn <amdunn@gmail.com> Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* pki_crypto: pad RSA signature blobsJon Simons2014-01-211-24/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Pad RSA signature blobs to the expected RSA signature length when processing via 'pki_signature_to_blob'. Some clients, notably PuTTY, may send unpadded RSA signatures during the public key exchange: before this change, one can sometimes observe failure in signature validation when using PuTTY's 'plink' client, along these lines: ssh_packet_process: ssh_packet_process: Dispatching handler for packet type 50 ssh_packet_userauth_request: ssh_packet_userauth_request: Auth request for service ssh-connection, method publickey for user 'foo' ssh_pki_signature_verify_blob: ssh_pki_signature_verify_blob: Going to verify a ssh-rsa type signature pki_signature_verify: pki_signature_verify: RSA error: error:04091077:rsa routines:INT_RSA_VERIFY:wrong signature length ssh_packet_userauth_request: ssh_packet_userauth_request: Received an invalid signature from peer For cross-reference this issue once also existed between PuTTY and OpenSSH: http://www.chiark.greenend.org.uk/~sgtatham/putty/wishlist/rsa-verify-failed.html http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/ssh-rsa.c?rev=1.19;content-type=text%2Fx-cvsweb-markup With the fix I am unable to reproduce the above failure mode when testing with 'plink'. Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* Test change to ssh_bind_accept_fdAlan Dunn2014-01-211-0/+139
| | | | | Signed-off-by: Alan Dunn <amdunn@gmail.com> Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* Import keys during ssh_bind_accept_fdAlan Dunn2014-01-211-1/+11
| | | | | Signed-off-by: Alan Dunn <amdunn@gmail.com> Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* Separate out key import functionality from ssh_bind_listenAlan Dunn2014-01-211-12/+23
| | | | | Signed-off-by: Alan Dunn <amdunn@gmail.com> Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* src: Rename buffer_add_data() to ssh_buffer_add_data().Andreas Schneider2014-01-1920-89/+114
|
* src: Rename buffer_init to ssh_buffer_init().Andreas Schneider2014-01-1917-48/+53
|
* doc: Fix channel documentation.Andreas Schneider2014-01-171-31/+49
|
* pki: Do not use deprecated string functions.Andreas Schneider2014-01-171-1/+1
|
* src: Do not use deprecated functions.Andreas Schneider2014-01-169-35/+35
|
* include: Mark functions as deprecated!Andreas Schneider2014-01-161-45/+45
|
* bind: fix possible double-frees in ssh_bind_freeJon Simons2014-01-161-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure to explicitly set key pointers to NULL following the use of 'ssh_key_free' throughout bind.c. Before this change, a double free can happen via 'ssh_bind_free' as in this example callpath: // create an ssh_bind ssh_bind b = ssh_bind_new(); // provide a path to a wrong key-type ssh_bind_options_set(b, SSH_BIND_OPTIONS_DSAKEY, path_to_rsa_key); // initialize set key-type ssh_bind_listen(b); -> error path "The DSA host key has the wrong type: %d", ssh_key_free(sshbind->dsa) -> ssh_key_clean(key) // OK -> SAFE_FREE(key) // OK, but, sshbind->dsa is *not* set to NULL // ssh_bind_listen failed, so clean up ssh_bind ssh_bind_free(b); -> ssh_key_free(sshbind->dsa) // double-free here To fix, set pointers to NULL that have been free'd with 'ssh_key_free'. Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* doc: Add changes to the forwarding tutorial.Andreas Schneider2014-01-161-5/+6
|
* channel: Fix the name scheme of the forward functions.Andreas Schneider2014-01-165-24/+40
|
* channel: Add ssh_channel_accept_forward().Oleksandr Shneyder2014-01-162-3/+24
| | | | | | | | This works same way as ssh_forward_accept() but can return a destination port of the channel (useful if SSH connection forwarding several TCP/IP ports). Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* Rename build directory to obj.Andreas Schneider2014-01-163-2/+2
| | | | | Some buildsystem use build in the pathname and so we will filter out e.g. docs generation.
* threads: support libgcrypt 1.6 hackAris Adamantiadis2014-01-083-2/+26
| | | | | | | Not 100% satisfied of this patch, but the way libgcrypt handles threading in 1.6 is not compatible with custom handlers. The new code basicaly uses pthreads in every case. This will probably not work on windows.
* include: Remove warning cause VSC doesn't know about it.Andreas Schneider2014-01-081-1/+0
|
* include: Fix building if we do not have asm volatile.Andreas Schneider2014-01-081-1/+2
|
* src: Update my mail address.Andreas Schneider2014-01-0719-19/+19
|
* cmake: Remove unused macro modules.Andreas Schneider2014-01-075-108/+0
|
* update copyright informationAris Adamantiadis2014-01-0720-26/+26
|
* tests: avoid reading uninitialized bytesAris Adamantiadis2014-01-071-2/+2
|
* pki: fix gcrypt signature processAris Adamantiadis2014-01-071-1/+1
|
* examples: Make sure buffer is initialized.Andreas Schneider2014-01-071-1/+1
|
* example: Add missing include for forkpty().Andreas Schneider2014-01-071-0/+3
|
* test: fixed torture_auth_none conditionAris Adamantiadis2014-01-061-2/+2
|
* test: test case for async auth_noneAris Adamantiadis2014-01-061-0/+59
| | | | This test currently fails
* tests: auth_agent_nonblocking should run in nonblockingAris Adamantiadis2014-01-061-0/+2
|
* tests: use LC_LIBSSH instead of LANG for env tests.Aris Adamantiadis2014-01-061-2/+2
| | | | | LANG is stripped and replaced on many distros and LC_* is accepted by default on debian
* session: Fix a possible memory leak.Andreas Schneider2014-01-051-0/+1
|
* poll: fix poll_handles ownershipsAris Adamantiadis2014-01-051-5/+27
|
* socket: don't attempt reading a non-connected socketAris Adamantiadis2014-01-051-1/+1
|
* examples: Fix building samplesshd-tty on FreeBSD.Andreas Schneider2013-12-261-2/+2
|
* poll: Correctly free ssh_event_fd_wrapper.Andreas Schneider2013-12-221-3/+9
| | | | This is allocated by ssh_event_add_fd.
* config: Support expansion in the Host variable too.Andreas Schneider2013-12-211-9/+18
| | | | BUG: https://red.libssh.org/issues/127
* tests: Fix non-blocking auth tests.Andreas Schneider2013-12-151-7/+15
| | | | | | The ssh_userauth_none() call should already be non-blocking. However this this function is broken in non-blocking mode. It should reveal the existing bug.
* tests: Fix blocking mode in password auth test.Andreas Schneider2013-12-151-1/+1
|
* tests: Use new auth API in the torture_session test.Andreas Schneider2013-12-151-2/+3
|
* tests: Use new auth API in the torture_auth test.Andreas Schneider2013-12-151-10/+19
|
* tests: Fix pki test with gcrypt.Andreas Schneider2013-12-111-0/+4
|
* channel: fix setting of channel->flagsJon Simons2013-12-111-3/+3
| | | | | | | | Fix the setting of 'channel->flags' to use '|='. Before this change, one bug symptom can be that channels are never fully free'd via ssh_channel_free, resulting in memory leaks. Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
* client: use ssh_channel_do_free in ssh_disconnectJon Simons2013-12-111-1/+1
| | | | | | | | | | Ensure to use 'ssh_channel_do_free' in 'ssh_disconnect', when removing and free'ing up a session's channels. This matches the behavior in 'ssh_free', and is necessary to fully free any channel which may not have been closed completely (see usage of flags SSH_CHANNEL_FLAG_CLOSED_REMOTE, SSH_CHANNEL_FLAG_FREED_LOCAL). Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
generated by cgit (git 2.34.1) at 2025-09-04 08:48:30 +0000