From a6fca9587905f455c4b0306b02d77334a295305e Mon Sep 17 00:00:00 2001 From: Abhishek Koneru Date: Fri, 18 May 2012 11:44:45 -0400 Subject: Fixes for Coverity Defects of Category : FB.BC_VACUOUS_INSTANCEOF --- base/util/src/netscape/security/x509/X509Cert.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'base/util/src/netscape') diff --git a/base/util/src/netscape/security/x509/X509Cert.java b/base/util/src/netscape/security/x509/X509Cert.java index 9162cc92f..ea1e26deb 100644 --- a/base/util/src/netscape/security/x509/X509Cert.java +++ b/base/util/src/netscape/security/x509/X509Cert.java @@ -159,9 +159,9 @@ public class X509Cert implements Certificate, Serializable { Date notAfter) throws CertException { subject = subjectName; - if (!(subjectPublicKey instanceof PublicKey)) + if (subjectPublicKey == null) throw new CertException(CertException.err_INVALID_PUBLIC_KEY, - "Doesn't implement PublicKey interface"); + "Public Key is NULL"); /* * The X509 cert API requires X509 keys, else things break. @@ -402,11 +402,11 @@ public class X509Cert implements Certificate, Serializable { String algorithm; Signature sig; - if (privateKey instanceof Key) { + if (privateKey != null) { Key key = privateKey; algorithm = key.getAlgorithm(); } else { - throw new InvalidKeyException("private key not a key!"); + throw new InvalidKeyException("Private Key is NULL"); } sig = Signature.getInstance(algorithmId.getName()); -- cgit