From 759d54747b779a1cb11f1b9fbfe8166e62dde03d Mon Sep 17 00:00:00 2001
From: Abhishek Koneru <akoneru@redhat.com>
Date: Fri, 29 Jun 2012 16:08:04 -0400
Subject: Coverity CATCH_REXCEPTION and UNREAD_FIELD_CASES

---
 .../com/netscape/cmsutil/ocsp/BasicOCSPResponse.java   | 18 +++++++-----------
 .../src/com/netscape/cmsutil/scep/CRSPKIMessage.java   |  7 +++++--
 base/util/src/com/netscape/cmsutil/util/Utils.java     |  7 +++++--
 3 files changed, 17 insertions(+), 15 deletions(-)

(limited to 'base/util/src/com/netscape')

diff --git a/base/util/src/com/netscape/cmsutil/ocsp/BasicOCSPResponse.java b/base/util/src/com/netscape/cmsutil/ocsp/BasicOCSPResponse.java
index 52535d3d0..1b8273eda 100644
--- a/base/util/src/com/netscape/cmsutil/ocsp/BasicOCSPResponse.java
+++ b/base/util/src/com/netscape/cmsutil/ocsp/BasicOCSPResponse.java
@@ -61,23 +61,19 @@ public class BasicOCSPResponse implements Response {
         _certs = certs;
     }
 
-    public BasicOCSPResponse(OCTET_STRING os) {
+    public BasicOCSPResponse(OCTET_STRING os) throws InvalidBERException, IOException {
         this(os.toByteArray());
     }
 
-    public BasicOCSPResponse(byte data[]) {
+    public BasicOCSPResponse(byte data[]) throws InvalidBERException, IOException {
         mData = data;
 
         // extract _rd, _signAlg, _signature and _certs
-        try {
-            BasicOCSPResponse resp = (BasicOCSPResponse) getTemplate().decode(new ByteArrayInputStream(data));
-            _rd = resp.getResponseData();
-            _signAlg = resp.getSignatureAlgorithm();
-            _signature = resp.getSignature();
-            _certs = resp.getCerts();
-        } catch (Exception e) {
-            // exception in decoding byte data
-        }
+        BasicOCSPResponse resp = (BasicOCSPResponse) getTemplate().decode(new ByteArrayInputStream(data));
+        _rd = resp.getResponseData();
+        _signAlg = resp.getSignatureAlgorithm();
+        _signature = resp.getSignature();
+        _certs = resp.getCerts();
     }
 
     private static final Tag TAG = SEQUENCE.TAG;
diff --git a/base/util/src/com/netscape/cmsutil/scep/CRSPKIMessage.java b/base/util/src/com/netscape/cmsutil/scep/CRSPKIMessage.java
index de6cb20aa..afde8b6c1 100644
--- a/base/util/src/com/netscape/cmsutil/scep/CRSPKIMessage.java
+++ b/base/util/src/com/netscape/cmsutil/scep/CRSPKIMessage.java
@@ -484,9 +484,12 @@ public class CRSPKIMessage {
 
             return baos.toByteArray();
             //            return crsd.getEncodedContents();
-        } catch (Exception e) {
-            return null;
+        } catch (InvalidBERException e) {
+            e.printStackTrace();
+        } catch (IOException e) {
+            e.printStackTrace();
         }
+        return null;
     }
 
     public String toString() {
diff --git a/base/util/src/com/netscape/cmsutil/util/Utils.java b/base/util/src/com/netscape/cmsutil/util/Utils.java
index c8d6b438d..98becdc4c 100644
--- a/base/util/src/com/netscape/cmsutil/util/Utils.java
+++ b/base/util/src/com/netscape/cmsutil/util/Utils.java
@@ -87,9 +87,12 @@ public class Utils {
                  **/
                 return false;
             }
-        } catch (Exception e) {
-            return false;
+        } catch (IOException e) {
+            e.printStackTrace();
+        } catch (InterruptedException e) {
+            Thread.currentThread().interrupt();
         }
+        return false;
     }
 
     public static String SpecialURLDecode(String s) {
-- 
cgit