From 1913ff38f04dd27641f23cb76b13cb4806720946 Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Wed, 29 Jun 2016 18:06:12 +0530 Subject: Added fix for checking ldapmodify return code in db-schema-upgrade Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1349769 --- base/server/python/pki/server/cli/db.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'base/server/python') diff --git a/base/server/python/pki/server/cli/db.py b/base/server/python/pki/server/cli/db.py index 5915417c2..6555e4078 100644 --- a/base/server/python/pki/server/cli/db.py +++ b/base/server/python/pki/server/cli/db.py @@ -100,7 +100,12 @@ class DBSchemaUpgrade(pki.cli.CLI): sys.exit(1) instance.load() - self.update_schema(instance, bind_dn, bind_password) + try: + self.update_schema(instance, bind_dn, bind_password) + + except subprocess.CalledProcessError as e: + print("ERROR: " + e.output) + sys.exit(e.returncode) self.print_message('Upgrade complete') @@ -122,10 +127,7 @@ class DBSchemaUpgrade(pki.cli.CLI): if secure.lower() == "true": cmd.append('-Z') - try: - subprocess.check_output(cmd) - except subprocess.CalledProcessError as e: - print('ldapmodify returns {}: {}'.format(e.returncode, e.output)) + subprocess.check_output(cmd, stderr=subprocess.STDOUT) class DBUpgrade(pki.cli.CLI): -- cgit