From 69a52e1179326895632ac0b4639ed8a8523091c9 Mon Sep 17 00:00:00 2001 From: "Endi S. Dewata" Date: Tue, 26 Apr 2016 22:32:41 +0200 Subject: Removed unused variables in deployment scriptlets. The unused rv instance variables in all deployment scriptlets have been removed. The spawn() and destroy() are now returning None instead of error code. If an error happens during execution the scriptlet will throw an exception which will be caught by pkispawn or pkidestroy and then displayed to the user. --- base/server/python/pki/server/deployment/scriptlets/finalization.py | 3 --- 1 file changed, 3 deletions(-) (limited to 'base/server/python/pki/server/deployment/scriptlets/finalization.py') diff --git a/base/server/python/pki/server/deployment/scriptlets/finalization.py b/base/server/python/pki/server/deployment/scriptlets/finalization.py index c816acd20..8f8cfe0ac 100644 --- a/base/server/python/pki/server/deployment/scriptlets/finalization.py +++ b/base/server/python/pki/server/deployment/scriptlets/finalization.py @@ -29,7 +29,6 @@ from .. import pkiscriptlet # PKI Deployment Finalization Scriptlet class PkiScriptlet(pkiscriptlet.AbstractBasePkiScriptlet): - rv = 0 def spawn(self, deployer): @@ -93,7 +92,6 @@ class PkiScriptlet(pkiscriptlet.AbstractBasePkiScriptlet): deployer.mdict['pki_instance_name'], extra=config.PKI_INDENTATION_LEVEL_0) deployer.file.modify(deployer.mdict['pki_spawn_log'], silent=True) - return self.rv def destroy(self, deployer): @@ -112,4 +110,3 @@ class PkiScriptlet(pkiscriptlet.AbstractBasePkiScriptlet): deployer.mdict['pki_subsystem'], deployer.mdict['pki_instance_name'], extra=config.PKI_INDENTATION_LEVEL_0) - return self.rv -- cgit