From 45c80df9cfcc26d251be2eb50d787dcecd40f388 Mon Sep 17 00:00:00 2001 From: "Endi S. Dewata" Date: Thu, 1 May 2014 18:37:05 -0400 Subject: Replace filter in UGSubsystem.listGroups(). The UGSubsystem.listGroups() has been modified to generate an LDAP filter from a keyword. The filter itself cannot contain wildcards. The wildcard will be added in listGroups(). In the future the filter will be made configurable to allow searching different attributes. Ticket #920 --- .../src/com/netscape/cms/servlet/admin/GroupMemberProcessor.java | 2 +- .../cms/src/com/netscape/cms/servlet/admin/UsrGrpAdminServlet.java | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) (limited to 'base/server/cms/src/com') diff --git a/base/server/cms/src/com/netscape/cms/servlet/admin/GroupMemberProcessor.java b/base/server/cms/src/com/netscape/cms/servlet/admin/GroupMemberProcessor.java index ff56c2139..78f602acd 100644 --- a/base/server/cms/src/com/netscape/cms/servlet/admin/GroupMemberProcessor.java +++ b/base/server/cms/src/com/netscape/cms/servlet/admin/GroupMemberProcessor.java @@ -300,7 +300,7 @@ public class GroupMemberProcessor extends Processor { } try { - Enumeration groups = userGroupManager.listGroups("*"); + Enumeration groups = userGroupManager.listGroups(null); while (groups.hasMoreElements()) { IGroup group = groups.nextElement(); String name = group.getName(); diff --git a/base/server/cms/src/com/netscape/cms/servlet/admin/UsrGrpAdminServlet.java b/base/server/cms/src/com/netscape/cms/servlet/admin/UsrGrpAdminServlet.java index c4eed9068..836369bc4 100644 --- a/base/server/cms/src/com/netscape/cms/servlet/admin/UsrGrpAdminServlet.java +++ b/base/server/cms/src/com/netscape/cms/servlet/admin/UsrGrpAdminServlet.java @@ -555,7 +555,7 @@ public class UsrGrpAdminServlet extends AdminServlet { Enumeration e = null; try { - e = mMgr.listGroups("*"); + e = mMgr.listGroups(null); } catch (Exception ex) { ex.printStackTrace(); sendResponse(ERROR, CMS.getUserMessage(getLocale(req), "CMS_INTERNAL_ERROR"), null, resp); @@ -2068,6 +2068,9 @@ public class UsrGrpAdminServlet extends AdminServlet { return false; } + /** + * TODO: replace this with GroupMemberProcessor.isDuplicate() + */ private boolean isDuplicate(String groupName, String memberName) { Enumeration groups = null; @@ -2082,7 +2085,7 @@ public class UsrGrpAdminServlet extends AdminServlet { return false; } try { - groups = mMgr.listGroups("*"); + groups = mMgr.listGroups(null); while (groups.hasMoreElements()) { IGroup group = groups.nextElement(); String name = group.getName(); -- cgit