From 8a8436f73d4c4edd10b43313b724f32ccb7b957e Mon Sep 17 00:00:00 2001
From: Abhishek Koneru <akoneru@redhat.com>
Date: Wed, 20 Jun 2012 13:56:57 -0400
Subject: Fixes for Coverity issues of type Resource Leaks - Remaining

---
 base/kra/src/com/netscape/kra/StorageKeyUnit.java | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

(limited to 'base/kra/src/com/netscape/kra/StorageKeyUnit.java')

diff --git a/base/kra/src/com/netscape/kra/StorageKeyUnit.java b/base/kra/src/com/netscape/kra/StorageKeyUnit.java
index 3d679e3d8..f968a8c44 100644
--- a/base/kra/src/com/netscape/kra/StorageKeyUnit.java
+++ b/base/kra/src/com/netscape/kra/StorageKeyUnit.java
@@ -261,19 +261,28 @@ public class StorageKeyUnit extends EncryptionUnit implements
 
             if (mKeySplitting) {
                 // read private key from the file
+                FileInputStream fi = null;
                 try {
                     File priFile = new File(mConfig.getString(PROP_KEYDB));
 
                     mPrivateKeyData = new byte[
                             (Long.valueOf(priFile.length())).intValue()];
-                    FileInputStream fi = new FileInputStream(priFile);
+                    fi = new FileInputStream(priFile);
 
                     fi.read(mPrivateKeyData);
-                    fi.close();
+
                 } catch (IOException e) {
                     mKRA.log(ILogger.LL_FAILURE,
                             CMS.getLogMessage("CMSCORE_KRA_STORAGE_READ_PRIVATE", e.toString()));
                     throw new EBaseException(CMS.getUserMessage("CMS_BASE_INVALID_KEY_1", e.toString()));
+                } finally {
+                    if (fi != null) {
+                        try {
+                            fi.close();
+                        } catch (IOException e) {
+                            e.printStackTrace();
+                        }
+                    }
                 }
             }
 
-- 
cgit